Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
xogium
@xogium
seems that the actual internal server error comes with git master but not with the 4.35 fix
if it helps
Naoki Takezoe
@takezoe
Is there no error message?
xogium
@xogium
there is, in the system logs
I'll try to pastebin that
but the error on the site is like, contact your administrator
this only happens when you're logged in
Naoki Takezoe
@takezoe
Ah, this is a plugin binary compatibility issue. We need to rebuild plugin or revert some changes on GitBucket core which broke the binary compatibility.
xogium
@xogium
ah, that makes sense
xogium
@xogium
a plugin that is only used when you're logged in would cause that I guess
Naoki Takezoe
@takezoe
This line affected.
Yes.
xogium
@xogium
well, that was at least easy to figure out :p
Naoki Takezoe
@takezoe
Since the next release is a hotfix, I will revert this change. Thanks for reporting quickly.
xogium
@xogium
no worries
glad to help as always :)
that's why softwares need people that like bleeding edge ;) that way bugs can be fixed faster
and I'm very happy to use gitbucket to host our project to make usable low-cost hardware for the blind people
Naoki Takezoe
@takezoe
I'm glad to hear that.
xogium
@xogium
should have seen me struggling with gitea hehe
problem with gitea is they just don't care about accessibility, or so little they aren't against reverting changes that helped with it, and the ui framework they use, fomantic ui / scemantics ui goes as far to actually rejecting pr to improve it
so yeah I'm glad I found gitbucket before the project started, because I have a funny feeling migrating from one to the other wouldn't have been fun
Naoki Takezoe
@takezoe
Hm, I see. I think Bootstrap may not be better than Fomatic-UI in terms of accessibility :sweat_smile:
xogium
@xogium
oh, no no ! It is a TON better :)
most of its default gadgets already have a minimum of accessibility built-in and the code only needed some tweaks here and there that someone did a while back
the problem with bootstrap is when you decide to reinvent the wheel and create an entirely custom gadget, instead of using a premade one
but all the aria roles and labels and things are exactly the kind of things needed so we can know what we're actually on, like is it a combo box, or a text field
I believe bootstraps aria support is rated 5/5 and semantics was rated 0/5
Naoki Takezoe
@takezoe
Interesting. I'm a basically server-side backend engineer and be not very familiar with frontend technologies and accessibility. Knowing such ideas is fun.
xogium
@xogium
hehe I imagined so. Someone else is doing the html and ui then ?
xogium
@xogium
though poor gitbucket with nginx in front seems to not like large repo very much… I tried to push the linux kernel repository, it almost worked but ended up timing out resolving deltas
Francesco Chicchiriccò
@ilgrosso
thanks @takezoe for taking care of the migration issue!
I could not check it again as we are now fine with our prd deployment, but code changes looks ok :+1:
Naoki Takezoe
@takezoe
@ilgrosso Your report was really helpful to find the root cause of the issue!
xogium
@xogium
yeah more helpful than mine lol
Naoki Takezoe
@takezoe
I'm now preparing for 4.35.1. As I mentioned above, some changes need to be reverted to keep the binary compatibility for plugins. It will be released within a couple of days.
xogium
@xogium
I tried to get the logs but they were moving way too fast
Naoki Takezoe
@takezoe
:sweat_smile:
xogium
@xogium
well, at least I helped a bit with plugin incompatibility :D
Naoki Takezoe
@takezoe
Yeah, thank you for testing the master branch actively.
xogium
@xogium
no problem ! :)
Naoki Takezoe
@takezoe
xogium
@xogium
yay ! Thank you Takezoe
may I ask what you name means ?
Naoki Takezoe
@takezoe
Meaning of my name? I've never thought about it.
xogium
@xogium
haha
yeah I was curious, some japanese people I meet sometimes attach a real importance to their names, so I was curious if this was a curtural thing
*cultural even
Naoki Takezoe
@takezoe
Actually, Takezoe is one of traditional names in a particular area of Japan.