Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 11:50
    xuwei-k closed #2878
  • 11:40
    xuwei-k closed #2877
  • 11:39
    scala-steward-bot review_requested #2878
  • 11:39
    scala-steward-bot opened #2878
  • 11:39
    scala-steward-bot review_requested #2877
  • 11:39
    scala-steward-bot opened #2877
  • 11:08
    xuwei-k closed #2875
  • 10:57

    xuwei-k on master

    Update testcontainers-scala to … (compare)

  • 10:57
    xuwei-k closed #2874
  • 10:55
    xuwei-k edited #2871
  • 10:52
    xuwei-k auto_merge_enabled #2874
  • 10:51
    xuwei-k closed #2876
  • 10:44
    scala-steward-bot review_requested #2876
  • 10:44
    scala-steward-bot opened #2876
  • 10:44
    scala-steward-bot review_requested #2875
  • 10:44
    scala-steward-bot opened #2875
  • 10:44
    scala-steward-bot review_requested #2874
  • 10:44
    scala-steward-bot opened #2874
  • Sep 19 11:52
    braverstone starred gitbucket/gitbucket
Ghost
@ghost~56df1ec7e610378809c5a90e
occurred in the application and your page could not be served. If you are the application owner, check your logs for details. You can do this from the Heroku CLI with the command
heroku logs --tail
there
Shreejan Shrestha
@shreejanshrestha
Issue same as #544 is appearing from release 4.34.0. Is anybody facing this?
Naoki Takezoe
@takezoe
Actually, #544 has been reported by Windows users many times in the past, but I'm still not sure how to solve it. Also, I don' have a Window environment now, so I cannot look into this issue. Can anyone who uses GitBucket on Windows help?
Josh Curtiss
@joshuacurtiss
I know it doesn’t directly address the cause of the problem but we had discussed catching the error and queuing future attempts to delete when windows may eventually let go. Not ideal but potentially better than throwing an unresolved error.
Naoki Takezoe
@takezoe
Ah, asynchronous deletion. I see.
By the way, I'm going to talk about GitBucket at upcoming ScalaLove in the City virtual conference next weekend! Please join the event if you have time :-)
https://emamo.com/event/scala-love-in-the-city/r/speaker/naoki-takezoe
Josh Curtiss
@joshuacurtiss
Nice!
onukura
@onukura
:+1:
Jerry Wiltse
@solvingj
I have a question / problem. Might be a bug.
i'll open github issue
xogium
@xogium
hmm so I was wondering, in the collaborators section of a repository, how do we figure out what role each collaborator has ? All I can see as a blind user is the collaborator name and the option to remove them
and the radio button to select their role is always unchecked so I don' know that either
xogium
@xogium
same for handling the members of a group
xogium
@xogium
so… is it just me or is it a real bug that when you select a role for a collaborator then click apply, the next time the page appears, you apparently have set that role but then you don't know it because all the radio buttons are unchecked ?
same for group members
maybe it's an accessibility bug, but I don't know
flyingone
@flyingone
Hi everybody
I have just done the setup ( installation using external database on mysql ) ..
xogium
@xogium
hi
flyingone
@flyingone
In my setup of gitbucket, a pull request is visible to all the contributor on repo . How can i restrict it to only repo admin.
xogium
@xogium
I don't think you can do that…
but I coould be wrong
flyingone
@flyingone
So it should be like this .. 1- Let it be visible to all, but only admin can merge it
xogium
@xogium
ah, hmmm maybe there is a setting for this in the repository setting ? Or maybe in the global administration if gitbucket
*of
flyingone
@flyingone
i have 3 options in the repo setting ..
Disable issue tracking and pull requests
Developers can view, create, and comment on issues and pull requests
Developers and guests can view, create, and comment on issues and pull requests
xogium
@xogium
hmm right, maybe it will need a 4th option then, indeed
flyingone
@flyingone
nothing mentioned to restrict merge to repo admin
xogium
@xogium
I'm no dev, but I suppose it can't hurt to open an issue about this :)
1 reply
flyingone
@flyingone
Such control is required to moderate changes in the repo master
xogium
@xogium
yes
:)
just open one on the github for gitbucket
flyingone
@flyingone
ok
thanks
xogium
@xogium
no problem, glad to help in any way I can
towbi
@towbi
Hi there, I have a gitbucket installation running on 4.24.0. (released 30 Apr 2018). Can I directly upgrade to the current version (4.35.3 - 14 Jan 2021) or do I need to follow some upgrade path?
Naoki Takezoe
@takezoe
@towbi Yes, you can upgrade to 4.35.3 directly. Basically, GitBucket can be upgraded from any versions to newer versions, but I strongly recommend to take a backup before upgrading.
Naoki Takezoe
@takezoe
@flyingone Granular access control is one missing feature in GitBucket because it's originally designed for small software development teams. I think that system-wide design is necessary rather than implementing security requirements one by one in order to make a consistent and flexible access control mechanism. If I remember correctly, we already have an issue for that on GitHub. Maybe adding your requirements to that issue would be helpful to consider the design of the next generation of access control mechanism on GitBucket.
Naoki Takezoe
@takezoe
Hmm, but I cannot find the existing issue... Creating a new issue is fine. When I find the existing one, we can merge them. :bow:
flyingone
@flyingone
Thanks Naoki .. please find issues gitbucket/gitbucket#2687
1 reply
Shreejan Shrestha
@shreejanshrestha

@takezoe

Actually, #544 has been reported by Windows users many times in the past, but I'm still not sure how to solve it. Also, I don' have a Window environment now, so I cannot look into this issue. Can anyone who uses GitBucket on Windows help?

I could delete without error using following patch. How do think about it?

diff --git a/src/main/scala/gitbucket/core/service/RepositoryService.scala b/src/main/scala/gitbucket/core/service/RepositoryService.scala
index 831820eac3c78e784eb980125a25b0d3f2c8d7e6..9fd325232449f0772b1c7a70a6c6756c28eeb943 100644
--- a/src/main/scala/gitbucket/core/service/RepositoryService.scala
+++ b/src/main/scala/gitbucket/core/service/RepositoryService.scala
@@ -14,6 +14,7 @@ import org.apache.commons.io.FileUtils
 import org.eclipse.jgit.api.Git
 import org.eclipse.jgit.lib.{Repository => _, _}
 import scala.util.Using
+import java.io.{File, FileNotFoundException, IOException}

 trait RepositoryService {
   self: AccountService =>
@@ -233,14 +234,23 @@ trait RepositoryService {
     }
   }

+  def deleteRecursively(f: File): Boolean = {
+    if (f.isDirectory) f.listFiles match {
+      case files: Array[File] => files.foreach(deleteRecursively)
+      case null               =>
+    }
+    f.delete()
+  }
+
   def deleteRepository(repository: Repository)(implicit s: Session): Unit = {
     LockUtil.lock(s"${repository.userName}/${repository.repositoryName}") {
       deleteRepositoryOnModel(repository.userName, repository.repositoryName)

-      FileUtils.deleteDirectory(getRepositoryDir(repository.userName, repository.repositoryName))
-      FileUtils.deleteDirectory(getWikiRepositoryDir(repository.userName, repository.repositoryName))
-      FileUtils.deleteDirectory(getTemporaryDir(repository.userName, repository.repositoryName))
-      FileUtils.deleteDirectory(getRepositoryFilesDir(repository.userName, repository.repositoryName))
+      deleteRecursively(getRepositoryDir(repository.userName, repository.repositoryName))
+
+      deleteRecursively(getWikiRepositoryDir(repository.userName, repository.repositoryName))
+      deleteRecursively(getTemporaryDir(repository.userName, repository.repositoryName))
+      deleteRecursively(getRepositoryFilesDir(repository.userName, repository.repositoryName))

       // Call hooks
       PluginRegistry().getRepositoryHooks.foreach(_.deleted(repository.userName, repository.repositoryName))
6 replies
dumpaliaravind
@dumpaliaravind
HI All, How can i migrate the gitbucket repo's to bitbucket?
1 reply
Shin
@shinsenter
When using docker, I had problems with db migration when updating from 4.34.0 (tag gitbucket/gitbucket:4) to 4.35.3. Reverting back to 4.34.0 working well. Hope to be supported. よろしくお願いします。
6 replies
xogium
@xogium
hi Takezoe ! Was wondering if you or anyone here saw my question about the radio buttons for role of collaborators or group members… is this some kind of bug for everyone or is it just accessibility related ?
the fact that after selecting one for a member then clicking apply changes, the choice I picked doesn't seem to be displayed in any way
all the buttons are unselected when the page comes up the next time