Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 30 17:04
    PatrickHeneise commented #215
  • Jan 30 09:27
    iancrowther commented #215
  • Jan 25 13:59
    PatrickHeneise commented #215
  • Jan 24 14:36
    iancrowther commented #215
  • Jan 08 04:12
    PatrickHeneise edited #215
  • Jan 08 04:12
    PatrickHeneise labeled #215
  • Jan 08 04:12
    PatrickHeneise opened #215
  • Oct 26 2017 11:05
    PatrickHeneise unassigned #181
  • Oct 26 2017 11:05
    PatrickHeneise unassigned #173
  • Jan 03 2017 11:01

    PatrickHeneise on merging

    (compare)

  • Jan 03 2017 11:01

    PatrickHeneise on greenkeeper-istanbul-0.4.2

    (compare)

  • Jan 03 2017 11:01

    PatrickHeneise on greenkeeper-moment-2.11.1

    (compare)

  • Jan 03 2017 11:01

    PatrickHeneise on greenkeeper-express-4.13.4

    (compare)

  • Jan 03 2017 11:01

    PatrickHeneise on greenkeeper-yaml-front-matter-3.3.0

    (compare)

  • Jan 03 2017 11:01

    PatrickHeneise on greenkeeper-moment-2.11.2

    (compare)

  • Jan 03 2017 11:01

    PatrickHeneise on greenkeeper-body-parser-1.15.0

    (compare)

  • Jan 03 2017 11:00

    PatrickHeneise on greenkeeper-supertest-1.2.0

    (compare)

  • Jan 03 2017 11:00

    PatrickHeneise on greenkeeper-yaml-front-matter-3.4.0

    (compare)

  • Jan 03 2017 11:00

    PatrickHeneise on greenkeeper-tape-4.5.0

    (compare)

  • Jan 03 2017 11:00

    PatrickHeneise on greenkeeper-tape-4.5.1

    (compare)

Niko Nevala
@nnevala
having a separate integration test would be good too
Patrick Heneise
@PatrickHeneise
@martinheidegger would be great to get your feedback as well since you're using mostly meetup, no?
Martin Heidegger
@martinheidegger
I am using doorkeeper!
And meetup too
And sometimes peatix
:)
Doorkeeper doesn’t have an API
Will look at it tomorrow (now sleepy time
Niko Nevala
@nnevala
gitevents/gitevents-meetup#9
PR for the meetup plugin for retrieving RSVPs
gaah
spammed by hound ci :P
which complains that console and require are not defined
maybe there's a node flag that can be set somewhere?
Patrick Heneise
@PatrickHeneise
I'll check about the require, but there shouldn't be any console stuff
merged, looks all good
will hopefully find some time this weekend to test
Niko Nevala
@nnevala
cool
Patrick Heneise
@PatrickHeneise
thank you!
Niko Nevala
@nnevala
as far as I can tell Tito v2 API does not support retrieving tickets for events (yet?)
so can't get the RSVPs for Tito as of now without mixing v1 and v2 API usage in the plugin
which doesn't sound amazing
Patrick Heneise
@PatrickHeneise
btw. travis is still failing. Would be great to get that resolved https://travis-ci.org/gitevents/core
@nnevala I'm sure ti.to is behind the API at the moment and working hard, @iancrowther could reach out and put the tickets a little higher on the list for v2, in the meantime we can focus on other issues?
Niko Nevala
@nnevala
I have other work coming in at the moment so can't focus on gitevents that much now
Michael Barrett
@mike182uk
@PatrickHeneise I've raised a PR here (gitevents/core#159) that cleans up some of the testing stuff with an attempt to try and get the build passing
Its currently failing due to snyk finding vuln in some of the deps
Patrick Heneise
@PatrickHeneise
thanks mike!
Ian Crowther
@iancrowther
@mike182uk what do you recommend we do about snyk
do we holt dev? warn users? raise issues with deps?
Patrick Heneise
@PatrickHeneise
I like the idea of snyk, but it's also annoying. With one package I wrote the maintainer and even PR the change on the repo, but they didn't react
Ian Crowther
@iancrowther
my preference would be to raise a warning to users
Michael Barrett
@mike182uk
It looks like synk can auto patch things for you, but i couldn't get it to work (snyk wizard)
I've done a bit of house keeping on the open issues, feel free to re-open things if you think they are still valid :smile:
Patrick Heneise
@PatrickHeneise
awesome thanks!
Niko Nevala
@nnevala
gitevents/gitevents-cli#9
Ian Crowther
@iancrowther
Patrick Heneise
@PatrickHeneise
Done
Ian Crowther
@iancrowther
danke
Ivan Fraixedes
@ifraixedes
Hi
anybody here
I'm on this issue
gitevents/core#181
I think that removing two lines of the test will make the test past again
basically because that it works in my machine
the problem is that test/integration/talks fail in 7 test cases
I'm wondering if for running the test I should do some setup which I haven't done
Ian Crowther
@iancrowther
hey
not sure
Ivan Fraixedes
@ifraixedes
ok, I've posted a comment in the issue
Patrick Heneise
@PatrickHeneise
I'll check tomorrow but there has been quite some (unfortunate) refactoring on the tests and I'm not yet up to date.