Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Dec 07 08:56
    yansheng836 edited #229
  • Dec 07 08:56
    yansheng836 edited #229
  • Dec 07 08:54
    yansheng836 edited #229
  • Dec 07 08:50
    yansheng836 opened #229
  • Dec 07 08:28
    yansheng836 commented #214
  • Dec 06 18:09
    blairg23 opened #228
  • Dec 05 09:19
    liangweihua-rock opened #227
  • Dec 04 23:45
    blairg23 commented #219
  • Dec 04 22:51
    codecov-io commented #226
  • Dec 04 22:51
    codecov-io commented #226
  • Dec 04 22:50
    codecov-io commented #226
  • Dec 04 22:44
    blairg23 opened #226
  • Dec 03 00:53
    ipolevoy commented #223
  • Dec 01 15:44
    yansheng836 closed #218
  • Dec 01 15:44
    yansheng836 commented #218
  • Nov 14 18:07
    Tybot204 edited #220
  • Nov 14 18:06
    Tybot204 commented #220
  • Nov 14 10:44
    idlem1nd commented #220
  • Nov 14 10:43
    idlem1nd commented #220
  • Nov 13 19:18
    Tybot204 commented #220
Alex Canessa
@alexcanessa
@DawoudIO @futureplayer of course could not be that easy. GitHub API has a limit on the maximum items we can set then.
unluckly it’s difficult to test as I don’t have a repo with so many tags, but I’ll try to implement the fix ASAP.
You can follow the discussion here: #95
futureplayer
@futureplayer
ok, Thanks
George Dawoud
@DawoudIO
@alexcanessa is v10+ not backward compatable with v9-

i also got the following `/home/ubuntu/.nvm/versions/node/v6.11.2/lib/node_modules/github-release-notes/dist/Program.js:277
return Object.entries(object).reduce(function (carry, _ref9) {
^

TypeError: Object.entries is not a function
at Program._camelCaseObjectKeys (/home/ubuntu/.nvm/versions/node/v6.11.2/lib/node_modules/github-release-notes/dist/Program.js:277:27)
at Program._consumeOptions (/home/ubuntu/.nvm/versions/node/v6.11.2/lib/node_modules/github-release-notes/dist/Program.js:217:33)
at new Program (/home/ubuntu/.nvm/versions/node/v6.11.2/lib/node_modules/github-release-notes/dist/Program.js:34:37)
at Object.<anonymous> (/home/ubuntu/.nvm/versions/node/v6.11.2/lib/node_modules/github-release-notes/bin/gren-changelog.js:18:24)
at Module._compile (module.js:570:32)
at Object.Module._extensions..js (module.js:579:10)
at Module.load (module.js:487:32)
at tryModuleLoad (module.js:446:12)
at Function.Module._load (module.js:438:3)
at Module.runMain (module.js:604:10)`

Alex Canessa
@alexcanessa
@DawoudIO what version of node/npm do you have?
Alex Canessa
@alexcanessa
Actually I think I’ve picked up the bug, it’s now on this issue #99
It’s going to be part of the next patch (tonight)
(please write here your node v so I can test there)
George Dawoud
@DawoudIO
Sure I’ll also create a test system for you if you want on Cloud9
Alex Canessa
@alexcanessa

@DawoudIO @futureplayer Release 0.12.1 now out and everything should work!

No need —limit option anymore as now —tags=all does release notes for every release

George Dawoud
@DawoudIO
I’ll test today
George Dawoud
@DawoudIO
@alexcanessa
node v6.11.2
npm v3.10.10

`dawoudio:~/workspace (grunt-changelog) $ npm install github-release-notes@0.12.1
ChurchCRM@2.8.11 /home/ubuntu/workspace
├── github-release-notes@0.12.1 invalid
└── UNMET PEER DEPENDENCY grunt@1.0.1

npm WARN grunt-poeditor-ab@0.1.9 requires a peer of grunt@~0.4.0 but none was installed.
dawoudio:~/workspace (grunt-changelog) $ grunt -V
grunt-cli v1.2.0
grunt v1.0.1`

dawoudio:~/workspace (grunt-changelog) $ grunt -V
grunt-cli v1.2.0
grunt v1.0.1
Alex Canessa
@alexcanessa
@DawoudIO gren doesn’t use grunt at all, are you sure is not something coming from Church?
George Dawoud
@DawoudIO
Hmm ok let me check
George Dawoud
@DawoudIO
@alexcanessa i noticed v13 i'll try testing that
George Dawoud
@DawoudIO
looks great... works on my c9 account - ChurchCRM/CRM#3132
thanks for keeping at it
Alex Canessa
@alexcanessa
@DawoudIO :+1:
George Dawoud
@DawoudIO
@alexcanessa are you guys keeping up grunt-github-release-notes with updates?
Alex Canessa
@alexcanessa
@DawoudIO not right now. Are you able to run gren via npm script?
(instead of grunt i mean)
George Dawoud
@DawoudIO
Ya I can I’ll do that ... no worries
George Dawoud
@DawoudIO
@alexcanessa just wanted to follow up that using 0.13.0 and it been great
thanks so much for the good work
Alex Canessa
@alexcanessa
Thanks @DawoudIO, that’s really nice to hear <3
Mikko Lauhakari
@lauhakari
Hey man, @alexcanessa
Alex Canessa
@alexcanessa
@lauhakari Hello hello
Navdeep Gill
@navdeep-G
hello, is it possible to use this tool with a private repo?
Navdeep Gill
@navdeep-G
I actually got the above to work
George Dawoud
@DawoudIO
As long as the api key has access the. Yes
;)
Navdeep Gill
@navdeep-G
however, i did notice that gren changelog does not utilize all of the releases
i have about 57 but only see 29 in the changelog
George Dawoud
@DawoudIO
They fixed that In the last version
Alex Canessa
@alexcanessa

@DawoudIO is right it should be fine as per this function:

https://github.com/github-tools/github-release-notes/blob/78786b31a7a85afc884092af41c681669fe9652e/lib/src/Gren.js#L380-L396

@navdeep-G are you sure that you have actual published releases?

Mathias Lykkegaard Lorenzen
@ffMathy
guys, i don't think gren works for the latest node version.
NPM 5.8.0, Node 8.9.1
Wait, that IS actually LTS. Never mind.
when I invoke gren release, i get the following error:
Error: ENOENT: no such file or directory, open '<current working dir>\release'
Mathias Lykkegaard Lorenzen
@ffMathy
oh, wow. i realized it was because i installed the npm package "gren", and not "github-release-notes"
that's pretty confusing that it doesn't align with the CLI command name.
Mikko Lauhakari
@lauhakari
github-release-notes would be a very long cli command name though :P
everyone would make a shortcut, like gren ;)