Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Sep 18 16:18
    Pibart starred github/VisualStudio
  • Sep 18 14:51
    shana synchronize #2408
  • Sep 18 14:51

    shana on remove-experimental-PR-file-margin

    Bump version to 2.10.3 Merge branch 'master' into rele… Merge branch 'master' into rele… and 10 more (compare)

  • Sep 18 06:40
    ahdung commented #2410
  • Sep 18 06:36
    ahdung commented #2410
  • Sep 17 10:43
    AlBannaTechno starred github/VisualStudio
  • Sep 16 18:08
    jcansdale edited #2417
  • Sep 16 18:07
    jcansdale edited #2417
  • Sep 16 16:47
    jcansdale review_requested #2417
  • Sep 16 11:56
  • Sep 16 11:56
    wade1990 starred github/VisualStudio
  • Sep 16 11:48
    username30 commented #2414
  • Sep 16 11:45
    username30 commented #2414
  • Sep 16 11:45
    username30 commented #2414
  • Sep 16 11:35
    jcansdale commented #2414
  • Sep 16 11:29
    jcansdale commented #2414
  • Sep 16 11:27
    jcansdale synchronize #2417
  • Sep 16 11:27

    jcansdale on login-api

    Add some xmldoc comments (compare)

  • Sep 16 11:19
    jcansdale edited #2417
  • Sep 16 11:18
    jcansdale edited #2417
Steven Kirk
@grokys
we should either do it the old way and just set the flag when showing the dialog
Andreia Gaita
@shana
it got removed here: github/VisualStudio@5106ff5
Steven Kirk
@grokys
yep, my fault there
so i think DoCreate should be changed to:
        public void DoCreate()
        {
            isCreating = true;
            ServiceProvider.GitServiceProvider = TEServiceProvider;
            var dialogService = ServiceProvider.GetService<IDialogService>();
            dialogService.ShowCreateRepositoryDialog(SectionConnection);
        }
Andreia Gaita
@shana
if all codepaths that can show the repository creation dialog go through that method, yeah
Steven Kirk
@grokys
yeah, they do
@micheleissa and the same goes for isCloning
thanks @shana !
Andreia Gaita
@shana
the reason why the flag was set on Subscribe is that if it's set on DoCreate, when the login happens and the repository list is populated, the logic dictates the message of "repo created" shows up
because we're waiting for the repository list to get a new repository in order to detect when it gets cloned/created
Steven Kirk
@grokys
ahhh
Andreia Gaita
@shana
which gets called every time a UI is shown in the dialog, and it only set the flag when the create/clone UI is shown, after login is done
so setting it in DoCreate again is going to trigger messages too early
Steven Kirk
@grokys
ok, i see the problem
Andreia Gaita
@shana
I have no idea how I remember this, apparently it was annoying enough to make a dent in my memory
Steven Kirk
@grokys
haha yeah i'm pretty impressed!
shana @shana thanks past self for writing commit messages
Steven Kirk
@grokys
ok, so we could change it such that IDialogService.ShowCreateRepositoryDialog actually returns the created repository and show the message directly in DoCreate rather than monitoring the repository list for changes
that would probably be neater
Andreia Gaita
@shana
the problem is that the API for cloning repositories is non-blocking and returns immediately
Steven Kirk
@grokys
ohhhhh
Andreia Gaita
@shana
so it returns before the repo is cloned
Steven Kirk
@grokys
gah
Andreia Gaita
@shana
yes I know!
hackity hack
Steven Kirk
@grokys
ok @micheleissa this looks like it's not going to be so straightfoward
Andreia Gaita
@shana
yeah you might want to have an observable on the dialog service telling you when a new UI is shown
so you know when it's safe to set that flag :/
Steven Kirk
@grokys
maybe IDialogService.ShowCreateRepositoryDialog could simply return a bool indicating whether it kicked off a create/clone?
Andreia Gaita
@shana
yeah, was thinking that too
if you do that, you should probably cache the last seen "new" repo just in case it's so fast creating it that you get the property notification of a new repo being added to the list before the dialog service returns
Steven Kirk
@grokys
hmm
Andreia Gaita
@shana
but then you won't know if you have to wait for another notificaition of a repo being added
gah
tricksies
it's a bit of a race - when is it safe to process the property notification of a repo being added to the list
Steven Kirk
@grokys
i think the problem is that the dialog kicks off the action, whereas it should just return the results of the dialog and let the client kick off the action
Andreia Gaita
@shana
yeah
you really need to control when exactly the action is started, so you know the point at which to start monitoring for results
Steven Kirk
@grokys
yeah. BAD API VS
Andreia Gaita
@shana
yeah...
Steven Kirk
@grokys
so previously, what would happen if say a create failed and then the user added a new repo themselves? would the message be shown when the user-added repo was detected?
Andreia Gaita
@shana
yeah, I don't see the flag ever being reset on failure
Steven Kirk
@grokys
actually IDialogService.ShowCloneDialog already does return the dialog result for the client to kick off the clone
Andreia Gaita
@shana
so the other one should do the same
Steven Kirk
@grokys
i will change ShowCreateRepositoryDialog
or would you like to do that @micheleissa ?
Bryan James
@BryanJames16
Hello Good Evening!
Bryan James
@BryanJames16
I downloaded Krypton 4.7 (for .NET 4.7) and compiled it. However, if I tried adding the DLLs to the toolbox (by choosing Toolbox Items) I always get an error: "The file 'C:\Users\BryanJames\Desktop\APPLICATION\DEVELOPER\LANGUAGE\C#\LibraryManagementSystem\LibraryManagementSystem\Extensions\Krypton Toolkit.dll' is not valid. I already tried dragging it to the toolbox. But it doesn't fix the problem. Any ideas?