Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Sep 18 16:18
    Pibart starred github/VisualStudio
  • Sep 18 14:51
    shana synchronize #2408
  • Sep 18 14:51

    shana on remove-experimental-PR-file-margin

    Bump version to 2.10.3 Merge branch 'master' into rele… Merge branch 'master' into rele… and 10 more (compare)

  • Sep 18 06:40
    ahdung commented #2410
  • Sep 18 06:36
    ahdung commented #2410
  • Sep 17 10:43
    AlBannaTechno starred github/VisualStudio
  • Sep 16 18:08
    jcansdale edited #2417
  • Sep 16 18:07
    jcansdale edited #2417
  • Sep 16 16:47
    jcansdale review_requested #2417
  • Sep 16 11:56
  • Sep 16 11:56
    wade1990 starred github/VisualStudio
  • Sep 16 11:48
    username30 commented #2414
  • Sep 16 11:45
    username30 commented #2414
  • Sep 16 11:45
    username30 commented #2414
  • Sep 16 11:35
    jcansdale commented #2414
  • Sep 16 11:29
    jcansdale commented #2414
  • Sep 16 11:27
    jcansdale synchronize #2417
  • Sep 16 11:27

    jcansdale on login-api

    Add some xmldoc comments (compare)

  • Sep 16 11:19
    jcansdale edited #2417
  • Sep 16 11:18
    jcansdale edited #2417
Steven Kirk
@grokys
haha yeah i'm pretty impressed!
shana @shana thanks past self for writing commit messages
Steven Kirk
@grokys
ok, so we could change it such that IDialogService.ShowCreateRepositoryDialog actually returns the created repository and show the message directly in DoCreate rather than monitoring the repository list for changes
that would probably be neater
Andreia Gaita
@shana
the problem is that the API for cloning repositories is non-blocking and returns immediately
Steven Kirk
@grokys
ohhhhh
Andreia Gaita
@shana
so it returns before the repo is cloned
Steven Kirk
@grokys
gah
Andreia Gaita
@shana
yes I know!
hackity hack
Steven Kirk
@grokys
ok @micheleissa this looks like it's not going to be so straightfoward
Andreia Gaita
@shana
yeah you might want to have an observable on the dialog service telling you when a new UI is shown
so you know when it's safe to set that flag :/
Steven Kirk
@grokys
maybe IDialogService.ShowCreateRepositoryDialog could simply return a bool indicating whether it kicked off a create/clone?
Andreia Gaita
@shana
yeah, was thinking that too
if you do that, you should probably cache the last seen "new" repo just in case it's so fast creating it that you get the property notification of a new repo being added to the list before the dialog service returns
Steven Kirk
@grokys
hmm
Andreia Gaita
@shana
but then you won't know if you have to wait for another notificaition of a repo being added
gah
tricksies
it's a bit of a race - when is it safe to process the property notification of a repo being added to the list
Steven Kirk
@grokys
i think the problem is that the dialog kicks off the action, whereas it should just return the results of the dialog and let the client kick off the action
Andreia Gaita
@shana
yeah
you really need to control when exactly the action is started, so you know the point at which to start monitoring for results
Steven Kirk
@grokys
yeah. BAD API VS
Andreia Gaita
@shana
yeah...
Steven Kirk
@grokys
so previously, what would happen if say a create failed and then the user added a new repo themselves? would the message be shown when the user-added repo was detected?
Andreia Gaita
@shana
yeah, I don't see the flag ever being reset on failure
Steven Kirk
@grokys
actually IDialogService.ShowCloneDialog already does return the dialog result for the client to kick off the clone
Andreia Gaita
@shana
so the other one should do the same
Steven Kirk
@grokys
i will change ShowCreateRepositoryDialog
or would you like to do that @micheleissa ?
Bryan James
@BryanJames16
Hello Good Evening!
Bryan James
@BryanJames16
I downloaded Krypton 4.7 (for .NET 4.7) and compiled it. However, if I tried adding the DLLs to the toolbox (by choosing Toolbox Items) I always get an error: "The file 'C:\Users\BryanJames\Desktop\APPLICATION\DEVELOPER\LANGUAGE\C#\LibraryManagementSystem\LibraryManagementSystem\Extensions\Krypton Toolkit.dll' is not valid. I already tried dragging it to the toolbox. But it doesn't fix the problem. Any ideas?
Emamul Hasan
@emamcoder
Hi, is there any one who is using Visual Studio for Mac?
I have few question related to version control of VS for Mac
Steven Kirk
@grokys
hey @emamcoder - this is the room for the GitHub Extension for VisualStudio which doesn't work on mac, as Visual Studio for Mac is a completely different product with a different extension framework
so i'm not sure you'll get an answer here
Emamul Hasan
@emamcoder
@grokys Thanks for your response, let me see if any one can answer or if you have any suggestion to get help on the same than please let me know.
Steven Kirk
@grokys
sure
i don't think there is a gitter room for VS for Mac as it's not on GitHub afaik
Emamul Hasan
@emamcoder
Even i have posted the same in some other respective rooms and waiting for response.
Steven Kirk
@grokys
i would try to help, but I don't have a mac :(
Emamul Hasan
@emamcoder
I appreciate your willingness to help me :)
Andrew Cho
@ahcho0819
Hi, Everyone. I was wondering if I could ask a question here. I noticed that there are some buttons at the bottom of the Visual Studio IDE, which one of the button opens "Team Explorer Window". I am having hard time to find a solution how to place a button at the bottom-right corner of VS IDE or is it even possible? I know that GitHub extension for Visual Studio does it and would anyone be able to provide hints or solution, please?
Jamie Cansdale
@jcansdale
@ahcho0819 We were told that this isn't a supported extension point and politely requested to make it as unobtrusive as possible. :wink:
madskristensen's ShowTheShortcut extension does something similar, so I doing feel too bad about it. :laughing:
https://github.com/madskristensen/ShowTheShortcut/blob/master/src/StatusbarInjector.cs
Andrew Cho
@ahcho0819
@jcansdale Thank you for the information
Jamie Cansdale
@jcansdale
:thumbsup:
babula pradhan
@babula38_twitter
Visual Studio 2017 Custom Item Templates for .Net Core.Even i am trying all the steps in vs2017 but item template are not shown up. it is showing in non .net core project but not for aspnetcore project