GitLab/contributors

Room for GitLab contributors

Christos Bacharakis

@cbacharakis_gitlab

Live stream: https://www.youtube.com/watch?v=cPpt9-UoGlY

Christos Bacharakis

@cbacharakis_gitlab

Happy GitLab day, everyone! Another GitLab hackathon is in the books!

Thank you to all the 68 participants for your contributions and the 414 MRs!

Now it's time for us to review all of your work until the 15th of September. On the 19th we will announce the winners, the dates, and some changes for the next Hackathon.

You will also receive a survey next week to help gather feedback and improve the Hackathon.
Here is also the recording of the wrap up call: https://www.youtube.com/watch?v=cPpt9-UoGlY

Sameroom

@sameroom-bot

[Lee Tickett, GitLab] Who wants a super easy frontend issue to pickup? :pray:
gitlab-org/gitlab#370353

2 replies

Sameroom

@sameroom-bot

[Lee Tickett, GitLab] Easy pickings, but hoping we might entice someone new:)

Marco Zille

@zillemarco_gitlab

Yup, totally :slight_smile:
Also, if anyone needs help, please reach out :slight_smile: If I can, I'll be more than happy to help :slight_smile:

Sameroom

@sameroom-bot

[Lee Tickett, GitLab] Feel free to add a note to the issue Marco, I realise I was super breif with the issue description- you could breakdown the steps maybe? e.g. renaming the component, spec then finding references etc? +1

1 reply

Laurent Deketelaere

@aliokan

I have the following error when I run bundle exec rspec ./spec/lib/gitlab/ci/config/entry/service_spec.rb ont my local GDK on master

An error occurred while loading ./spec/lib/gitlab/ci/config/entry/service_spec.rb.
Failure/Error: include DatabaseReflection

NameError:
  uninitialized constant Feature::FlipperFeature::DatabaseReflection
# ./lib/feature.rb:9:in `<class:FlipperFeature>'
# ./lib/feature.rb:8:in `<module:Feature>'
# ./lib/feature.rb:6:in `<top (required)>'
# ./spec/support/helpers/stub_feature_flags.rb:6:in `included'
# ./spec/lib/gitlab/ci/config/entry/service_spec.rb:8:in `include'
# ./spec/lib/gitlab/ci/config/entry/service_spec.rb:8:in `block in <top (required)>'
# ./spec/lib/gitlab/ci/config/entry/service_spec.rb:7:in `<top (required)>'
Run options: include {:focus=>true}

All examples were filtered out; ignoring {:focus=>true}
No examples found.

What am I missing?

Dannyel Cardoso da Fonseca

@dannyelcf_gitlab

I don't know if it will help but try bin/rspec ./spec/lib/gitlab/ci/config/entry/service_spec.rb

this uses the rspec from gdk source folder

Laurent Deketelaere

@aliokan

I tried it too and get the same error. Thank you!

Marco Zille

@zillemarco_gitlab

can you try to run a gdk doctor to see if there's something broken? Otherwise I'd try to either run bundle install or gdk update to make sure everything is updated :slight_smile:

1 reply

Laurent Deketelaere

@aliokan

I guess I miss something, I have the same error with a fresh gdk install and on gitpod. Do I need to setup something before running bin/rspec ./spec/lib/gitlab/ci/config/entry/service_spec.rb ?

2 replies

Sameroom

@sameroom-bot

[Lee Tickett, GitLab] I get the same error- let me take a look

Sameroom

@sameroom-bot

[Lee Tickett, GitLab] I haven't been able to figure it out, but I have asked for help and will let you know if/when +1

Siddharth Asthana

@edith007_gitlab

I think this issue is causing the problem https://gitlab.com/gitlab-org/gitlab/-/issues/369268#note_1058167053

Sameroom

@sameroom-bot

[Lee Tickett, GitLab] Oh really? I thought it was more of a resolution thing... where we're looking for Feature::FlipperFeature::DatabaseReflection instead of ::DatabaseReflection sort of thing

[Lee Tickett, GitLab] Oh I might have sussed it

[Lee Tickett, GitLab] Ok, so I fixed it by changing require 'fast_spec_helper' to require 'spec_helper'
But looking for a potential better fixs

2 replies

Laurent Deketelaere

@aliokan

I notice the same error with bin/rspec ./spec/lib/gitlab/ci/config/entry/image_spec.rb, but everything green when I run bin/rspec ./spec/lib/gitlab/ci/config/entry/

Laurent Deketelaere

@aliokan

both of them require 'support/helpers/stub_feature_flags' with require 'fast_spec_helper'

I also see that spec/lib/gitlab/ci/config/entry/rules/rule_spec.rb uses require 'fast_spec_helper' and require 'support/helpers/stub_feature_flags' but StubFeatureFlags do not seems used...

Dannyel Cardoso da Fonseca

@dannyelcf_gitlab

Hello everyone! Have anyone faced currently a problem in your MR pipeline in the rubocop job?
My MR takes so long on this job (rubocop) and don't finish normally.

Laurent Deketelaere

@aliokan

I have the same here: https://gitlab.com/ali_o_kan/gitlab/-/jobs/2845921764

Dannyel Cardoso da Fonseca

@dannyelcf_gitlab

One hour ago there was a merge into master that fix these errors

spec/lib/gitlab/audit/target_spec.rb: Rspec/VerifiedDoubles has the wrong namespace - should be RSpec
spec/models/concerns/database_event_tracking_spec.rb: Rspec/LeakyConstantDeclaration has the wrong namespace - should be RSpec
spec/models/concerns/database_event_tracking_spec.rb: Rspec/ExpectGitlabTracking has the wrong namespace - should be RSpec

gitlab-org/gitlab@990e693

But it wasn't enough to solve the long time to run :(

Dannyel Cardoso da Fonseca

@dannyelcf_gitlab

I think I have a clue... As community, our runner for this job is a shared runner (green.shared-gitlab-org.runners-manager.gitlab.com) and maybe the server is overloaded for now. I have already run successfully the complete pipeline in the morning from my timezone. I will retry tomorrow morning...

Laurent Deketelaere

@aliokan

There is a good chance for that, we will see tomorrow ;)

Sameroom

@sameroom-bot

[Lee Tickett, GitLab] :ok_hand:

[Lee Tickett, GitLab] I would just callout in the MR why you made that change
Feel free to @ mention me
Thank you for another contribution +1

Laurent Deketelaere

@aliokan

Any particular reason to not allow gitbot to add label backend or frontend ?

In documentation I see https://about.gitlab.com/handbook/engineering/quality/triage-operations/#reactive-label-command

A new MR note that start with @gitlab-bot label ~"label-name" where label-name matches group::, type:: or is ~"workflow::in dev" or ~"workflow::ready for review"

I want to add backend in this MR to help gitlab-bot to find correct reviewer: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/95175#note_1059848183

zillemarco

@zeb994:matrix.org

[m]

Good point @aliokan 🙂 Right now only a subset of labels can be set with the help of gitlab-bot, and as you pointed out frontend and backend are not included 🤔

WDYT about opening an issue to ask to allow them? 🙂

https://gitlab.com/gitlab-org/quality/triage-ops/-/issues/?sort=popularity&state=opened&first_page_size=100

1 reply

Sameroom

@sameroom-bot

[Nick Veenhof, GitLab] I'd be open to allowing that - but it probably is a bigger discussion what other function domain labels we should allow then

zillemarco

@zeb994:matrix.org

[m]

Yup 🙂 By opening an issue we could start the discussion 🙂 For example, now that danger reports when the subtype label us missing, should we allow to also set subtype labels?

Laurent Deketelaere

@aliokan

The issue: gitlab-org/quality/triage-ops#1086 Feel free to comment :)

Sameroom

@sameroom-bot

[Nick Veenhof, GitLab] Ah, the subtype thing, you should totally be able to do that yes :)

0xari

@0xari:matrix.org

[m]

hi! I am a first time contributor, how can I get started? I would love to contribute code and docs. I am a newbie.

1 reply

0xari

@0xari:matrix.org

[m]

thank you so much!

1 reply

Christos Bacharakis

@cbacharakis_gitlab

Hello friends! This Thursday at 1:30 UTC we are holding a Release Stage office hour call! See you then! https://www.meetup.com/gitlab-virtual-meetups/events/287756492/

Sameroom

@sameroom-bot

[Lee Tickett, GitLab] Hoping to work on gitlab-org/gitlab!88243 during community pair programming around 11am BST. Feel free to join us https://www.twitch.tv/gitlabcommunitycoders and discord https://discord.com/channels/778180511088640070/998578723416711249

Dannyel Cardoso da Fonseca

@dannyelcf_gitlab

Hello everyone! Anyone knows who closes an issue and when can it be done? I have 3 issues that have its linked MRs merged and I don't know if it is me who should close them or if this should be done by the creator (that is not me). Any advice is welcome.

2 replies

Sameroom

@sameroom-bot

[Nick Veenhof, GitLab] Can you link the issues here? We can take a look together?

Dannyel Cardoso da Fonseca

@dannyelcf_gitlab

Here you are @nick_vh.gitlab_gitlab :
gitlab-org/gitlab#369555
gitlab-org/gitlab#369554
gitlab-org/gitlab#369469

Sameroom

@sameroom-bot

[Brian Williams, GitLab] Typically, if there is a user-facing change then we want to test it in production before closing. If someone from the team was active on the issue then you can ping them and ask them to do verificaiton.

Dannyel Cardoso da Fonseca

@dannyelcf_gitlab

Thanks a million Brian

Anshul Riyal

@anshulriyal_gitlab

Did anyone received mail for july MR swag?

zillemarco

@zeb994:matrix.org

[m]

@anshulriyal_gitlab: i Guess you’re talking about the backpack right? 🙂 Christos pointed me to the backpack initiative page where the is a link to the form to request the backpack in case you haven’t been contacted 🙂

This is the page: https://about.gitlab.com/community/contribute/development/backpacking/ 🙂

1 reply

zillemarco

@zeb994:matrix.org

[m]

You’re welcome 😁

Where communities thrive

People

Repo info

Activity