Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Lee Tickett
    @leetickett_gitlab
    oh magic- think we're back in business
    Joel Grimberg
    @joelgrimberg_gitlab
    my local yarn test passes all the jest tests, but fails (en exits) on the first karma test with this error:
    Uncaught Error: JSONFixture could not be loaded: /fixtures/merge_request_diffs/with_commit.json (status: parsererror, message: Unexpected end of JSON input). did I forget something to load?
    KonstantinKudelko
    @KonstantinKudelko_gitlab

    Guys, I have a question about the Gitlab EE.

    Maybe someone can help me? I wanna start with https://gitlab.com/gitlab-org/gitlab-ce/issues/65629#note_203585136.

    But approvers func available only in Gitlab EE. I did set up the gdk for gitlab EE: https://gitlab.com/gitlab-org/gitlab-development-kit/blob/master/doc/set-up-gdk.md#gitlab-enterprise-edition.

    But I don't see the approvers section in MR creation, maybe I doing something wrong?
    Also, I need to do changes in https://gitlab.com/gitlab-org/gitlab-ee.git? Or how I should apply changes to the main repo of Gitlab EE?

    Thx a lot!

    Lee Tickett
    @leetickett_gitlab
    has anyone seen an issue with GDK where you receive a lot of routing errors (404)?
    after refreshing a few times it works
    but starts to get really annoying
    KonstantinKudelko
    @KonstantinKudelko_gitlab

    @rpaik_gitlab I have a question in issue: https://gitlab.com/gitlab-org/gitlab-ce/issues/65629#note_203585136

    How long I should wait answer normaly?)

    Lee Tickett
    @leetickett_gitlab
    @KonstantinKudelko_gitlab have you read https://docs.gitlab.com/ee/user/project/merge_requests/merge_request_approvals.html ? have you configured merge request approvals?
    KonstantinKudelko
    @KonstantinKudelko_gitlab

    Niiice, I asked about that there, @leetickett_gitlab you save me)

    Will dive into it)

    @leetickett_gitlab maybe do you know how I can set up omnibus to run console like this:

    gitlab-rails console

    Lee Tickett
    @leetickett_gitlab
    i think sudo gitlab-rails console should work
    KonstantinKudelko
    @KonstantinKudelko_gitlab

    nope =(

    sudo: gitlab-rails: command not found

    I just installed gdk + ce and ee like this: https://gitlab.com/gitlab-org/gitlab-development-kit/blob/master/doc/set-up-gdk.md#gitlab-enterprise-edition

    Should I do more to enable the console?

    Lee Tickett
    @leetickett_gitlab
    ah- try just; rails console
    KonstantinKudelko
    @KonstantinKudelko_gitlab
    Traceback (most recent call last):
    4: from /Users/konstantinkudelko/.rvm/gems/ruby-2.6.3/bin/ruby_executable_hooks:24:in `<main>'
    3: from /Users/konstantinkudelko/.rvm/gems/ruby-2.6.3/bin/ruby_executable_hooks:24:in `eval'
    2: from /Users/konstantinkudelko/.rvm/gems/ruby-2.6.3/bin/rails:23:in `<main>'
    1: from /Users/konstantinkudelko/.rvm/rubies/ruby-2.6.3/lib/ruby/site_ruby/2.6.0/rubygems.rb:303:in `activate_bin_path'
/Users/konstantinkudelko/.rvm/rubies/ruby-2.6.3/lib/ruby/site_ruby/2.6.0/rubygems.rb:284:in `find_spec_for_exe': can't find gem railties (>= 0.a) with executable rails (Gem::GemNotFoundException)
    Seems that setup environment will get more time than close the task))))
    Lee Tickett
    @leetickett_gitlab
    yeah i can vouch for that unfortunately
    i think GDK needs some work
    if it helps, I have ended up using vagrant- it seems the simplest/quickest to setup (i'm on windows- it may not be the case if you use a different OS
    KonstantinKudelko
    @KonstantinKudelko_gitlab
    =(
    Lee Tickett
    @leetickett_gitlab
    definitely worth raising an issue against the GDK project- i think the team are keen to hear about our experiences and improve things to make it easier for new users to contribute
    KonstantinKudelko
    @KonstantinKudelko_gitlab

    Seems like these docs for the users who installed gitlab https://docs.gitlab.com/ee/user/project/merge_requests/merge_request_approvals.html

    Not for contributers)

    Lee Tickett
    @leetickett_gitlab
    yes- but you may need to the do the same steps to enable merge request approvals in your GDK environment ?
    they may already be enabled though i guess
    KonstantinKudelko
    @KonstantinKudelko_gitlab

    Maybe)

    Mmmm, need to find how we can run the console inside of the GDK environment))

    Lee Tickett
    @leetickett_gitlab
    it shouldn't be crashing like it is :/
    KonstantinKudelko
    @KonstantinKudelko_gitlab
    yes =)
    Lee Tickett
    @leetickett_gitlab
    have you run; gdk run ? I'm not sure if gdk needs to be running for you to access the console
    KonstantinKudelko
    @KonstantinKudelko_gitlab
    Nope I didn't run gdk, seems that we don't need to run it for invoke the console?
    Lee Tickett
    @leetickett_gitlab
    I just checked, and yes you need gdk running in order to access the console (Y)
    Jonathan Love
    @jondlove_gitlab
    hmm okay: I have an MR with multiple suggestions, I accepted the first one but can't accept the others as I get a "File has now changed" error - what's the standard procedure here? The merge request documentation is frustratingly light
    Lee Tickett
    @leetickett_gitlab
    I suspect you'll just need to manually implement the other suggestions (if they are in the same file(s)
    if there isn't already an issue you could raise one for that functionality to be examined to see if it can be improved to allow multiple suggestions to be implemented
    Jonathan Love
    @jondlove_gitlab
    It turns out I need to wait 5(?)ish minutes between applying changes. No idea why, but it works if I wait a bit
    very strange
    Ray Paik
    @rpaik_gitlab
    @KonstantinKudelko_gitlab sorry I was away for a while, it looks like people got back to you on the issue :point_up_2:? (and THANKS @leetickett_gitlab for helping out with questions :rocket: )
    @jondlove_gitlab I did see you having issues applying changes on the MR for the docs. Were you able to apply all the changes after a few delays? If you can post your MR here again, I can double check. Maybe it's something that needs to be documented in the docs (we can ask the docs team on the MR :smile: )
    Ray Paik
    @rpaik_gitlab
    @jondlove_gitlab I believe it's this MR? gitlab-org/gitlab-ce!31556
    KonstantinKudelko
    @KonstantinKudelko_gitlab
    @rpaik_gitlab thx, I will try to run now gdk and then run the rails console)
    KonstantinKudelko
    @KonstantinKudelko_gitlab

    @leetickett_gitlab I ran the gdk-ee and then do a sudo rails console but it's don't work:

    can't find gem railties (>= 0.a) with executable rails (Gem::GemNotFoundException)

    Lee Tickett
    @leetickett_gitlab
    have you run gdk run
    KonstantinKudelko
    @KonstantinKudelko_gitlab
    Yeah, I did:
    • gdk run
    • sudo rails console
    I open to call, if we can do it)))
    KonstantinKudelko
    @KonstantinKudelko_gitlab

    @leetickett_gitlab hey mate!

    Can I ask you about the flow how do you push the changes and create the MR?

    1) I installed the gdk-ce
    2) Forked Gitlab CE repo
    3) And set up upstream for forked repo: https://gitlab.com/gitlab-org/gitlab-development-kit/blob/master/doc/set-up-gdk.md#option-1-develop-in-a-fork

    Should I do the changes in forked repo and then create an MR in the main repo?
    Thx

    George Tsiolis
    @gtsiolis

    @KonstantinKudelko_gitlab yes, you can push your changes to a branch on the forked repository and then create a merge request against the master branch on the upstream repository.

    Maybe this is something that could be mentioned explicitly in https://about.gitlab.com/community/contribute/development/

    KonstantinKudelko
    @KonstantinKudelko_gitlab

    Yeah, I did it)

    My first MR:
    gitlab-org/gitlab-ce!31935

    KonstantinKudelko
    @KonstantinKudelko_gitlab

    @gtsiolis

    Maybe you give me a tip on how I can check my changes locally?

    I ran the gdk and did changes in the forked repo that I bound with gdk, I did some changes in code but changes don't appear)

    George Tsiolis
    @gtsiolis

    @KonstantinKudelko_gitlab I would check locally the pages that included the classes that you changed like project labels (/:project/-/labels) and group labels (/groups/:group/-/labels).

    Switching branches and taking screenshots could help identify any subtle changes. There is an experimental screen grabber for visual diff testing but this could add some overhead to this at the moment.

    KonstantinKudelko
    @KonstantinKudelko_gitlab

    Seems that I found the full tutorial around contribution flow:

    https://youtu.be/gxn-0KSfNaU

    Maybe it will be helpful for others)

    Lee Tickett
    @leetickett_gitlab
    @KonstantinKudelko_gitlab thanks- typically I found that video after I had been learning for a few months and mostly figured it out. I do think it would be worth the documentation being improved to perhaps cover some of the bits discussed in the video. I had trouble getting to grips with the upstream vs origin and a number of other bits which are quite challenging when new to the project
    KonstantinKudelko
    @KonstantinKudelko_gitlab

    Yes)))

    100%