yarn testpasses all the jest tests, but fails (en exits) on the first karma test with this error:
Guys, I have a question about the Gitlab EE.
Maybe someone can help me? I wanna start with https://gitlab.com/gitlab-org/gitlab-ce/issues/65629#note_203585136.
approvers func available only in Gitlab EE. I did set up the gdk for gitlab EE: https://gitlab.com/gitlab-org/gitlab-development-kit/blob/master/doc/set-up-gdk.md#gitlab-enterprise-edition.
But I don't see the
approvers section in MR creation, maybe I doing something wrong?
Also, I need to do changes in https://gitlab.com/gitlab-org/gitlab-ee.git? Or how I should apply changes to the main repo of Gitlab EE?
Thx a lot!
@rpaik_gitlab I have a question in issue: https://gitlab.com/gitlab-org/gitlab-ce/issues/65629#note_203585136
How long I should wait answer normaly?)
@leetickett_gitlab maybe do you know how I can set up
omnibus to run console like this:
sudo: gitlab-rails: command not found
I just installed gdk + ce and ee like this: https://gitlab.com/gitlab-org/gitlab-development-kit/blob/master/doc/set-up-gdk.md#gitlab-enterprise-edition
Should I do more to enable the console?
Traceback (most recent call last): 4: from /Users/konstantinkudelko/.rvm/gems/ruby-2.6.3/bin/ruby_executable_hooks:24:in `<main>' 3: from /Users/konstantinkudelko/.rvm/gems/ruby-2.6.3/bin/ruby_executable_hooks:24:in `eval' 2: from /Users/konstantinkudelko/.rvm/gems/ruby-2.6.3/bin/rails:23:in `<main>' 1: from /Users/konstantinkudelko/.rvm/rubies/ruby-2.6.3/lib/ruby/site_ruby/2.6.0/rubygems.rb:303:in `activate_bin_path' /Users/konstantinkudelko/.rvm/rubies/ruby-2.6.3/lib/ruby/site_ruby/2.6.0/rubygems.rb:284:in `find_spec_for_exe': can't find gem railties (>= 0.a) with executable rails (Gem::GemNotFoundException)
Seems like these docs for the users who installed gitlab https://docs.gitlab.com/ee/user/project/merge_requests/merge_request_approvals.html
Not for contributers)
@leetickett_gitlab hey mate!
Can I ask you about the flow how do you push the changes and create the MR?
1) I installed the gdk-ce
2) Forked Gitlab CE repo
3) And set up upstream for forked repo: https://gitlab.com/gitlab-org/gitlab-development-kit/blob/master/doc/set-up-gdk.md#option-1-develop-in-a-fork
Should I do the changes in forked repo and then create an MR in the main repo?
@KonstantinKudelko_gitlab yes, you can push your changes to a branch on the forked repository and then create a merge request against the master branch on the upstream repository.
Maybe this is something that could be mentioned explicitly in https://about.gitlab.com/community/contribute/development/
@KonstantinKudelko_gitlab I would check locally the pages that included the classes that you changed like project labels (
/:project/-/labels) and group labels (
Switching branches and taking screenshots could help identify any subtle changes. There is an experimental screen grabber for visual diff testing but this could add some overhead to this at the moment.
Seems that I found the full tutorial around contribution flow:
Maybe it will be helpful for others)