by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Jun 05 2018 23:13
    @MadLittleMods banned @LWSS
Eric Eastwood
@MadLittleMods

I assume you are looking at server/handlers/root.js#L43-58

Does var requested = req.headers['accept-language'] come in as zh-tw? You could use the following code. I am not sure if requestedLangand requestedRegion are the proper terms for this

var requested = req.headers['accept-language'];
const [requestedLang, requestedRegion] = requested.split('-')

->

requestedLang = 'zh'
requestedRegion = 'tw'
Johnny Yeng
@a2902793_gitlab
Might as well just explain this in details in a mr, kinda flooding this chatroom with my terrible explanation
it dows come in zh-tw
but additional parsing was done
Eric Eastwood
@MadLittleMods
@a2902793_gitlab You can parse it however you want. And we don't need to keep modifying the request variable in place over and over. It would be better to name those as separate variables for each step
Johnny Yeng
@a2902793_gitlab
hold on, I figure I might as well write a simple explanation of what I'm tryin to say here.
Eric Eastwood
@MadLittleMods
@a2902793_gitlab I'm going to go shower, will look when I'm back :+1:
Eric Eastwood
@MadLittleMods
@a2902793_gitlab Here if you want to discuss something more
If this looks good to you, I'll send my MR
Eric Eastwood
@MadLittleMods
@a2902793_gitlab Please send a MR :slight_smile: we can discuss it there
Johnny Yeng
@a2902793_gitlab
@MadLittleMods my pipeline keeps on failing on "ValidationError: Path username is required."... can you kindly point me out what the problem may be?
Eric Eastwood
@MadLittleMods

@a2902793_gitlab That's fine. If you want the pipeline passing/green, see https://gitlab.com/gitlab-org/gitter/webapp#getting-the-gitlab-ci-tests-green-white_check_mark

You can still create the merge request against the main webapp project though

@a2902793_gitlab We want to improve this experience in the future, gitlab-org/gitter/webapp#1974
Johnny Yeng
@a2902793_gitlab
Is one topic per MR preferred or mashing different kinds in one?
Eric Eastwood
@MadLittleMods
@a2902793_gitlab Better to just create a separate MR so we don't have some changes blocked by others while it's being reviewed. If it's a small separate change, we can approve and merge it right away :rocket:
hubitor
@hubitor
Hi. I wanted to search in a chat room how can I change a password. After I entered "password" in the search box on the left, a user "Change your password" appeared in the results. I must have clicked on it accidentally and now it appears in ALL CONVERSATIONS and PEOPLE. How can I remove this "user" ?
Tomas
@viktomas
@hubitor you probably started chat with a user with username "password" You can just open the chat room and in the room settings in top right corner select "hide this room"
hubitor
@hubitor
@viktomas thanks! It's gone.
Franklin Yu
@FranklinYu

Hi, is there any plan to add a web app manifest? This way it can share a lot of memory with other browser processes.

I’d love to contribute, but I have no idea how to add any static asset to https://gitlab.com/gitlab-org/gitter/webapp. The asset processing pipeline is complicated…

Franklin Yu
@FranklinYu
Another feature request: add an icon in conversation list showing the notification setting. Something like https://fontawesome.com/icons/bell-slash or https://fontawesome.com/icons/volume-mute
4 replies
Tomas
@viktomas
@FranklinYu We are planning on implementing PWA in Gitter. More info: gitlab-org/gitter/webapp/-#1992
4 replies
ret394
@ret394
"implementing PWA in Gitter" ? another bad idea.
Franklin Yu
@FranklinYu
@ret394 Elaborate?
ret394
@ret394
what's the need?
4 replies
also, can i get commit rights? got to fix stuff fast. will consider gitlab if I can get to work.
ret394
@ret394
contact me on https://github.com/ret394/jubilant-broccoli/issues to notify me of the change. I might forget. revoking access to gitter soon.
Eric Eastwood
@MadLittleMods
@ret394 You can fork the project and send merge requests for any changes
ret394
@ret394
from Github? cool but how?
Eric Eastwood
@MadLittleMods
@ret394 On GitLab, you can fork https://gitlab.com/gitlab-org/gitter/webapp and work from there
Franklin Yu
@FranklinYu
@ret394 GitLab should be easy to use if you already know GitHub. Most concepts are the same. (True for most Git-hosting services.)
ret394
@ret394
@FranklinYu let me know if I can get commit access, that would make it simpler. Otherwise, forget about it, it's always a pain forking it
Franklin Yu
@FranklinYu
In case nobody did this, great thanks for implementation of threads! It’s more useful for large rooms such as the one for Chocolatey.
Eric Eastwood
@MadLittleMods
@FranklinYu Appreciate the praise! @viktomas has been the one behind building threaded conversations 🎉🎉🎉
ret394
@ret394

https://update.gitter.im/win/latest must install without admin access.

https://developer.mozilla.org/en-US/docs/Web/Manifest This is an experimental technology
Status Working Draft. "Implementors need to be aware that this specification is not stable."
look at the memory usage first.
Franklin Yu
@FranklinYu
Again, memory usage won’t be worse than current situation. Possibly better.
ret394
@ret394

In case nobody did this, great thanks for implementation of threads! It’s more useful for large rooms such as the one for Chocolatey.

totally agree, threads does make a significant difference. would have just upvoted your comment if possible.

ret394
@ret394

notifications for updated comments would also help users. And there was a query about similar feature for bridges from @amosbird_gitlab

Hello, is there any reason why gitter doesn't post events when message gets updated or deleted?
this makes bridging a bit of pain

Eric Eastwood
@MadLittleMods
@ret394 Updates and deletions are supported. I responded to their message in the room they posted, :point_up: April 10, 2020 12:21 PM
Franklin Yu
@FranklinYu
Is there any note (like release note or documentation) about the new thread feature? I would like to show them to folks in other rooms.
Franklin Yu
@FranklinYu
Cool
Franklin Yu
@FranklinYu
I want to help gitlab-org/gitter/webapp/-#1992 by adding manifest. Any guideline about asset processing? The public folder doesn’t seem to be exposed as-is.
Eric Eastwood
@MadLittleMods
@FranklinYu I would look into how the images and fonts are processed. Or the service worker sw.js and sw-static.js stuff
ret394
@ret394
@MadLittleMods Thanks for that.