Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Jun 05 2018 23:13
    @MadLittleMods banned @LWSS
Eric Eastwood
@MadLittleMods
@ghassanmas I've just linked some relevant code in the issue https://gitlab.com/gitlab-org/gitter/webapp/issues/2187#relevant-code
Ghassan Maslamani
@ghassanmas
Thank you @MadLittleMods
Peter Hull
@pedro-w
:point_up: June 25, 2019 8:30 AM I think I have enabled the Vue left menu and as far as I can see it is working well.
However I've noticed the main chat pane doesn't seem to start in a sensible place, sometimes it shows only read messages with unread ones still below and off screen.
Maybe because I use > 1 computer and not all of the have the 'Next' toggled?
Eric Eastwood
@MadLittleMods
@pedro-w When you switch rooms, it doesn't remember your position or jump to last unread. You can track gitlab-org/gitter/webapp#1504 and gitlab-org/gitter/webapp#937
Peter Hull
@pedro-w
@MadLittleMods did it never do that? It just seemed that I only noticed after I switched to 'Next'
Eric Eastwood
@MadLittleMods
@pedro-w Never did that. If there are enough messages to be offscreen, there is a unread badge in the top-right to jump to the oldest unread though,
Ghassan Maslamani
@ghassanmas
@MadLittleMods I am trying to push a fix for gitlab-org/gitter/webapp#2187
but I got this message You are not allowed to push code to this project.
Tomas
@viktomas
Hey @ghassanmas, you'll have to fork the webapp project. Then you can push the changes to your version of webapp and create MR from there :slight_smile:
Ghassan Maslamani
@ghassanmas
@viktomas so is that how I am suppose to do it gitlab-org/gitter/webapp!1474 ?
Tomas
@viktomas
Screenshot 2019-07-10 at 07.55.01.png Thank you @ghassanmas for the 1st contribution. Let's continue the discussion on the MR/issue :slight_smile:
Ghassan Maslamani
@ghassanmas
No worries @viktomas I will be glad when my commit get merged :), thank you for your supprot
Ghassan Maslamani
@ghassanmas
I got this error when trying to run my local app npm start: TypeError: OAuth2Strategy requires a clientID option
I have all the secrets for the app hence I have run the app successfully before
the error comes from the passport pacakge
Nevermind I had to export it source .env
Tomas
@viktomas
@ghassanmas I'm using https://direnv.net/ for all my projects and it's a good experience. I can recommend it.
Ghassan Maslamani
@ghassanmas
looks really useful @viktomas thank you!
Franklin Yu
@FranklinYu
Is there any way to search in a specific room? Current search function searches all messages.
Eric Eastwood
@MadLittleMods
@FranklinYu The search in the left-menu searches for rooms across Gitter and messages in the current room
Eric Eastwood
@MadLittleMods

As a little update, Gitter 20.0.0 rolled out to production. This marks our complete transition to the new Vue.js left-menu and removes the iframe barrier between the app and chat area. This allows us to work from a single codebase for desktop/mobile browsers with a modern JavaScript framework and removes the technical debt that was trapped in those areas :tada:

We're currently working on threaded conversations which are available in basic form now via the threaded-conversations feature toggle, https://next.gitter.im/. Lots more to tackle in this area though which you can track in this epic, https://gitlab.com/groups/gitlab-org/-/epics/360

:point_up: August 20, 2019 12:10 PM

Philip Durbin
@pdurbin
Nice, thanks for the update.
Ben Jackson
@puremourning
as mentioned in the other channel, i have a change to include the mobile chat js in the mobile assets build in webapp. This seems to work both in sim and on-device, thought the iOS “send message” function (which tries first to use window._sendMessage doesn’t seem to work and falls back to the native send message). This makes the app usable, but seems there’s a subtle bug. The font in the text input is also broken. i’ll take a look
Screenshot 2019-09-29 at 18.43.13.png
Tomas
@viktomas
@puremourning afaik we haven't touched the fonts and their placement in CDN recently, can you see whether there is some failed font download request during the app build?
(btw. amazing effort on making the iOS app running again :tada: )
Ben Jackson
@puremourning
The text input is a native iOS. The text input uses some text input cocoapod from Slack that is mothballed now. It basically works. Just need to work out why iOS is rendering with Times. Also there is some layout issue I need to track down.
Eric Eastwood
@MadLittleMods

@puremourning Mind submitting a merge request with your work so far (both webapp and gitter-ios-app)? I'm curious just to take a look, https://gitlab.com/gitlab-org/gitter/gitter-ios-app/merge_requests

We can also track the knowledge around the current bugs you are getting around in that MR

It's really exciting hearing the progress you've made so far :dancer:
Ben Jackson
@puremourning
do you prefer merge requests against master, or develop branch ?
Eric Eastwood
@MadLittleMods
Ben Jackson
@puremourning
Ben Jackson
@puremourning
oh i didn’t use git-flow, is that a problem ? i just pushed a branch and opened a MR ...
Eric Eastwood
@MadLittleMods
@puremourning Those MRs are perfect! git-flow is just a branching strategy. So your feature branch merging into develop is just right :+1:
Ben Jackson
@puremourning
:blush:
i maintaint a couple of popular oss projects myself, and i may have run the odd software project before …. :)
Ben Jackson
@puremourning
@MadLittleMods i don’t suppose you have a 1024x1024 app icon for Gitter ?
i’m going through and STFU as many xcode warnings as possible
Eric Eastwood
@MadLittleMods
app_icon.jpg
@puremourning ^ It's just from the metadata fetch that fastlane can do, gitlab-org/gitter/gitter-ios-app!3
Ben Jackson
@puremourning
if you need in-cloud mac builds for the OSS stuff, Azure pipelines is great
we’ve used Travis CI (too slow/overloaded), Circle CI (very good, but limited concurrency), Azure has been great
i know, it’s probably hard to belive, but MS provide the best cloud Mac CI
:shruggie:
Eric Eastwood
@MadLittleMods

@puremourning Neat! I was only really aware of Mac Stadium from some discussion

(comment welcome on that thread in the issue)

Ben Jackson
@puremourning
oh good. upgrading to xcode 11.1 seems to have fixed a number of the issues with the app
the good news therefore is that i wasn’t going mad (being unable to work out what was wrong)