Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Jun 05 2018 23:13
    @MadLittleMods banned @LWSS
Eric Eastwood
@MadLittleMods

@puremourning I'm downloading the latest Xcode so I can try it out. I'll go through some of your commits. Splitting it up sounds a bit painful and your commits seem pretty nice

Thanks for all the effort getting this in shape!!

Ben Jackson
@puremourning
No worries :)
Ben Jackson
@puremourning
In case you didn’t see I found the issue with the TestFlight build - it’s missing the production secrets
Ankur Mittal
@ankurmittal092_gitlab

Hi .. I'm trying to set up gitter project in my mac and I'm getting the following error on npm start

{ message: 'OAuthStrategy requires a consumerKey option',
     stack:
      'TypeError: OAuthStrategy requires a consumerKey option\n    at Strategy.OAuthStrategy (/Users/ankurmittal/Desktop/Self/webapp/node_modules/passport-oauth1/lib/strategy.js:83:37)\n    at new Strategy (/Users/ankurmittal/Desktop/Self/webapp/node_modules/passport-twitter/lib/strategy.js:53:17)\n    at Object.<anonymous> (/Users/ankurmittal/Desktop/Self/webapp/server/web/strategies/twitter.js:47:23)\n    at Module._compile (internal/modules/cjs/loader.js:778:30)\n    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)\n    at Module.load (internal/modules/cjs/loader.js:653:32)\n    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)\n    at Function.Module._load (internal/modules/cjs/loader.js:585:3)\n    at Module.require (internal/modules/cjs/loader.js:692:17)\n    at require (internal/modules/cjs/helpers.js:25:18)\n    at Object.<anonymous> (/Users/ankurmittal/Desktop/Self/webapp/server/web/passport.js:12:23)\n    at Module._compile (internal/modules/cjs/loader.js:778:30)\n    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)\n    at Module.load (internal/modules/cjs/loader.js:653:32)\n    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)\n    at Function.Module._load (internal/modules/cjs/loader.js:585:3)\n    at Module.require (internal/modules/cjs/loader.js:692:17)\n    at require (internal/modules/cjs/helpers.js:25:18)\n    at Object.<anonymous> (/Users/ankurmittal/Desktop/Self/webapp/server/web.js:24:1)\n    at Module._compile (internal/modules/cjs/loader.js:778:30)\n    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)\n    at Module.load (internal/modules/cjs/loader.js:653:32)\n    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)\n    at Function.Module._load (internal/modules/cjs/loader.js:585:3)\n    at Module.require (internal/modules/cjs/loader.js:692:17)\n    at require (internal/modules/cjs/helpers.js:25:18)\n    at Object.<anonymous> (/Users/ankurmittal/Desktop/Self/webapp/web.js:7:1)\n    at Module._compile (internal/modules/cjs/loader.js:778:30)\n    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)\n    at Module.load (internal/modules/cjs/loader.js:653:32)\n    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)\n    at Function.Module._load (internal/modules/cjs/loader.js:585:3)\n    at Function.Module.runMain (internal/modules/cjs/loader.js:831:12)\n    at startup (internal/bootstrap/node.js:283:19)\n    at bootstrapNodeJSCore (internal/bootstrap/node.js:622:3)',
     name: 'TypeError' },
  meta:
   { errorString: 'TypeError: OAuthStrategy requires a consumerKey option',
     type: 'uncaught' },

Can someone help me with this?

Eric Eastwood
@MadLittleMods

@ankurmittal092_gitlab You just need to add the secrets to your environment, see https://gitlab.com/gitlab-org/gitter/webapp#mac

Need to run that source .env for every new console/terminal

Ankur Mittal
@ankurmittal092_gitlab
@MadLittleMods I did try that.. I skipped twitter auth.. I'm guessing every secret variable is required. Let me try and set up twitter.. will get back to you if the problem persists
Eric Eastwood
@MadLittleMods
@ankurmittal092_gitlab That is exactly the problem :+1:. You can track this issue for making it optional in the future, gitlab-org/gitter/webapp#1973
Ankur Mittal
@ankurmittal092_gitlab
Thanks.. @MadLittleMods
Ben Jackson
@puremourning
Latest iOS TestFlight build works!
Finally :)
Eric Eastwood
@MadLittleMods
@puremourning :tada: Glad to hear it works! I'm still on vacation so I'll follow up in the issue in a few days :muscle:
Richard Littauer
@RichardLitt
:wave: Is there a way to mark a room as read using a keyboard shortcut?
Tomas
@viktomas
@RichardLitt there is a command you can type into the message input /mark-all-read
Richard Littauer
@RichardLitt
Thank you! Is there somewhere I should have looked for that information, short of googling > trello > github > gitlab > joining here > asking
Tomas
@viktomas
No worries. I was looking for the info in Gitter docs: https://gitlab.com/gitlab-org/gitter/webapp/blob/develop/docs/messages.md but didn't find it there. If you'd feel like creating MR, that would be appreciated :) maybe adding it to the commands section
Eric Eastwood
@MadLittleMods
@RichardLitt So we can improve you more easily finding the main docs. What did you first google? (can you look in your history)
Richard Littauer
@RichardLitt
"gitter shortcut mark as read"
Eric Eastwood
@MadLittleMods
Thanks @RichardLitt :-)
Philip Durbin
@pdurbin
@MadLittleMods I just wanted to let you know that I'm feeling bad about complaining a bit in here that Gitter doesn't support self-hosting. I just launched a little webapp with some friend and it doesn't support self-hosting either. Maybe someday. Sometimes you just want to get the thing into production quick. :)
Eric Eastwood
@MadLittleMods
@pdurbin Lots of different areas to focus on :)
Philip Durbin
@pdurbin
Exactly
Johnny Yeng
@a2902793_gitlab
hi guys, first time participating in open source projects as well as coding javascript, so excuse me if I ask any silly questions or any noob behaviors.
I've been fixing a little bug about properly showing the "Translation kindly done by..." text.
So I need to add a check if the locale obtained from var locale = req.i18n.getLocale(); contains "-"
Do you guys prefer using indexOf or includes?
Eric Eastwood
@MadLittleMods

Hey @a2902793_gitlab Feel free to submit a work in progress(WIP) merge requests and add some comments on the diff with your questions/comments

For my own reference, it looks like you are talking about https://gitlab.com/gitlab-org/gitter/gitter-translations/-/blob/26095051123b6175e0391d80d568e5d4cb95ac68/homepage/zh-tw.js#L2

@a2902793_gitlab Either is fine. What really matters is what makes the code more readable. If it's an obvious perf concern we can look at that individual situation
Johnny Yeng
@a2902793_gitlab
The reason being
back when I hadn't provided zh-tw which contains a "-"
all went fine because even if the user did use an accepted language such as es-419, it will fall back to es
req.i18n.getLocale(); returns es
and after requested = requested.split('-')[0];
requested is also es
but after I added zh-tw, webpage does show properly but it will still show "Want this in 中文(Chinese)"
Eric Eastwood
@MadLittleMods

I assume you are looking at server/handlers/root.js#L43-58

Does var requested = req.headers['accept-language'] come in as zh-tw? You could use the following code. I am not sure if requestedLangand requestedRegion are the proper terms for this

var requested = req.headers['accept-language'];
const [requestedLang, requestedRegion] = requested.split('-')

->

requestedLang = 'zh'
requestedRegion = 'tw'
Johnny Yeng
@a2902793_gitlab
Might as well just explain this in details in a mr, kinda flooding this chatroom with my terrible explanation
it dows come in zh-tw
but additional parsing was done
Eric Eastwood
@MadLittleMods
@a2902793_gitlab You can parse it however you want. And we don't need to keep modifying the request variable in place over and over. It would be better to name those as separate variables for each step
Johnny Yeng
@a2902793_gitlab
hold on, I figure I might as well write a simple explanation of what I'm tryin to say here.
Eric Eastwood
@MadLittleMods
@a2902793_gitlab I'm going to go shower, will look when I'm back :+1:
Eric Eastwood
@MadLittleMods
@a2902793_gitlab Here if you want to discuss something more
If this looks good to you, I'll send my MR
Eric Eastwood
@MadLittleMods
@a2902793_gitlab Please send a MR :slight_smile: we can discuss it there
Johnny Yeng
@a2902793_gitlab
@MadLittleMods my pipeline keeps on failing on "ValidationError: Path username is required."... can you kindly point me out what the problem may be?
Eric Eastwood
@MadLittleMods

@a2902793_gitlab That's fine. If you want the pipeline passing/green, see https://gitlab.com/gitlab-org/gitter/webapp#getting-the-gitlab-ci-tests-green-white_check_mark

You can still create the merge request against the main webapp project though

@a2902793_gitlab We want to improve this experience in the future, gitlab-org/gitter/webapp#1974
Johnny Yeng
@a2902793_gitlab
Is one topic per MR preferred or mashing different kinds in one?
Eric Eastwood
@MadLittleMods
@a2902793_gitlab Better to just create a separate MR so we don't have some changes blocked by others while it's being reviewed. If it's a small separate change, we can approve and merge it right away :rocket: