Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Jun 05 2018 23:13
    @MadLittleMods banned @LWSS
Ben Jackson
@puremourning
alternaively, we could redesign the room view controller to use e.g. https://github.com/GitHawkApp/MessageViewController
Eric Eastwood
@MadLittleMods
@puremourning That replacement you linked sounds good enough to me 😇 And looks like they just recently upgraded to Swift 5
Ben Jackson
@puremourning
i gave it a try but ran out of talent; it’s not quite a drop in replacement as we’re using a toolbar controller, and it wants to control the main scrollview. i’ll try again if i can’t fix this slack thingy ...
i did manage to fix the slack thingy on iphone, but then i noped out of it when it didn’t also fix it for ipad
Ben Jackson
@puremourning
i have fixed the slack text input font thing
not sure how you want to play it, but happy to update the pod to point at that repo, which will fix the iOS app build
can’t make a PR because the upstream is locked up tight
Eric Eastwood
@MadLittleMods
@puremourning Argh, that sucks. I've made a fork https://github.com/gitterHQ/SlackTextViewController which we can point to instead. Mind making a PR there?
Ben Jackson
@puremourning
Sure
erm ok that’s confusing. github doesn’t want to let me make a PR from puremourning/SlackTextViewController to gitterGQ/SlackTextViewController
for no obvious reason
Ben Jackson
@puremourning
Eric Eastwood
@MadLittleMods
@puremourning Merged into a gitter branch :tada:. Anything more I need to do to update pods?
Ben Jackson
@puremourning
I will update the PR to include Podfile change to use that fork + Gitter branch
Ok, yep that all works.
Sending this now from the sim. It all seems fine. Just need to fix some dark mode stuff, which might not be super easy.
Eric Eastwood
@MadLittleMods
@puremourning I don't remember the Gitter iOS app having a dark mode. But I assume you mean the iOS 13 native dark mode and perhaps some weird text colors
Ben Jackson
@puremourning
@MadLittleMods that’s right. iOS 13 has a dark mode; when enabled the room list view has black-on-black text
Ben Jackson
@puremourning
yeah….
Screenshot 2019-10-09 at 20.58.41.png
i suspect there’s a bunch of work to do there, such as telling the embedded webapp to render in its own dark mode
Ben Jackson
@puremourning
ok first part wasn’t that hard
Screenshot 2019-10-09 at 21.17.41.png
Eric Eastwood
@MadLittleMods
@puremourning Nice! Just thinking out loud, if there is a way for an app to ignore the dark mode setting, then that works as a first step. But sounds like you're making good progress
Ben Jackson
@puremourning
I think that's possible, though it might not get through App Store review (not sure). anyway I got side-tracked because I finally repro'd a crash ! seems there's an issue when you log out and then the app enters the foreground
just trying to reliably repro
yah repro is simple
Eric Eastwood
@MadLittleMods
@puremourning Add some repro instructions to the issue as some dev notes just for reference please
Ben Jackson
@puremourning
way ahead of ya :) I raised a new issue with the repro steps
Eric Eastwood
@MadLittleMods
@puremourning Sweet! Linked it from https://gitlab.com/gitlab-org/gitter/gitter-ios-app/issues/39#note_169670418 just in case it is related
Ben Jackson
@puremourning
could it be simply that "Suggestion" isn't actually in the store
that's the entityName that it bails on
yep, that fixed it
it's called "UserSuggestionCollection" in JsonToDatabase.swift
it's also not obvious why we only clear "Room" and "Suggestion" there - should it clear 'Group' etc. too
Eric Eastwood
@MadLittleMods
@puremourning I think "why not" 🤔. Logging out shouldn't save any data for you
Ben Jackson
@puremourning
ok fixed that crash. it's now marginally less bad
Ben Jackson
@puremourning
@MadLittleMods I had a few goes as dark mode and it looks like a whole other job of its own, so for now I've set the user interface style to light for the whole app, which turns off dark mode for the app
Ben Jackson
@puremourning
I think the app is basicaly g2g, but I'm going to install it on my phone and field test it for a week or so
Eric Eastwood
@MadLittleMods
@puremourning We can ship it as an alpha/beta, get it through review, and test that release as well
Ben Jackson
@puremourning
Sounds good. PR is up to date
Eric Eastwood
@MadLittleMods
@puremourning Can you make comments on the diff for anything of note or background behind the change? There are a ton of changes in the diff and want to make sure anything bigger gets some :eyes:, gitlab-org/gitter/gitter-ios-app!8
Ben Jackson
@puremourning
the only think I really changed in the app code was the fix for the crash. all the rest was just updating to swift 5 and updating third-party dependencies; I think it might be better to split this into multiple PRs
but for tonight I think I'm going to call it. g'night
Eric Eastwood
@MadLittleMods

@puremourning I'm downloading the latest Xcode so I can try it out. I'll go through some of your commits. Splitting it up sounds a bit painful and your commits seem pretty nice

Thanks for all the effort getting this in shape!!

Ben Jackson
@puremourning
No worries :)
Ben Jackson
@puremourning
In case you didn’t see I found the issue with the TestFlight build - it’s missing the production secrets
Ankur Mittal
@ankurmittal092_gitlab

Hi .. I'm trying to set up gitter project in my mac and I'm getting the following error on npm start

{ message: 'OAuthStrategy requires a consumerKey option',
     stack:
      'TypeError: OAuthStrategy requires a consumerKey option\n    at Strategy.OAuthStrategy (/Users/ankurmittal/Desktop/Self/webapp/node_modules/passport-oauth1/lib/strategy.js:83:37)\n    at new Strategy (/Users/ankurmittal/Desktop/Self/webapp/node_modules/passport-twitter/lib/strategy.js:53:17)\n    at Object.<anonymous> (/Users/ankurmittal/Desktop/Self/webapp/server/web/strategies/twitter.js:47:23)\n    at Module._compile (internal/modules/cjs/loader.js:778:30)\n    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)\n    at Module.load (internal/modules/cjs/loader.js:653:32)\n    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)\n    at Function.Module._load (internal/modules/cjs/loader.js:585:3)\n    at Module.require (internal/modules/cjs/loader.js:692:17)\n    at require (internal/modules/cjs/helpers.js:25:18)\n    at Object.<anonymous> (/Users/ankurmittal/Desktop/Self/webapp/server/web/passport.js:12:23)\n    at Module._compile (internal/modules/cjs/loader.js:778:30)\n    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)\n    at Module.load (internal/modules/cjs/loader.js:653:32)\n    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)\n    at Function.Module._load (internal/modules/cjs/loader.js:585:3)\n    at Module.require (internal/modules/cjs/loader.js:692:17)\n    at require (internal/modules/cjs/helpers.js:25:18)\n    at Object.<anonymous> (/Users/ankurmittal/Desktop/Self/webapp/server/web.js:24:1)\n    at Module._compile (internal/modules/cjs/loader.js:778:30)\n    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)\n    at Module.load (internal/modules/cjs/loader.js:653:32)\n    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)\n    at Function.Module._load (internal/modules/cjs/loader.js:585:3)\n    at Module.require (internal/modules/cjs/loader.js:692:17)\n    at require (internal/modules/cjs/helpers.js:25:18)\n    at Object.<anonymous> (/Users/ankurmittal/Desktop/Self/webapp/web.js:7:1)\n    at Module._compile (internal/modules/cjs/loader.js:778:30)\n    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)\n    at Module.load (internal/modules/cjs/loader.js:653:32)\n    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)\n    at Function.Module._load (internal/modules/cjs/loader.js:585:3)\n    at Function.Module.runMain (internal/modules/cjs/loader.js:831:12)\n    at startup (internal/bootstrap/node.js:283:19)\n    at bootstrapNodeJSCore (internal/bootstrap/node.js:622:3)',
     name: 'TypeError' },
  meta:
   { errorString: 'TypeError: OAuthStrategy requires a consumerKey option',
     type: 'uncaught' },

Can someone help me with this?