Mike Bartlett
@mydigitalself
Just popped in to say :wave: and shout out to @MadLittleMods for the iOS open sourcing :boom:
Eric Eastwood
@MadLittleMods
@mydigitalself Heya 🤗 thanks 🚀
Mike Bartlett
@mydigitalself

fyi...

https://gitlab.com/gitlab-org/gitter/gitter-markdown-processor/blob/master/lib/processor.js

Gives me "Error loading viewer"

was digging around a bit for what we used to process markdown out of process.

var Processor = function() {
  this.farm = workerFarm({
      maxConcurrentWorkers: 1,
      maxConcurrentCallsPerWorker: 1,
      maxCallTime: 3000
    },
    require.resolve('./process-chat-async')
  );
};

i remembered there being more concurrent workers...

Eric Eastwood
@MadLittleMods

@mydigitalself What browser are you using to look at https://gitlab.com/gitlab-org/gitter/gitter-markdown-processor/blob/master/lib/processor.js ? I can view it in Chrome, signed in and NLI

From the git-blame at least, it looks like it has been 1 worker since the repo was created. I am not familiar with the worker processing there though

Mike Bartlett
@mydigitalself
i'm on chrome latest NLI
Eric Eastwood
@MadLittleMods
@mydigitalself Any JS error in the devtools console?
Mike Bartlett
@mydigitalself
i just found the problem
Screen Shot 2018-09-18 at 17.18.23.png
turned off AdBlocker and loads just fine, turn back on, same thing
:worried:
Eric Eastwood
@MadLittleMods

@mydigitalself What script is it blocking? Based off of the relevant GitLab code, I assume /gitlab-org/gitter/gitter-markdown-processor/blob/master/lib/processor.js?format=json&viewer=simple. I can't find an existing issue around adblock and the blob viewer. Probably best to create an issue linking your extension, https://gitlab.com/gitlab-org/gitlab-ce/issues

uBlock Origin (adblocker) seems to play nicely

Mike Bartlett
@mydigitalself
yip

processor.js?format=json&viewer=simple:1 Failed to load resource: net::ERR_BLOCKED_BY_CLIENT`
will file now @MadLittleMods
Eric Eastwood
@MadLittleMods
^ Issue for reference gitlab-org/gitlab-ce#51608
John
@ionutblt

hello there

if you scan your desktop executable for the windows platform on virustotal you get a " AdWare.Vosteran.aj " warning

image.png
Eric Eastwood
@MadLittleMods

@ionutblt It is probably a false-positive. Example from before, gitlab-org/gitter/desktop#194

Feel free to create an issue

Ben Johnson
@cbj4074
@MadLittleMods :point_up: September 13, 2018 11:26 AM Sorry for the late reply; indeed it is. I misread what was said. :blush:
Totalh Developer
@totalhdeveloper_twitter
Hey, Can I do a job post? @MadLittleMods
Eric Eastwood
@MadLittleMods
@totalhdeveloper_twitter No, please. Only if the room explicitly says it allows job posting in the room topic in the chat header at the top
Benoit Chesneau
@benoitc
is this possible today to register to gitter using a self hosted gitlab?
knod
@knod
Sorry for putting this question here, but is there a room for github in general?
Philip Durbin
@pdurbin
There used to be a room run by GitHub at https://gitter.im/githubschool/on-demand
Zoltán Csáti
@CsatiZoltan
Hi,
Is it possible to search the whole room? I experienced that only the currently seen messages can be searched by Ctrl+F. On solution is to scroll up many times but that is very tiring for long conversations. The Room settings -> Archives is useful if I want to search in a specific day, but that does not show the full history.
Ted Thibodeau Jr
@TallTed
@CsatiZoltan - I think your current best bet is to use Google's advanced features, as seen here site:gitter.im inurl:gitterHQ/gitter/archives gitlab, but their crawler doesn't update as often as you may wish
@MadLittleMods Another fun issue with the native app (4.1.0 for macOS)! Close the main window with cmd-W. Now try to re-open it, or quit, or anything else. I had to force-quit and relaunch Gitter.app.
Zoltán Csáti
@CsatiZoltan
@TallTed Thanks, though it doesn't work in our room (maybe because it's private?).
Ted Thibodeau Jr
@TallTed
@CsatiZoltan Ah, yeah, I was going to put in a caveat about publicly crawlable... One of a long list of problems I have with Gitter.
Eric Eastwood
@MadLittleMods
:point_up: September 24, 2018 5:00 AM @benoitc You can only sign in with GitLab.com at the moment
:point_up: September 24, 2018 9:54 AM @CsatiZoltan @TallTed The magnifying glass in the left-menu menu-bar (Ctrl/Cmd + S) will search messages in the current room, https://gitlab.com/gitlab-org/gitter/webapp/blob/develop/docs/messages.md#searching-messages
Zoltán Csáti
@CsatiZoltan
@MadLittleMods Awesome, thanks!
Ted Thibodeau Jr
@TallTed

@MadLittleMods Oh, hey, that works today! (I tried searching for something else not-long-ago, and no dice ... could have been a hiccup).

Weird that there's no scroll bar on the results display ... and wow, the auto-expand-on-mouseover has issues when the expanded data overlaps the top of the display spaec and then collapses because your mouse moves to the next item which is then higher in the list so it expands and then collapses and the lower thing expands -- so the "middle" item disappears.

Eric Eastwood
@MadLittleMods
@TallTed You can track gitlab-org/gitter/webapp#1925
Ted Thibodeau Jr
@TallTed
@MadLittleMods It's VERY weird to use ctrl/cmd + S for "Search" (instead of ctrl/cmd + F for "Find") when it's "Save" in virtually every app (including most web browsers)
Eric Eastwood
@MadLittleMods
@TallTed We don't override Ctrl + f because it's nice to still use the native browser find, gitlab-org/gitter/webapp#751
Ted Thibodeau Jr
@TallTed
@MadLittleMods But you do override Ctrl + s because ... who would think that meant "save"?
Eric Eastwood
@MadLittleMods
@TallTed Saving the page seems a lot less useful for Gitter. Any keybind suggestions?
Ted Thibodeau Jr
@TallTed

@MadLittleMods - It's not a question about whether saving the page is useful for Gitter, it's that Command-S is used for "Save" EVERYWHERE so trying to remember to use it for search in Gitter is a major effort ... and may acuse problems when trying to search somewhere else (and accidentally saving).

This also highlights the problem have having both a native app and a browser tab, and trying to make them behave the same. I'd say Gitter should use Command-Shift-F but Chrome (at least) uses that for "Search the Web" ... and Command-Option-F for "Enter Full Screen" ...

Command-Option-Shift-F isn't used yet... Nor is Command-Opt-S (not commonly used in Mac apps). I wouldn't suggest Command-Shift-S (commonly "Save As" on Mac).

This is a helpful reference, covering Apple's macOS apps -- https://support.apple.com/en-us/HT201236

Mark Carpenter Jr
@mcarpenterjr
@MadLittleMods & @TallTed just went through this with some internal apps, and the moral question of hijacking native functionality. Essentially our users were relying on CTRL+F in place of the built in search, to make the experiece better for everyone we allowed the use of CTRL+F but in addition reminded everyone through a toast and some subtle highlighting, that our builtin search is way more powerful and better equipped to search/filter the information in app. It might not be a bad idea to do something similar here.
Eric Eastwood
@MadLittleMods

@mcarpenterjr Ctrl + f isn't overridden in Gitter. Currently it is bound to Ctrl + s

Does the toast pop when you press Ctrl + f?

Mark Carpenter Jr
@mcarpenterjr
Yes, we still allow the use of what ever the native crtl+f is we just gently remind our users that builtin search is better. So they're still in control of their browsing experience.
Mikhail Kyraha
@kyraha
My Gitter channel is quite quiet but I would like to let my team in other chat solutions be informed if there's an activity. But I don't want to constantly run a process on a server listening for the API. A simple webhook would be a better solution - whenver there's a message in my Gitter channel a POST request would go to a configured URL (AWS Lambda). Does Gitter support something like that? I couldn't find anything in the documentation. Thank you.
Eric Eastwood
@MadLittleMods
@kyraha There isn't anything built-in to Gitter for that. Seems like you may want to use https://sameroom.io/
Mikhail Kyraha
@kyraha
@MadLittleMods That's interesting, 5 messages/day may be OK for most of the time but won't cover a conversation if there's a burst once in a while. I'm not ready to pay $50/month for a mostly idle pipe. I was looking for a solution that I could host in a pay-per-use cloud. But thank you anyway.
Eric Eastwood
@MadLittleMods
@kyraha You can track gitlab-org/gitter/webapp#1745, merge request welcome!
Mikhail Kyraha
@kyraha
yes, exactly that! thanks!
Alexandre Daoud
@alexandred
is it possible to have a user IP banned?
Eric Eastwood
@MadLittleMods
@alexandred We can ban them from Gitter overall. Send an email to support@gitter.im with the details
Alexandre Daoud
@alexandred
@MadLittleMods thanks, will do