Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
Abdelhak Akermi
@abakermi
Hello
Clement Sam
@profclems
Hi @abakermi, thanks for contributing
Please make sure to share so we get more users and contributors
https://github.com/profclems/glab
Clement Sam
@profclems

Note that there are a lot more stuff to do. Make sure your forked repo is up-to-date with the original repo.

We are now using Go-gitlab, which is a wrapper package to the GitLab API instead of making request directly using the MakeRequest function

Abdelhak Akermi
@abakermi
Ok I will pulled again, you have to some roadmap of all stuff to do
Clement Sam
@profclems
@abakermi, I have created new issues
Clement Sam
@profclems
All PRs should be opened against the default branch (trunk)
Abdelhak Akermi
@abakermi
I have done the clone command but currently it just get the streamed archive , we can extract the archive in one time also
Clement Sam
@profclems
Yeah that's true. we can get the zip file, can unzip with the "archive/zip" package and put it in the directory specified by the user and then delete the zipped file
Clement Sam
@profclems
I'm restructuring the project structure and a few file changes to automatically generate docs for each command
Abdelhak Akermi
@abakermi
@profclems that's better clear and consistent, i will continue with that definition for the clone command
Clement Sam
@profclems
@abakermi you did a great job... I'll do a release soon
I will be creating a milestone for future thoughts I have. I'm thinking of adding the ability to view a running CI job Live on the command line with
glab ci view <pipeline-id>

or 

glab  pipeline view <pipeline-id>
Clement Sam
@profclems
I think it's a big milestone to cross 😃
Clement Sam
@profclems
image.png
Working on watching a running pipeline on the cli... It's been a fun challenge
Clement Sam
@profclems
@/all 😃
I have opened an issue and a merge request on GitLab alliance project for glab to be added to their partners' page
gitlab-com/alliances/alliances#126
Clement Sam
@profclems
Hi @/all, I would need your suggestions on #170 . Let me know what you guys think
Benjamin Graf
@bgraf
Howdy! Nice tool you got there. Wanted to ask whether "tab-completion of labels during issue creation" is a feasible enhancement in the current design of the tool (didn't invest time looking into it, just noticed it while playing around)?
Clement Sam
@profclems
@bgraf yeah I think it's feasible if we are suggesting predefined labels instead of the project label. Probably we can load the project labels and generate a completion script from that.
We want to consider bash, shell and zsh completion scripts generation. Cobra has support for that so I think we can work on that for glab
I just opened this issue #174
Benjamin Graf
@bgraf
@profclems Yeah, shell completion is a good idea. The other issue would be completion inside the CLI when entered via glab issue new <enter> and prompted for labels in the 3rd step. Probably needs some thought on how to handle that, e.g. (i) caching project labels in project/.glab-cli and suggesting those or (ii) fetching them on demand. The latter is not a good option I suppose.
Clement Sam
@profclems
@bgraf good suggestion. Fetching on demand may not be a good option. I agree with the first option. It will be nice to implement this feature. Please open an issue on that
Clement Sam
@profclems
glab uses survey for prompts. Survey has docs on multiselect https://github.com/AlecAivazis/survey#multiselect so I think this implementation is feasible for glab's current design
Benjamin Graf
@bgraf
@profclems Have done that! #175
Clement Sam
@profclems
@bgraf Great! I will look at that, however, I will be glad if you'd want to take this up
Benjamin Graf
@bgraf
Sure, I will have a look at it, may take some time though :)
Clement Sam
@profclems
Sure... I get it
Benjamin Graf
@bgraf
Will be an opportunity for me to see, how easy/difficult it is to understand a larger go code base, looking forward to it
Clement Sam
@profclems
🎉
Notify in case you need any clarification
I'm currently writing tests for the commands
Benjamin Graf
@bgraf
Yes, what's your thought on how to cache the labels. Should I config.SetEnv them in the listLabels command if UseGlobalConfig == false and otherwise don't? Then in the prompt I GetEnv and if it is empty, we prompt like before, and if there are options, we use multi select?
Clement Sam
@profclems
Yeah sounds good. But the values passed to config.SetEnv should be comma-separated label names since it will be much easier to split into a map and use for the prompt. I would suggest PROJECT_LABELS as the env name.
Benjamin Graf
@bgraf
@profclems I've already chosen "PROJECT_LABELS", good match :)
Clement Sam
@profclems
Haha... great
Benjamin Graf
@bgraf
@profclems I submitted a pull-request for further discussion
Clement Sam
@profclems
Yeah... I'm taking a look
Clement Sam
@profclems

How to deal with new labels when prompting via multi select?

This is worth considering...

There should be a better workaround to handle this 🤔