GLab/community

All discussions and issues related to GLab

Clement Sam

@profclems

@/all 😃
I have opened an issue and a merge request on GitLab alliance project for glab to be added to their partners' page
gitlab-com/alliances/alliances#126

Clement Sam

@profclems

Hi @/all, I would need your suggestions on #170 . Let me know what you guys think

Benjamin Graf

@bgraf

Howdy! Nice tool you got there. Wanted to ask whether "tab-completion of labels during issue creation" is a feasible enhancement in the current design of the tool (didn't invest time looking into it, just noticed it while playing around)?

Clement Sam

@profclems

@bgraf yeah I think it's feasible if we are suggesting predefined labels instead of the project label. Probably we can load the project labels and generate a completion script from that.

We want to consider bash, shell and zsh completion scripts generation. Cobra has support for that so I think we can work on that for glab

I just opened this issue #174

Benjamin Graf

@bgraf

@profclems Yeah, shell completion is a good idea. The other issue would be completion inside the CLI when entered via glab issue new <enter> and prompted for labels in the 3rd step. Probably needs some thought on how to handle that, e.g. (i) caching project labels in project/.glab-cli and suggesting those or (ii) fetching them on demand. The latter is not a good option I suppose.

Clement Sam

@profclems

@bgraf good suggestion. Fetching on demand may not be a good option. I agree with the first option. It will be nice to implement this feature. Please open an issue on that

Clement Sam

@profclems

glab uses survey for prompts. Survey has docs on multiselect https://github.com/AlecAivazis/survey#multiselect so I think this implementation is feasible for glab's current design

Benjamin Graf

@bgraf

@profclems Have done that! #175

Clement Sam

@profclems

@bgraf Great! I will look at that, however, I will be glad if you'd want to take this up

Benjamin Graf

@bgraf

Sure, I will have a look at it, may take some time though :)

Clement Sam

@profclems

Sure... I get it

Benjamin Graf

@bgraf

Will be an opportunity for me to see, how easy/difficult it is to understand a larger go code base, looking forward to it

Clement Sam

@profclems

🎉
Notify in case you need any clarification

I'm currently writing tests for the commands

Benjamin Graf

@bgraf

Yes, what's your thought on how to cache the labels. Should I config.SetEnv them in the listLabels command if UseGlobalConfig == false and otherwise don't? Then in the prompt I GetEnv and if it is empty, we prompt like before, and if there are options, we use multi select?

Clement Sam

@profclems

Yeah sounds good. But the values passed to config.SetEnv should be comma-separated label names since it will be much easier to split into a map and use for the prompt. I would suggest PROJECT_LABELS as the env name.

Benjamin Graf

@bgraf

@profclems I've already chosen "PROJECT_LABELS", good match :)

Clement Sam

@profclems

Haha... great

Benjamin Graf

@bgraf

@profclems I submitted a pull-request for further discussion

Clement Sam

@profclems

Yeah... I'm taking a look

Clement Sam

@profclems

How to deal with new labels when prompting via multi select?

This is worth considering...

There should be a better workaround to handle this 🤔

Benjamin Graf

@bgraf

well, maybe it would be sufficient to say that users need to use the -l options to do that then? I guess the number of times you want to add an existing label largely outnumbers the times you'd want to add a new one?

another option is to have multiple steps, i.e.: first the multiselect, then the old prompt to "add" more labels to it.. hm

Clement Sam

@profclems

well, maybe it would be sufficient to say that users need to use the -l options to do that then? I guess the number of times you want to add an existing label largely outnumbers the times you'd want to add a new one?

Yeah the multistep seems fine but the user should ask for it using a flag. I think the -l should be fine

Clement Sam

@profclems

Thinking about it again, we should go with your first suggestion instead of the multistep

Benjamin Graf

@bgraf

Yes, ok

Benjamin Graf

@bgraf

@profclems how can I retrofit signatures onto my commits, should I rebase&squash them and sign the resulting single commit, then force push my branch on my repository? do you have experience with that case? sorry to have forgotten that requirement :)

Benjamin Graf

@bgraf

ok, that worked out, all commits signed

Clement Sam

@profclems

Ok nice

nlarzon

@nlarzon

Hi, is there anyway I can configure glab to use specific certificates for api calls?

Clement Sam

@profclems

Yes. You can do that in your config file by adding the path to the ca cert using the ca_cert config value.

You can also set with

glab config set ca_cert "/path/to/cert"

nlarzon

@nlarzon

thx

Clement Sam

@profclems

You can also make it host specific

glab config set ca_cert "/path/to/cert" --host gitlab.example.org

nlarzon

@nlarzon

" none of the git remotes configured for this repository points to a known GitLab host. Please use glab config init to configure a new host for glab" Is there a debug command I can use?

Clement Sam

@profclems

You should run glab auth login to authenticate with your GitLab instance

nlarzon

@nlarzon

yes, done that. Still the same issue

Clement Sam

@profclems

Run git remotes -v to see if your repo contains the host you have authenticated with glab.
glab checks to see if the repository points to an authenticated host and uses it

nlarzon

@nlarzon

yes it does

nlarzon

@nlarzon

    gitlab.mydomain.com:
        api_protocol: https
        token: <super-secret>
        git_protocol: ssh
        user: me
        ca_cert: path/client.pem
        ca_cert_key: path/client-key.pem
remote_alias: origin


git remote -v
origin    git@gitlab.mydomain.com:my-group/project/repo.git (fetch)

Clement Sam

@profclems

There's a host mismatch here. You're using gitlab.mydomain.com in glab's config but your host is git.mydomain.com

Update the host in your config to git.mydomain.com

nlarzon

@nlarzon

sorry it is just my anonymization that is wrong

Clement Sam

@profclems

I can't seem to reproduce the error

I'm thinking you should still check. There's probably a host mismatch

Clement Sam

@profclems

@nlarzon kindly open an issue on it if you're still facing this issue

maxice8

@maxice8_gitlab

@profclems yes ?

Where communities thrive

People

Repo info

Activity