These are chat archives for glue-viz/glue-vispy-viewers

28th
Apr 2016
Penny Qian
@PennyQ
Apr 28 2016 15:25
@astrofrog Yeah my pyonengl isn’t installed but the 3D viewers are totally gone from the dropdown selections after install it...
Penny Qian
@PennyQ
Apr 28 2016 15:32
  • glue-viz/glue-3d-viewer#105 I think this is about the whole code structure of Glue that we may need to carefully think about it
Thomas Robitaille
@astrofrog
Apr 28 2016 15:33
@PennyQ - for the 2D viewers in normal glue, it's normal that the subset is present in all datasets
but if the components of the dataset are incompatible the subsets will be empty for the other datasets
basically what we are missing at the moment is that we should only apply subsets to data that have the right components on the x/y/z axis
in the 3D plugin
Penny Qian
@PennyQ
Apr 28 2016 15:35
  • glue-viz/glue-3d-viewer#125 what else should be included in this PR? I also did some survey on the 3D output like sketchfab but most of those 3d formats require a defined shape of the 3d objects, so I guess for the 3D volume data cube producing a movie consisted of a series of figures might be a better choice
Thomas Robitaille
@astrofrog
Apr 28 2016 15:37
I think it's basically ready to merge, apart from a small comment I just left
Penny Qian
@PennyQ
Apr 28 2016 16:15
@astrofrog yeah I agree but I checked the code and found for each glue window, only one Viewer is instanced and that’s why even you created two same-type Viewers for two different data, they have the same layout which causes one selection on one data will also be applied to the other data and showed in both Viewers
Thomas Robitaille
@astrofrog
Apr 28 2016 16:15
huh
Penny Qian
@PennyQ
Apr 28 2016 16:16
I should quote it… hmmm… it’s tricky
Thomas Robitaille
@astrofrog
Apr 28 2016 16:16
so wait, this is happening just for the 3D viewers or also 2D?
Penny Qian
@PennyQ
Apr 28 2016 16:16
both, all viewers
Thomas Robitaille
@astrofrog
Apr 28 2016 16:16
I mean there are several things here - first, it's normal that there are multiple 'subsets' per subset, one for each data file
can you easily record a movie to show an example where in 2D there is an incorrect selection that happens?
Penny Qian
@PennyQ
Apr 28 2016 16:17
Yeah sure~
the thing is the layer part
there is a layer called subset1 (l1448_13co),but actually I just did a selection on another viewer with another dataset named B5_11_clean
Thomas Robitaille
@astrofrog
Apr 28 2016 16:31
Right yes, but that is normal - the subsets are added to all datasets (and by extension all viewers), but in this case the subset can't be computed because the dataset is different, so there is a red cross next to subset1 (l1448_13co)
the idea is that if you then were to link the coordinates of the two datasets, then it would be able to compute the subset in both viewers
Penny Qian
@PennyQ
Apr 28 2016 16:32
Oh, the cross means not computed, ok got it, but in the 3d viewer the wrong subset is drawn and showed in the viewer
Thomas Robitaille
@astrofrog
Apr 28 2016 16:32
ok so I think that's the issue
when we apply the subset we should only apply it to datasets where it makes sense
I need to look into it further
Penny Qian
@PennyQ
Apr 28 2016 16:34
now we are using a normalized grid scale for 3d data, but if we apply it’s spacial scale (Alyssa mentioned this again…) maybe that could be used as a standard to judge the subset should be comuputed or not?
Thomas Robitaille
@astrofrog
Apr 28 2016 16:37
yes
we should keep track of which components are shown on which axes
Penny Qian
@PennyQ
Apr 28 2016 16:39
would you liket to do it or leave some tips under the issue that I could try? I am not very clear yet :(
Thomas Robitaille
@astrofrog
Apr 28 2016 16:40
There are several things we need to do here:
Penny Qian
@PennyQ
Apr 28 2016 16:42
  • glue-viz/glue-3d-viewer#95 Dendrogram selection- Now I have a data cube and after the mouse click, I could get the max-value along eye-sight line of the clicking postion. Could I get 1) where is this max-value point in the dendrogram tree structure and it’s above substructure 2) make this part shown on the 3d volume (I think this part is already done)
Thomas Robitaille
@astrofrog
Apr 28 2016 16:43
For the cube attributes, first, we need to enable the combo boxes to select which coordinates are shown on which axis (like we have for the scatter plot). However, this is not necessarily trivial because we then need to make sure that we then swap the order of dimensions of the cube that are shown - for example if the user picks to show y, x, z, we need to adjust this in the 3D view - so this will require some work. At the same time we should implement the slicing of extra dimensions as we discussed before
I don't have any specific hints for how to do the combo boxes at this time because I need to look in more detail - so I'd say only look if you think you have a clear idea of how to do it, but otherwise I can look into it next week
Once we have that working, then we can make sure the selection is only done to datasets that have the same attributes as the ones shown.
that method will give you the structure at certain pixel coordinates
Once you do that you can convert to a mask and select similarly to what you are doing already for volume selection
(I have to run, back a bit later)
Penny Qian
@PennyQ
Apr 28 2016 16:48
Yeah please go, I still have some questions but I will leave it here and you could check it when you have time :) Thanks a lot!!!
Penny Qian
@PennyQ
Apr 28 2016 17:04
So I will first get a Dendrogram through d=Dendrogram.compute(arrar), then hub the mouse event and get the max-value pos of clicking eye-sight line, and get the substructure = self.dendrogram.structure_at(pos) and convert this substructure into a mask and get highlited in the volume visual
At the same time we should implement the slicing of extra dimensions as we discussed befor
  • what’s this issue?
Thomas Robitaille
@astrofrog
Apr 28 2016 17:31
I was referring to glue-viz/glue-3d-viewer#122
I'll be back online tomorrow morning your time - and I may actually have time to speak on hangouts then
Penny Qian
@PennyQ
Apr 28 2016 17:58
That would be great, although I found asking questions here are also very useful.
  • Beside the 3d dendrogram selection, I also worked on the contour selection as see on glue-viz/glue-exp#7 and 3d floodfill selection glue-viz/glue-3d-selection#4 but before I poured out the code questions, I am wondering do we need all these three selection schemes?