Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Andrew Redden
    @androolloyd
    if you're accepting PR's for the docs I can ticket my problems along the way
    and will update where applicable.
    any plans to adopt SwiftUI?
    Dmitry Bespalov
    @DmitryBespalov
    for sure, just create a pr and assign it to me
    Andrew Redden
    @androolloyd
    It's very react like, and is a lot of fun to work with.
    Dmitry Bespalov
    @DmitryBespalov
    wanted to use it for the address book feature, but in the end went with storyboards. I’m open to having it in the project as early as possible.
    Andrew Redden
    @androolloyd
    I think it would be great to power any ui Hooks :D
    or dare I say the word, plugins!
    declartive UI's, and plug and play with flexgrid layouts.
    Dmitry Bespalov
    @DmitryBespalov
    🤯
    Andrew Redden
    @androolloyd
    what branch of the relay is the most up to date for the app?
    just master?
    Dmitry Bespalov
    @DmitryBespalov
    master is the stable one, develop might be braking
    Andrew Redden
    @androolloyd
    ok thanks.
    Dmitry Bespalov
    @DmitryBespalov
    but the newest
    Andrew Redden
    @androolloyd
    Keycard setup was awesome btw!
    i did get a lot of disconnect issues until i realized the nfc was closer to the middle of the card vs the gold contact
    Dmitry Bespalov
    @DmitryBespalov
    yes, you need to tap top of the phone with the middle of the card
    and the connection is unstable
    But it was interesting to play with :)
    Andrew Redden
    @androolloyd
    swiftUI would be great for allowing customizing of the signer screen
    for diff EIP's 712, 1337 :D
    etc
    Dmitry Bespalov
    @DmitryBespalov
    the 712 was deprioritized although we had the basic designs ready for it. there were issues with contract support and also support in hardware wallets
    ok, I’m off for today and for the weekend.
    Andrew Redden
    @androolloyd
    thanks for everything, much apprecated!
    Dmitry Bespalov
    @DmitryBespalov
    sure thing
    Andrew Redden
    @androolloyd
    Screen Shot 2019-11-15 at 3.04.54 PM.png
    something to note ther ewas a invalidAddress error being through in the multisig domain, but commenting it out lets it complete successfully
    Dmitry Bespalov
    @DmitryBespalov
    thanks
    Ai Suzuki
    @aisuzuki
    Hi, has anyone ever tried to transfer eth to proxy address in a smart contract? Sending ether via web3 works, but transferring eth in smart contract emits revert (e.g, proxyAdderss.transfer(value)). proxyAddress.call.value(value)(""), however, works but I want to opt safer method.
    Uxío
    @Uxio0
    @aisuzuki If you try to use transfer gas is set to 23000. As the proxy contract is trying to check for fallback functions it requires a little more gas than transferring to another contract or a EOA
    Ai Suzuki
    @aisuzuki
    Thank you, @Uxio0 . So it caused due to lack of gas? I wondered if transferring eth to proxy is not common thing to do...
    Sounds like x.call.value(value).("") is a solution to send eth to proxy address.
    Uxío
    @Uxio0
    x.call.value(value).("") is the solution, but I would still set a gas limit to prevent reentrancy problems
    Ai Suzuki
    @aisuzuki
    Thanks yes more secure :)
    Uxío
    @Uxio0
    What proxy are you using @aisuzuki?
    Because with the Safe proxy it should work with 23000 gas
    Is this what you meant?
    Ai Suzuki
    @aisuzuki
    yes it's odd the code below works
    proxyAddress.call.gas(2300).value(value)("");
    Just both proxyAddress.transfer(value) and proxyAddress.send(value) fails
    Richard Meissner
    @rmeissner
    hmm yes I can reproduce that with a test in ganache
    this sounds weird
    actually in the test it doesn't fail for transfer and send it just doesn't do them, but maybe that is just because the test somehow wraps the error
    Richard Meissner
    @rmeissner
    it seems the gas(2300) will be topped up by solidity (tried to set it with assembly same thing), while for send and transfer it is hardcoded
    Ai Suzuki
    @aisuzuki
    @rmeissner Thank you for reproducing it. Yes, we guessed same. I'm looking into Ethereum client's code now.
    @rmeissner Don't you get revert from transfer or send?
    Richard Meissner
    @rmeissner
    We do, this will be fixed since this only happens with the contracts currently in the bug bounty. The 1.0.0 contracts should work.
    Ai Suzuki
    @aisuzuki
    Great to hear and thank you for fixing this :)