Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Ville Hakulinen
    @vhakulinen
    @alexeevit can you try with latest gnvim master and latest nvim master?
    sounds like #29
    smolck
    @smolck
    @vhakulinen Do you think a rewrite of the text drawing implementation could fix the pango issues? Or, maybe a better question is if you were to rewrite that portion of GNvim, what would you change?
    I'd really like to start using GNvim again, but those pango issues prevent me from doing so
    Ville Hakulinen
    @vhakulinen
    iirc the problem with pango 1.44 was (is) that we're casting values blindly from floats to integers and that causes some issues. Converting them properly (by ceiling/flooring) should fix the issues.
    smolck
    @smolck
    After just trying the branch, that mostly fixes the issues, but not fully. The right side of the statusline goes off screen, and it also sits higher than it should. Ceiling/flooring the values may fix the artifacts, but it seems to also cause other issues.
    It's strange to me though that Neovim-GTK was fixed (afaik) through rounding, but GNvim wasn't.
    I imagine the drawing's different, but it seems pretty similar. Maybe I could try porting the Neovim-GTK drawing code and see if that fixes the issues. Idk
    Ville Hakulinen
    @vhakulinen
    There probably is just couple spots where the code is doing the flooring and ceiling wrong way around
    or something with double width chars and ceiling/flooring
    but shouldn't be too hard to fix
    smolck
    @smolck
    Hmm okay. Maybe I’ll do some tinkering and see what I can come up with
    Ville Hakulinen
    @vhakulinen
    @smolck I fixed the text going offscreen issue and another related to rendering. Can you test that branch again? It fixed all the issues I could notice on my arch VM.
    smolck
    @smolck
    @vhakulinen Sure! I'll test it rn
    Interesting. It seems to work fine with Hasklig, but Iosevka still has the same issue of the statusline going off screen
    Wait, hold that thought, nvm
    Yeah it seems to work great! Awesome!
    I'm curious, what did you change?
    smolck
    @smolck
    Oh but there is this slight issue with the statusline: Screenshot from 2020-05-14 17-24-37.png
    Ville Hakulinen
    @vhakulinen
    you mean the cmdline? try calling gnvim#set_gui_colors()
    Here are the changes that I did on top of the previous fixes: vhakulinen/gnvim@198d0db
    smolck
    @smolck
    My bad, I didn't pass the path to the runtime dir when I ran it with cargo . . . things work great, thanks!
    Ville Hakulinen
    @vhakulinen
    I merged the fix to master
    smolck
    @smolck
    Great! So glad to have that issue fixed. Now I can maybe get to work on #57.
    Oh btw would you mind reviewing #61 when you get the chance?
    It should be mostly small things that need fixing/tweaking now
    Ville Hakulinen
    @vhakulinen
    I want to fix some problems with unicode/grapheme cluster handling first (which means complete rewrite on the row.rs)
    then, probably need to fix the pending issues with the whole communication stuff (e.g. implement async read/write to nvim process)
    so the little time I have I want to work on those. But I'll keep #61 in my mind if I hit some roadblocks
    smolck
    @smolck
    Okay sounds good!
    Are you planning on porting GNvim to use KillTheMule's rust neovim client?
    I'd like to do that although it'd be a pretty big rewrite I think
    Ville Hakulinen
    @vhakulinen
    haven't checked that status of that in a while, but perhaps. I remember there were some issues with it and glib's async executor implementation
    smolck
    @smolck
    Yeah it might be a bit early still, the APIs unstable atm. See KillTheMule/nvim-rs#1
    But accord. to the README it's usable
    probably best to hold off for now, but in the future I think porting it to that lib is the way to go
    Ville Hakulinen
    @vhakulinen
    the whole async stuff probably is a huge undertaking, but it would allow better communication between gnvim and nvim. Now, for instance the code that checks if any buffers open in a tabpage has unchanged modifications can deadlock.
    smolck
    @smolck
    And if it was async that could be more easily fixed, right?
    Ville Hakulinen
    @vhakulinen
    yea, that wouldn't happen (at least not as easily)
    but I'm not completely sure how massive change that would be to gnvim
    smolck
    @smolck
    I would think it'd be pretty big, although I imagine that a lot of stuff could be simplified along the way
    partizan
    @last-partizan
    image.png

    Hi all :)

    How to change underline color of diagnostic messages reported by coc-nvim? in console nvim it matches text color, but in gnvim underline is red. But red is not applicable to each diagnostic message.

    image.png
    I want it to look like this.
    Ville Hakulinen
    @vhakulinen
    I think its dependent on your color scheme. I'm not sure which hl rule that is tho'
    check :h coc-highlight
    partizan
    @last-partizan
    @vhakulinen yeah, i'm not sure too. Underline is default color in neovim-gtk, neovim, goneovim and fvim. And red only in gnvim and neovide.
    gnvim does not define any special highlight groups?