These are chat archives for go-gitea/gitea

28th
Feb 2017
puffybsd
@puffybsd
Feb 28 2017 01:39
@NormalRa - I worked around the 1073 issue locally by only checking the force push if the oldCommitID != git.EmptySHA. 1077 seems to be a more thorough approach. You could make a similar change or wait for 1077 to be merged.
puffybsd
@puffybsd
Feb 28 2017 03:29

@NormalRa another option would be to apply the patch directly to master as described here. If you have master set up locally as described here, you can grab the pull request and try it out before it's merged:

git fetch upstream pull/1077/head:1077-pr-test
git checkout 1077-pr-test

I stashed my local changes and tried 1077 and it worked for me. [edit: attempt to fix code formatting]

renothing
@renothing
Feb 28 2017 05:18
is it different on protect branchs between gogs and gitea?
Lunny Xiao
@lunny
Feb 28 2017 05:32
Yes. it’s different.
Currently, Gogs’ protected branches have more options than Gitea’s. Maybe someone would like to port it to Gitea.
renothing
@renothing
Feb 28 2017 05:52
gogs development faster than before now after gitea created. I hope both can be merged into only one project someday
camlafit
@camlafit
Feb 28 2017 07:15
@lunny ok I've open issue then :) to wait I'll test workaround with loop and api
Sandro Santilli
@strk
Feb 28 2017 09:30
@renothing: my hope is that @Unknwon would join Gitea as a maintainer
Schwobaland
@Schwobaland
Feb 28 2017 09:56
Can i set a proxy for webhooks? I found settings in httplib - but no config-option...
无闻
@Unknwon
Feb 28 2017 12:26
@strk I can answer questions about existing codebase and design, but no code commitment
Thomas Boerger
@tboerger
Feb 28 2017 12:27
@Unknwon or you follow a development model like gitea and take the team on board :)
无闻
@Unknwon
Feb 28 2017 12:30
I have said many times, it's not a problem to give write access, but I have to be the one approve the merge because I must review every single PR myself
Sandro Santilli
@strk
Feb 28 2017 12:46
Unknwon: I've done that in the past, for other projects. It was much better from a quality control point of view
but it was also great to disappear for 2 years and come back to find a live project :)
not only still in use but also more developed
sure I had to accept some sub-optimal implementations, more bugs than I'd have let slip in and somehwat harder to grok code
but then.. would I have had time to do all that work myself ? no
so I just try to review things as they are committed (even after being pushed to main repo)
and try to build a common methods hoping that others would find it effective :)
无闻
@Unknwon
Feb 28 2017 12:58
@strk lost track of how code evolves is a mess
Sandro Santilli
@strk
Feb 28 2017 13:34
@Unknwon: so is life, did you see how many different species emerged by a single ancestor ? :)
we'll all end up being an indistinguishible mess anyway, due to the third termodynamic law
but trust me: I do appreciate the consistency in a single-maintainer project
Darren Bell
@KangoV
Feb 28 2017 13:41
@strk @Unknwon I'll give you some feedback from what is happening in my company. I have got Gogs/Gitea installed here and our devs love it. BUT! My boss does not like the fact that there are 2 projects. He does not know which one to install long term. I've chosen one, but it could have been either. So, next thing I know there is a meeting invite to discuss migrating to Bitbucket. wtf? His reasoning is that there is too much uncertainty around the two projects. I'm not happy.
If we could join the two projects and have 2/3 people that can merge PR's then those two can resolve between them any abscenses due to holiday.
This does need sorting out. If not i feel it will be bad for both projects.
Oh. Merge and create a new project name.
Sandro Santilli
@strk
Feb 28 2017 14:24
KangoV: I'd tell your boss that the most uncertainty is with with Gogs
to be honest
it's 1 person vs. 10 persons
it's true that the 1-person may be more "attached" to the project, being its own "child"
but your boss could always hire someone to continue Gitea if all of those 10 people disappear
and actually, it'd be a good idea for you to join the team
so you'd have an internal resource keeping an eye on it
alternatively, if you're looking for certainty of service, you should close a contract with a service provider
I've asked @Unknwon for quotes in the past, but he was unavailable
could be easier when there are 10 candidates for startin
and open access to more service providers
@KangoV: ^
Thomas Boerger
@tboerger
Feb 28 2017 14:30
@KangoV feel free to contribute to gitea, we would welcome you on board :)
Darren Bell
@KangoV
Feb 28 2017 14:38
I've created some docker docs so far and PR'd that. I'm just starting to learn Go. I'm from a large ERP, DB background them moved over to Java from c/c++.
Lunny Xiao
@lunny
Feb 28 2017 14:59
I believe @KangoV ’s situation is most company BOSS are thinking. @strk Gitea will not only 10 people, we created a community which will keep Gitea’s development continuously. So if someone leave, many others will join this project like @KangoV . That’s the emphsis. Also we have many maintainers will review contributors’ codes since 1 PR have to be reviewed by more than 2 maintainers review that will let Gitea more stable and higher quality I think.
Sandro Santilli
@strk
Feb 28 2017 15:30
@lunny: true, but right now if the 3 owners disappear all at once there's no way for others to unblock the stall, right ?
I'd prefer if all maintainers could push
leaving the policy to human evaluation
anyway, still much better than in the Gogs case
Lunny Xiao
@lunny
Feb 28 2017 15:32
the 3 owners disappear is almost impossible. if disappear one or two, you can elect new owners ASAP.
Thomas Boerger
@tboerger
Feb 28 2017 15:40
and owners AND team managers can always merge. so currently there are 5 people with full access
Kim "BKC" Carlbäcker
@bkcsoft
Feb 28 2017 15:44
@lunny I wouldn't say "more" stable or "higher" quality, but the chance of equally stable and equal quality is much higher than "let anyone merge" :)
无闻
@Unknwon
Feb 28 2017 15:56
@KangoV it is completely you or your Boss's choice really. I do not encourage/promote people use one or another. My job is to code things in a good state, not marketing my code.
basse baba
@bassebaba_twitter
Feb 28 2017 17:09
Hello. I would like to do a webhook call with a customised payload, is that possible? All I see is either "slack" or "gitea" when adding a hook.
Thomas Boerger
@tboerger
Feb 28 2017 17:29
No custom body yet, but this can be done quite easy with an text/template template
Maybe just extended the current gitea webhook, use the custom body if it's refined
Defined
Please create an tracking issue for that
Sandro Santilli
@strk
Feb 28 2017 17:37
@tboerger: so should I wait for drone to pass before testing your custom template PR ?
oh, I see you answered on the other channel (maybe we should have a single channel after all..)
Kim "BKC" Carlbäcker
@bkcsoft
Feb 28 2017 17:42
@tboerger We should have a custom webhook which uses text/template and pass in the webhook-struct for consumption
Thomas Boerger
@tboerger
Feb 28 2017 17:46
Yeah or a custom one
Kim "BKC" Carlbäcker
@bkcsoft
Feb 28 2017 17:47
right, custom ;)
Thomas Boerger
@tboerger
Feb 28 2017 18:19
Or just extend :D
Kim "BKC" Carlbäcker
@bkcsoft
Feb 28 2017 18:19
Don't like introducing that in GiteaHook :/
Thomas Boerger
@tboerger
Feb 28 2017 18:20
A custom templates for slack also makes sense
Kim "BKC" Carlbäcker
@bkcsoft
Feb 28 2017 18:20
Technically, all of them can be templates... in options/webhooks/{name}.tmpl
Thomas Boerger
@tboerger
Feb 28 2017 18:20
Yeah, true
Kim "BKC" Carlbäcker
@bkcsoft
Feb 28 2017 18:21
So, should I make an issue? :trollface:
Thomas Boerger
@tboerger
Feb 28 2017 18:21
If the other guy have not created one, yes
basse baba
@bassebaba_twitter
Feb 28 2017 18:21
Yeah better you, who knows the stuff :D
Thnx
Kim "BKC" Carlbäcker
@bkcsoft
Feb 28 2017 18:21
;)
basse baba
@bassebaba_twitter
Feb 28 2017 18:22
would it be possible to also be able to specify get/post and headers? (Guess I'm pushing my luck now :D)
Kim "BKC" Carlbäcker
@bkcsoft
Feb 28 2017 18:25
pushing it :trollface:
As long as you provide them in the template-file it COULD be done I guess
nvm, I'll just make it a couple of files :unamused:
Kim "BKC" Carlbäcker
@bkcsoft
Feb 28 2017 18:37
go-gitea/gitea#1089 poof
basse baba
@bassebaba_twitter
Feb 28 2017 18:48
Hehe, hit 'n run :P Tack!
Rajarshi Vaidya aka gmastergreatee
@gmastergreatee
Feb 28 2017 21:20
Should #677 really be closed? Not all the features were implemented.
Kim "BKC" Carlbäcker
@bkcsoft
Feb 28 2017 21:31
Reopened