These are chat archives for go-gitea/gitea

11th
Mar 2017
Starz0r
@Starz0r
Mar 11 2017 01:18
what's the _csrf and i_like_gitea cookie for?
Lunny Xiao
@lunny
Mar 11 2017 01:27
_csrf should be for XSS protection and i_like_gitea should be session track
Starz0r
@Starz0r
Mar 11 2017 01:27
is i_like_gitea stored in the database?
Lunny Xiao
@lunny
Mar 11 2017 01:28
I think no
Starz0r
@Starz0r
Mar 11 2017 01:28
there is also i_like_gogits as a cookie
is it a unused cookie?
Lunny Xiao
@lunny
Mar 11 2017 01:30
maybe that’s only for compatible? or maybe it’s your old Gogs system’s since they have the same domain.
Starz0r
@Starz0r
Mar 11 2017 01:31
I've only ever used Gitea
Gogs has never worked for me
Lunny Xiao
@lunny
Mar 11 2017 01:33
OK. so that should be a compitable design
crocket
@crocket
Mar 11 2017 02:03
I can't start gitea after upgrading it to 1.1.0
I extracted the relevant part from gitea.log
2017/03/11 10:57:57 [I] Log Mode: File(Info)
2017/03/11 10:57:57 [I] XORM Log Mode: File(Info)
2017/03/11 10:57:57 [I] Cache Service Enabled
2017/03/11 10:57:57 [I] Session Service Enabled
2017/03/11 10:57:57 [I] Migration: create repo unit table and add units for all repos
2017/03/11 10:57:57 [...itea/routers/init.go:54 GlobalInit()] [E] Failed to initialize ORM engine: migrate: do migrate: CreateIndexes RepoUnit: index IDX_repo_unit_S already exists
Should I file a new issue on github?
Starz0r
@Starz0r
Mar 11 2017 02:03
they still haven't fixed this?
wtf
yeah file it
Lunny Xiao
@lunny
Mar 11 2017 02:04
No.
Starz0r
@Starz0r
Mar 11 2017 02:04
o
Lunny Xiao
@lunny
Mar 11 2017 02:04
drop repo_unit table
crocket
@crocket
Mar 11 2017 02:04
If I have to manually drop a table, I should file an issue.
Lunny Xiao
@lunny
Mar 11 2017 02:05
And I have sent a PR merged go-gitea/gitea#1194
crocket
@crocket
Mar 11 2017 02:06
It seems gitea release management has an issue, too.
Perhaps, database migration should be tested before release.
Lunny Xiao
@lunny
Mar 11 2017 02:07
You problem is you have upgraded and then downgrade
after that, you upgrade again.
crocket
@crocket
Mar 11 2017 02:08
I didn't downgrade.
Starz0r
@Starz0r
Mar 11 2017 02:08
Is that why this happens?
crocket
@crocket
Mar 11 2017 02:08
I only upgraded.
Starz0r
@Starz0r
Mar 11 2017 02:08
what was your previous version?
crocket
@crocket
Mar 11 2017 02:09
I upgraded from 1.0.2 to 1.1.0
Lunny Xiao
@lunny
Mar 11 2017 02:09
If you haven’t upgraded, there is no repo_unit table before 1.1
Starz0r
@Starz0r
Mar 11 2017 02:09
^ this
I didn't know that until it happened
Lunny Xiao
@lunny
Mar 11 2017 02:09
index IDX_repo_unit_S already exists
crocket
@crocket
Mar 11 2017 02:09
Before gitea 1.0.2, I used gogs.
I fed gogs sqlite3 database to gitea 1.0.2
gogs ??? -> gitea 1.0.2 -> gitea 1.1.0
Lunny Xiao
@lunny
Mar 11 2017 02:10
Oh. maybe it’s reason.
the
crocket
@crocket
Mar 11 2017 02:11
Are you sure your pull request fixes my issue?
I'm asking because I cannot understand your pull request.
Lunny Xiao
@lunny
Mar 11 2017 02:11
we have tested Gogs below 0.9.115
+    if exist, err := sess.IsTableExist(&repoUnit); err != nil {
 +        return fmt.Errorf("IsExist RepoUnit: %v", err)
 +    } else if exist {
 +        return nil
 +    }
 +
crocket
@crocket
Mar 11 2017 02:12
Damn, perhaps I should replace gitea with gitolite and a gitweb client.
At least, gitolite doesn't come with a database.
Starz0r
@Starz0r
Mar 11 2017 02:13
What exactly are you looking for?
crocket
@crocket
Mar 11 2017 02:13
A private git service that I can maintain without hassle.
Migrating app.ini for each upgrade was enough of a hassle.
Lunny Xiao
@lunny
Mar 11 2017 02:14
Migrating app.ini is no need I think.
crocket
@crocket
Mar 11 2017 02:14
@lunny Are you sure dropping repo_unit table should fix my issue for good?
Lunny Xiao
@lunny
Mar 11 2017 02:16
There are some people reported this problem, I just answered again.
My two instances also upgraded from 1.0.2 to 1.1, but I haven’t encounter any problem. My upgrades is very smoothly.
crocket
@crocket
Mar 11 2017 02:19

I ran gitea after dropping repo_unit table. I got the following lines from the log

2017/03/11 11:17:21 [I] Log Mode: File(Info)
2017/03/11 11:17:21 [I] XORM Log Mode: File(Info)
2017/03/11 11:17:21 [I] Cache Service Enabled
2017/03/11 11:17:21 [I] Session Service Enabled
2017/03/11 11:17:21 [I] Migration: create repo unit table and add units for all repos
2017/03/11 11:17:21 [I] Migration: set protect branches updated with created
2017/03/11 11:17:21 [I] Migration: add external login user
2017/03/11 11:17:21 [I] Migration: generate and migrate Git hooks
2017/03/11 11:17:22 [I] Migration: use new avatar path name for security reason
2017/03/11 11:17:22 [I] Migration: rewrite authorized_keys file via new format
2017/03/11 11:17:22 [I] Git Version: 2.12.0
2017/03/11 11:17:22 [I] SQLite3 Supported
2017/03/11 11:17:22 [I] Run Mode: Production
2017/03/11 11:17:22 [I] Listen: http://0.0.0.0:3000

Everything is good?

Lunny Xiao
@lunny
Mar 11 2017 02:20
Yes
:congratulations:
crocket
@crocket
Mar 11 2017 02:20
A kanji character that I may not have recognized a few months ago.
Lunny Xiao
@lunny
Mar 11 2017 02:21
how to post congratulation
here
I just type :congratulation
crocket
@crocket
Mar 11 2017 02:27
:congratulations:
crocket
@crocket
Mar 11 2017 02:33
It seems I lost access to my git repositories over ssh after migrating from gogs to gitea.
Lunny Xiao
@lunny
Mar 11 2017 02:34
rewrite public keys on admin UI
crocket
@crocket
Mar 11 2017 02:34
I just did.
But, sshd wouldn't co-operate with gitea out of the box.
Does gitea run its own ssh server?
Lunny Xiao
@lunny
Mar 11 2017 02:35
It’s the same with Gogs.
default is external SSH server
crocket
@crocket
Mar 11 2017 02:36
How does openssh server work with gitea?
Lunny Xiao
@lunny
Mar 11 2017 02:36
via authorized_keys
Lunny Xiao
@lunny
Mar 11 2017 02:38
Oh. Why so many people use archlinux?
crocket
@crocket
Mar 11 2017 02:40
Because ArchLinux is configurable and offers lots of packages? It also doesn't modify upstream packages unless it's absolutely necessary.
I could install and remove various desktop environments in archlinux, but I cannot do that in other distros.
Other distros come with magic that I don't know about.
But, ArchLinux has its own problems.
I plan to move away from it as soon as I find something better.
Lunny Xiao
@lunny
Mar 11 2017 02:43
Hehe, I have ever used 2 years ubuntu, but after that I used macOS until now. already 5 years.
crocket
@crocket
Mar 11 2017 02:45
Ubuntu makes it impossible to switch desktop environment on the fly.
crocket
@crocket
Mar 11 2017 02:52
Can the repository be a symlink to a directory?
Lunny Xiao
@lunny
Mar 11 2017 02:54
I think it’s not be supported officially.
crocket
@crocket
Mar 11 2017 02:56
I was screwed by a symlink when I used gitlab.
crocket
@crocket
Mar 11 2017 03:20
It seems the repository directory can be a symlink.
Sandro Santilli
@strk
Mar 11 2017 05:50
crocket: gitolite is very nice indeed, I'd go for it
but note I handled to loose access to my repos with gitolite too :)
Sandro Santilli
@strk
Mar 11 2017 08:52
@andreynering: please review go-gitea/gitea#1217
Peter Franken
@pcjmfranken
Mar 11 2017 10:44
Hello, can anyone tell me why my custom labels file is being ignored?
  • Using docker image
  • Data folder link is ok (changes made to app.ini are reflected in container at /data/conf/app.ini)
  • Custom label file located in container at /data/conf/label/CustomLabelFile
  • Container was restarted after placing CustomLabelFile
  • Customised favicon is working
Oh also, I'm running 1.1.0+10-ge2b2fd6e
Lunny Xiao
@lunny
Mar 11 2017 10:48
custom labels should be in custom/options/label/
Peter Franken
@pcjmfranken
Mar 11 2017 11:00
Thanks, you just saved me from half a day of manual input!
Lunny Xiao
@lunny
Mar 11 2017 11:00
I will send a PR to docs to record this.
Steffen
@evilstiefel
Mar 11 2017 11:06
Since LFS is now officially supported, while I installed, there was no installer field for the LFS-path, so it's not part of my app.ini. Is that setting still required or will LFS "just work" after upgrading to 1.1.0?
Lunny Xiao
@lunny
Mar 11 2017 11:07
There is a LFS path on the installation
if you took a fresh install
Steffen
@evilstiefel
Mar 11 2017 11:07
Yes, but not when I did the installation. And since I just upgraded to 1.1.0
I couldn't find a section about it in the config cheat sheet on the documentation page for LFS
Lunny Xiao
@lunny
Mar 11 2017 11:08
If you have upgraded from 1.0.x then you have to change the lfs path on your app.ini
Yes. Docs are late.
I will send a PR to docs to fix this.
Steffen
@evilstiefel
Mar 11 2017 11:09
Thanks :). The docs also talk about different memcached options like reds and the likes, but that is also not part of the installer. Don't know it that is actually officially supported
Lunny Xiao
@lunny
Mar 11 2017 11:09
[server]
LFS_START_SERVER = true
LFS_CONTENT_PATH = data/lfs
LFS_JWT_SECRET   = n6_CQrP3QueJh3KBUi5DJSmir_uHwTtbbjcvwlmXqx0
before that you can use this.
Steffen
@evilstiefel
Mar 11 2017 11:10
*redis is what that line should've read. God sometimes I hate the auto correct of MacOS.
Lunny Xiao
@lunny
Mar 11 2017 11:11
I’m not very familiar with cache part. It seems to be part as a macaron middleware.
Andrew Boyarshin
@andrew-boyarshin
Mar 11 2017 11:28
Is my #186 PR merged into 1.1.0? Haven't found it on the changelog.
Lunny Xiao
@lunny
Mar 11 2017 11:29
yes, merged
Yes. seems lost the feature on changelog. @tboerger
Steffen
@evilstiefel
Mar 11 2017 11:32
Just opened #1221 for lfs, as an enhancement/fix for people using the docker image
Sandro Santilli
@strk
Mar 11 2017 15:01
@lunny: would you please review the OpenID PR ? go-gitea/gitea#618
Lunny Xiao
@lunny
Mar 11 2017 15:02
OK. I will test it tomorrow.
puffybsd
@puffybsd
Mar 11 2017 15:03
anyone have a bug they'd like investigated?
Sandro Santilli
@strk
Mar 11 2017 15:04
puffybsd: you could test go-gitea/gitea#1217
puffybsd
@puffybsd
Mar 11 2017 15:05
thanks - will check it out.
Sandro Santilli
@strk
Mar 11 2017 15:49
have you seen how "expore" is being abused as organization (or user) name ? https://try.gitea.io/explore/repos
is there any code forbidding that or should it be filed ?
PR ready to protect that name too: go-gitea/gitea#1222
it should be checked what happens when those names are used in a LDAP database...
Thomas Boerger
@tboerger
Mar 11 2017 18:45
i_like_gogits had been the name on 1.0.0 of the session cookie
puffybsd
@puffybsd
Mar 11 2017 19:07
@strk - I've done some testing on 1217 for 'issues notification'. Seems to work (emails sent and not sent to change initiator), although I wasn't able to reproduce an issue on master. I'll add more notes on the PR if that's the right place.
puffybsd
@puffybsd
Mar 11 2017 19:13
counts in the gui were strange, but eventually synced. For example, after closing the issue, the open and close counts for the creator/participant were both 0, but correct counts were displayed for the repo owner. Also, some emails were delayed (could be email host or relay).
Starz0r
@Starz0r
Mar 11 2017 20:10
Does Macaron have it's own Sessions middleware?
Sandro Santilli
@strk
Mar 11 2017 20:30
@puffybsd: yes, comments on the PR are the best way ("an issue on master" refers to another issue, right ?)
email delays are probably also independent from Gitea. We might have a similar email delay problem from try.gitea.io btw, I noticed today
Sandro Santilli
@strk
Mar 11 2017 21:18
basically they are moving away from Gogs, but not toward Gitea, rather to something else ("pagure")
Sandro Santilli
@strk
Mar 11 2017 21:24
an interesting comparison table: https://ethercalc.org/choose-the-git-host.html