These are chat archives for googlesamples/android-architecture

4th
Apr 2016
JoseAlcerreca
@JoseAlcerreca
Apr 04 2016 13:01 UTC
Do you guys think we should add a tablet layout to all samples or simply make a new variant like todo-mvp-tablet? A tablet layout was one of the reasons to use fragments so it makes sense everywhere. On the other hand it would make development of new variants harder.
David González
@malmstein
Apr 04 2016 13:01 UTC
I think tablet should be everywhere
otherwise we should remove all the fragment references and add a new one with them
mvp-fragments
David González
@malmstein
Apr 04 2016 13:56 UTC
@JoseAlcerreca what is GitHub showing here?
JoseAlcerreca
@JoseAlcerreca
Apr 04 2016 15:12 UTC
commits, comments, issues...
David González
@malmstein
Apr 04 2016 15:12 UTC
can it show PRs?
it didn’t show my PR nor your comment
JoseAlcerreca
@JoseAlcerreca
Apr 04 2016 15:14 UTC
Pull request Pull request opened, closed, assigned, labeled, or synchronized.
it's enabled...
David González
@malmstein
Apr 04 2016 15:15 UTC
didn’t show up
LIES