@colinbankier If you are part of gotham-rs:gotham-core team on github, then you have access to publishing on crates.io
I implemented IntoHandler for my Result type, but I dont think there is a similar blanket impl for IntoHandlerFuture
gitterbot was kicked by Dominic.
I added this to Gotham, which worked:
impl<T, E> IntoHandlerFuture for ::std::result::Result<T, E>
where
T: IntoHandlerFuture,
E: IntoHandlerFuture {
fn into_handler_future(self) -> Pin<Box<HandlerFuture>> {
match self {
Ok(hf) => hf.into_handler_future(),
Err(hf) => hf.into_handler_future(),
}
}
}However, now I need to impl IntoHandlerFuture for my Error type. That doesnt seem possible as my error doesnt have any state:
impl IntoHandlerFuture for Error {
fn into_handler_future(self) -> Pin<Box<HandlerFuture>> {
// wat do?!
}
}
}
What's currently the "mainline" Gotham way of returning an error?
Ideally I want something like
some_call_returning_result().error_status(StatusCode::BAD_REQUEST)?;but I do understand the explicit by-value state passing is not very compatible with this. Would be mostly ok with something like
some_call_returning_result()
.error_response(StatusCode::BAD_REQUEST, state.take())?;
I don't know your exact use case, but I'd probably suggest creating a wrapper that takes a callback, in which you can use
?, and then have the wrapper take care of the state and returning the (error) response
Yeah, and that's exactly why I have a wrapper that I currently use like this
route.post("/api/bus/raw").to_simple(
|(state, command): (GseState, FormBody<Cmd>)| async move {
let mut state = state.0.lock().expect("propagating panic");
let command: Vec<u8> =
hex::decode(&command.cmd).map_err(|_| ErrorCode(StatusCode::BAD_REQUEST))?;
let reply = block_on(state.scheduler.call(command))
.map_err(|_| ErrorCode(StatusCode::INTERNAL_SERVER_ERROR))?;
state.update_status();
Ok(hex::encode(reply))
},
);
(the
block_on may be redundant now, this was written pre-async and only slightly adapted)
Well, I'm not a maintainer, but I put my api bloat into my own project, in case you are interested: https://gitlab.com/msrd0/gotham-restful
I am working on full framework that implements all the wrappers. You can see here how easy it is to write a route handler. https://github.com/pksunkara/reign/blob/05c2738e8f1cf679331a5a83c4f2e05e837623e0/examples/router/gotham/src/main.rs#L27
which is not possible with functions
I wanted to call attention to #430 - I think the error types would be really useful but I worry about the API change required for middleware
Hi all, is there a way to access path variables via a path extractor in a middleware? I am trying to setup a middleware which accepts or rejects a request based on a path variable matching data within a request header. I cannot figure how to access path variables in middlewares.
@seanpianka I do think this is possible but it might not be straight-forward. What gotham uses to determine whether or not to accept a request for a matcher is called
RouteMatcher and it has access to the state. If (and I'm not sure at this part) the path extractor is run before the route matcher, you could borrow the path parameters inside your matcher and decide whether or not you like the request
With a normal middleware I highly doubt it is run late enough to support what you are trying to do
Hi /@all,
I have compared
Any feedback is :heart:
I have compared
gotham and the other rust frameworks in https://github.com/the-benchmarker/web-frameworks/tree/cloudify#resultsAny feedback is :heart:
Basically I want to play a bit with rust Futures and web development. I think that I need futures 0.3 because there is no sense in learning old 0.1 branch.
So I am thinking that for pet project 0.5 rc branch should be stable enough. What do you think folks? :)
So I am thinking that for pet project 0.5 rc branch should be stable enough. What do you think folks? :)