Where communities thrive

Join over 1.5M+ people
Join over 100K+ communities
Free without limits
Create your own community

Explore more communities

gqlgen/Lobby

General chat for gqlgen

People

Repo info

Activity

21:06

coveralls commented #2322
18:37

dcarbone synchronize #2322
17:43

coveralls commented #2322
17:43

coveralls commented #2322
16:30

dcarbone synchronize #2322
16:28

dcarbone commented #2322
16:20

dcarbone synchronize #2322
16:14

StevenACoffman edited #2322
16:13

StevenACoffman edited #2321
16:13

StevenACoffman edited #2321
16:09

StevenACoffman edited #2321
16:06

coveralls commented #2322
12:54

dcarbone synchronize #2322
Aug 13 05:08

joshpauline opened #2325
Aug 12 16:48

OlivierMary commented #2323
Aug 12 16:47

OlivierMary commented #2323
Aug 12 16:46

OlivierMary opened #2323
Aug 12 14:30

dcarbone synchronize #2322
Aug 12 14:29

dcarbone synchronize #2322
Aug 12 14:27

dcarbone synchronize #2322

Adam Scarr

@vektah

Nice @kejiro , That was my understanding too but reading through the docs I cant find any explicit reference to any of this

https://facebook.github.io/relay/graphql/objectidentification.htm is almost trying to give the wrong impression

Jimmy

@kejiro

@vektah, it does say so in that document:

"This id should be a globally unique identifier for this object, and given just this id, the server should be able to refetch the object."
"If a query returns an object that implements Node, then this root field should refetch the identical object when value returned by the server in the Node‘s id field is passed as the id parameter to the node root field."

It doesn't explicitly say that it needs to identify the type, but it needs to be globally unique, so where would be a better way to put it, and also guarantee global uniqueness, especially if using a regular db and primary keys :)
And, if I recall correctly, that is how the relay package for js does ;)

Adam Scarr

@vektah

yeah, i know but you've got to read between the lines so much to figure out whats going on

Jimmy

@kejiro

well, it is documentation. At least they got lines to read between, compared to other projects :D

Adam Scarr

@vektah

I cant help but feel like thats a dig at the gqlgen docs. Doc writing is hard, its a whole different skillset for sure

and unlike code/tests, they dont break when they fall out of date

Jimmy

@kejiro

:) No, not really, haven't had any major issues with those docs, but a lot of, especially javascript and java, packages it's easier to read the code to see what something does than try to get it from the docs.

But it's true, documentation is not easy, I can't say that I'm very good at it either. But with godoc and it's documentation so close to the code at least it's easier than a completely separate document, even it's not perfect.

Adam Scarr

@vektah

yeah, go is the perfect language for jump-to-definition

which means theres no place better for your docs

Muhammad

@harmnot

did u know why I can't go list ? because my main package was another folder ,

@vektah

@SimplyKnownAsG

Hi I'm looking to use the feature introduced in 99designs/gqlgen#375. I am forced to use a single version of mapstucture (the latest) and it has caused errors in slices_test.go. gqlgen is on an older version, upgrading mapstructure in gqlgen will break the tests. The code asserts Test1 []string and Test3 []*string should resolve to nil and [] respectively. The newer version of mapstructure will return nil for all or [] for all depending on the value of ZeroFields.

Does this test have anything to do with the feature (always use pointers in resolver return types)? Do you know what errors having the different versions might cause?

Adam Scarr

@vektah

375 shouldnt affect that

Adam Scarr

@vektah

with json encoding an empty slice becomes [] and a nil becomes null, gqlgen does some magic on top for fields that are [Foo]!, as null doesnt make sense for them, so they always return [] regardless

as far as inputs go, it doesnt matter, a nil slice is len() == 0

@SimplyKnownAsG

where does gqlgen do something on top for non-null fields? I do not see that in client/client.go

Adam Scarr

@vektah

in the generated code

compare https://github.com/99designs/gqlgen/blob/master/example/todo/generated.go#L2631-L2635
to https://github.com/99designs/gqlgen/blob/master/example/todo/generated.go#L2513-L2514

client is just used for testing

@SimplyKnownAsG

Thanks for that. I'll have to look into it to better understand. in that case, is the error during testing when upgrading mapstructure a false positive?

@SimplyKnownAsG

If I wanted to do a PR to update mapstructure, should I change the test or change the client?

Adam Scarr

@vektah

First I would check that the raw json from gqlgen isn't changing, then make the test work whichever way matches closest to the json representation

My biggest concern is going to be around peoples internal uses of mapstructure, as a version bump (unless they did a major) will also push along all other uses

Ethaniel Rubio

@ethanrubio

i'm trying to understand the dataloaden library and how to best utilize it. i find my users via an external API, so I can query for them directly by userID but in the examples of dataloaden, all the users are loaded in instead. should I be following this pattern using this external API? it allows for searching of all users in a similar manner, but that seems a little weird to me when I just want to cache the api response so that it can be reused in child resolvers similar to how it's done here https://graphql.org/blog/rest-api-graphql-wrapper/.

Adam Scarr

@vektah

That's one of the jobs of the dataloader, it's assuming that a batch fetch I'd much cheaper. If your API can't do batch your probably better off with a simple cache instead

Sven Roeterdink

@swennemans

Is there any documentation/examples about logging? I'm trying to log both graphql errors but also server errors (for example: database errors). Or is the default using the ApolloTracer?

Alireza Salary M.N

@arsmn

Is it possible to access field collection for input object?

Kirill Tatchihin

@rbUUbr

hi there! I want to measure time duration for each field's resolving. Is there some builtin ways to do it?

Adam Scarr

@vektah

@swennemans take a look at AroundFields on the handler - https://gqlgen.com/recipes/migration-0.11/

@rbUUbr same to you

@arsmn no, inputs dont get collected. thats part of the response (output type, not input type) handling - see http://spec.graphql.org/June2018/#sec-Field-Collection

Kirill Tatchihin

@rbUUbr

@vektah great, thanks! updated version, really great updates, now handler looks pretty and without a lot of methods

Julien

@juleur

hi all, does something change about errors since 0.11 ? I cant return Extensions custom errors anymore

Bhaskar Saraogi

@bhaskarsaraogi_twitter

Hi, trying to find how to define a custom JSON scalar in gqlgen(something on the lines of, https://github.com/taion/graphql-type-json) ?

scalar Map doesnt work exactly, becuase marshalling primitve json like 0 or "some string" fails

Adam Scarr

@vektah

@bhaskarsaraogi_twitter are you looking for Any?

@juleur lots of things changed, if you have a more concrete example I can take a look

Julien

@juleur

@vektah before 0.11, I could return error like this https://github.com/juleur/ecrpe-gql/blob/2889a7a4072d205c0bea2329db49c5c2355bf9c5/resolver.go#L46

now, its returning the message only (extensions are left out)

Julien

@juleur

Andreas Backx

@AndreasBackx

Does anyone know whether the context from the federated gateway is propagated in gqlgen? I cannot find any documentation on it and following what a request goes through is a bit hard. https://www.apollographql.com/docs/apollo-server/federation/implementing/#sharing-context-across-services

Andreas Backx

@AndreasBackx

Oh wow, I looked straight over the fact that you need to do that manually. My apologies.

sateeshpnv

@sateeshpnv

Any suggestions on splitting generated.go into smaller files? I have a repo with a 256kB size restriction per file.

sateeshpnv

@sateeshpnv

Any suggestions on splitting generated.go into smaller files? I have a repo with a 256kB size restriction per file.

Render() function at https://github.com/99designs/gqlgen/blob/master/codegen/templates/templates.go#L61 looked like the code that can be refactored to split a single generated.go into multiple files. However, looking at a generated.go file for one query, biggest region is field.topl and this region alone can cross 256KB.

1: 21 // region ** generated!.gotpl **
2: 1666 // region * args.gotpl *
3: 1726 // region ** directives.gotpl **
4: 1730 // region ** field.gotpl *
5: 7009 // region ** input.gotpl *
6: 7031 // region ** interface.gotpl *
7: 7035 // region ** object.gotpl **
8: 8348 // region * type.gotpl *

Goran Popovic

@gpopovic

Hey guys..Is it possible to pass somehow through context from parent resolver to child? generated model is passed, but i would like to pass something else

an example viewer pattern... i would like all resolvers that are generated on top of viewer to have (full internal user) available

Jon Lundy

@JonLundy

so .. you want the user for the current request to be passed along?

Chat via Matrix