Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Oct 20 18:34
    JosephGoulden synchronize #3096
  • Oct 20 18:11
    JosephGoulden synchronize #3096
  • Oct 20 18:01
    JosephGoulden opened #3096
  • Oct 19 13:05
    marekyggdrasil commented #2995
  • Oct 19 11:13
    marekyggdrasil commented #2995
  • Oct 19 11:11
    marekyggdrasil commented #2995
  • Oct 19 11:09
    marekyggdrasil commented #2995
  • Oct 18 07:29
    JosephGoulden commented #3084
  • Oct 17 13:17

    quentinlesceller on master

    mmr simplified Chinese translat… (compare)

  • Oct 17 13:17
    quentinlesceller closed #3095
  • Oct 17 13:17
    quentinlesceller commented #3095
  • Oct 17 10:34
    AurevoirXavier synchronize #3095
  • Oct 17 02:42
    AurevoirXavier commented #3095
  • Oct 17 02:39
    AurevoirXavier synchronize #3095
  • Oct 16 21:14
    JosephGoulden synchronize #3064
  • Oct 16 19:54
    JosephGoulden synchronize #3064
  • Oct 16 15:52
    quentinlesceller synchronize #3094
  • Oct 16 15:04

    quentinlesceller on master

    [DOC] Update japanese translati… (compare)

  • Oct 16 15:04
    quentinlesceller closed #3020
  • Oct 16 15:03
    quentinlesceller commented #3095
Ignotus Peverell
@ignopeverell
@tromp that's a bit subtle
jaspervdm
@jaspervdm
oh btw @ignopeverell when you have time, could you have a quick look at mimblewimble/grin#2007 (and corresponding PRs on the secp repo's)? i tested it, and sending/receiving/restore works fine
Ignotus Peverell
@ignopeverell
@tromp so you're not proposing to directly increase the min, but rather increase the base by one per year, correct?
@jaspervdm will do
jaspervdm
@jaspervdm
thx
Ignotus Peverell
@ignopeverell
@jaspervdm commented regarding backward compatibility
jaspervdm
@jaspervdm
@ignopeverell thanks, but what would the purpose be of this marker?
Ignotus Peverell
@ignopeverell
you need to differentiate outputs that have been built using the non-switch commitments from the switch ones to be able to spend them right?
Yeastplume
@yeastplume
sorry I need to look at it in a detail, will do soon
jaspervdm
@jaspervdm
ah right so it should be on the outputs instead of the txlog. i can try to add it, but is it something we need? wouldnt it be easier to have a wallet config option or something (which we remove for mainnet)?
Ignotus Peverell
@ignopeverell
I believe the txlog will tell you which outputs are yours, but it could also be an all or nothing
actually if it's easy enough, we could enable it on all new wallets automatically
jaspervdm
@jaspervdm
if we dont care about existing wallets, we can merge as-is (after some more testing) :p
im trying to think of an easy way to still have some backwards compatibility
Ignotus Peverell
@ignopeverell
I have a feeling people do care about their existing wallets
might be good to have this as a config anyway, and set it to false by default for T4
Yeastplume
@yeastplume
yes, I’ve been taking great care not to break existing wallets
jaspervdm
@jaspervdm
ok i will try to add it to the config
will take me a bit, not that good at Rust yet
but at least ive finally started working with it :)
Ignotus Peverell
@ignopeverell
exactly, good opportunity to practice
Yeastplume
@yeastplume
yup, definitely worth learning
jaspervdm
@jaspervdm
but i think we should remove the option for mainnet, because changing it will break your wallet if you have existing funds in it
Ignotus Peverell
@ignopeverell
we can make the wallet crash loudly if it's enabled in mainnet
David Burkett
@DavidBurkett
Yes, as @ignopeverell mentioned earlier, I'm working on a C++ implementation that's focused on supporting windows. I'll probably make the code public in ~2 weeks, but it should be fully ready for mainnet (without mining) just in case the rust version isnt windows-compatible yet.
Ignotus Peverell
@ignopeverell
@DavidBurkett didn't mean to out you, hope mentioning it was ok

it should be fully ready for mainnet

if you don't too sidetracked by kernel sync that is ;-)

David Burkett
@DavidBurkett
Not a problem. It's not intended to be a secret.
Haha true. The kernel sync thing has been helpful for me to learn rust and to better understand the implementation, though. I promise I'll finish both :smile:
hashmap
@hashmap
@tromp what method do you use to find cycles? I mean the method name which I can google. As I understand you immediately check for cycles (of limited length?) for each added edge? I implemented straightforward DFS which pass the entire graph once and it’s slower than your finder (67ms vs 92ms)
John Tromp
@tromp
that's pretty similar. such a small difference cld easily be explained by low level optimizations
@ignopeverell no, i'm not proposing to increase BASE_EDGE_BITS
Ignotus Peverell
@ignopeverell
@tromp but you do mean increasing it as it's used in the graph weight calc, right?
John Tromp
@tromp
i'm proposing to encode the size increase and phase out schedule in function graph_weight
making it dependent on height
Ignotus Peverell
@ignopeverell
so... weights don't change but the function returns some error?
John Tromp
@tromp
graph weight changes over time
Ignotus Peverell
@ignopeverell
okay, that's what I thought you meant
John Tromp
@tromp
for 31, it starts out at 256 * 31
Ignotus Peverell
@ignopeverell
so here instead of base_edge_bits we use a value that increases each year:
https://github.com/mimblewimble/grin/blob/master/core/src/consensus.rs#L168
John Tromp
@tromp
we dont change the base, we change the latter factor
decreasing once a week during phase out for instance
so cuckatoo31 would be phased out over 31 weeks
Ignotus Peverell
@ignopeverell
so it's zero when phased out?
John Tromp
@tromp
indeed
Ignotus Peverell
@ignopeverell
resulting in a constant block-difficulty of 1?
John Tromp
@tromp
resulting in a pow difficulty of 0
so failing any diff threshold test
Ignotus Peverell
@ignopeverell
yes, was just looking at the code to see what would happen then, will just have to be careful it doesn't crash as there are a couple places we don't want a difficulty of 0 to appear
Quentin Le Sceller
@quentinlesceller
@DavidBurkett that's great!