Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 17:35
    antiochp edited #3268
  • Apr 03 15:38
    lehnberg edited #3288
  • Apr 03 15:37
    antiochp edited #3288
  • Apr 03 13:19
    jaspervdm closed #3290
  • Apr 03 10:44
    antiochp commented #3290
  • Apr 03 10:42
    antiochp commented #3290
  • Apr 03 10:41
    antiochp commented #3290
  • Apr 03 05:21
    HatemAMA opened #3290
  • Apr 02 21:15
    lehnberg labeled #3289
  • Apr 02 21:14
    lehnberg labeled #3288
  • Apr 02 21:14
    lehnberg labeled #3286
  • Apr 02 21:09
    lehnberg milestoned #3289
  • Apr 02 21:09
    lehnberg labeled #3289
  • Apr 02 21:09
    lehnberg assigned #3289
  • Apr 02 21:09
    lehnberg labeled #3289
  • Apr 02 21:09
    lehnberg opened #3289
  • Apr 02 21:07
    lehnberg opened #3288
  • Apr 02 21:06
    lehnberg milestoned #3288
  • Apr 02 21:06
    lehnberg labeled #3288
  • Apr 02 21:06
    lehnberg labeled #3288
lehnberg
@lehnberg
I mean...
we're meant to cut a release candidate in three days?
or is that timeline changing?
Antioch Peverell
@antiochp
24 hours of beta.2 or something
Yeastplume
@yeastplume
It's dependent on the sync issues for the most part, the other stuff is minor and can really wait if needed
what's a 'release candidate'?
Antioch Peverell
@antiochp
some eyes on mimblewimble/grin#3164 and mimblewimble/grin#3165 would be good to get the sync issues hopefully resolved
Yeastplume
@yeastplume
I mean, we don't do special RC builds, if it turns out everyone is happy with beta.2 that's the release candidiate
lehnberg
@lehnberg
Release Candidate is like "this is a version we think is good enough for final"
Yeastplume
@yeastplume
I meant in our context
Antioch Peverell
@antiochp
yes I guess the assumption here is beta.2 is the RC (pending anything unexpected)
lehnberg
@lehnberg
And then it's out in the wild until our assumption is proven right
Yeastplume
@yeastplume
Yes, I'm okay with the assumption beta.2 is the RC, until someone demonstrates any reasons why it shouldn't be
Antioch Peverell
@antiochp
beta.1 is the RC currently given the fact we are doing a release for HF2
lehnberg
@lehnberg
oh I see. yeah I mean, generally, if you're doing bug fixes and release, there's a good chance you might get a release candidate if there's no regression
but if you add new functionality and release, you might get a release candidate, or you might get a list of bug fixes that you need to do
Antioch Peverell
@antiochp
yes absolutely - last thing we want to do right now is add to the list of outstanding bugs
Yeastplume
@yeastplume
Okay, so happy with saying no to new features as well
and just including any needed sync fixes
lehnberg
@lehnberg
I feel it's up to you guys as devs to agree on. I'm skeptical myself, but don't feel I've got a horse in the race
my opinions are as per the comment in the thread
https://github.com/mimblewimble/grin/pull/3161#issuecomment-563217208
Antioch Peverell
@antiochp
I'm going to test the TUI changes though locally - they are limited enough in scope I think and give some tangible benefits (no new features)
one fixes a known panic in the tui for example
Yeastplume
@yeastplume
Okay, look let's leave it at that then.
lehnberg
@lehnberg
but I'm not the one that's at risk of being stuck doing last minute troubleshooting & bug fixes over the holidays
Yeastplume
@yeastplume
And on the stuff I'm looking at I'm happy to have at least one definite feature add for 3.0.1
Antioch Peverell
@antiochp
all that said - the TUI is usable right now, so I'm not entirely convinced by my own argument here
Yeastplume
@yeastplume
heh
lehnberg
@lehnberg
I used to be liberal with these things, but a couple of years of releasing turned me into ultra-conservative
Yeastplume
@yeastplume
... okay... Sync fixes + TUI fixes, since they're fixes they make sense to put in
lehnberg
@lehnberg
as I've heard enough "and you won't believe what happened next" war stories
Yeastplume
@yeastplume
and no new features. Yes, I was bitten by 'just a small change' as recently as the 2.1.0 release as well
Antioch Peverell
@antiochp
sync stuff should be fixed if we can wing it though - we've seen enough "locked up sync at step 6/7" for it to be an issue across a large number of nodes
lehnberg
@lehnberg

sync stuff should be fixed if we can wing it though

agree

Antioch Peverell
@antiochp
I just ran 3 successful sync in a row though with a combination of the two PRs up, so I think we have a fix with relatively minor changes involved
Yeastplume
@yeastplume
Okay, so think we're agreed here? Sync fixes necessary, TUI up to @antiochp 's judgement, nothing else?
lehnberg
@lehnberg
and beta2 is the working assumption release candidate?
Antioch Peverell
@antiochp
yes
lehnberg
@lehnberg
ie if all goes well and the roof does not blow up, that's the one
Yeastplume
@yeastplume
:+1:
lehnberg
@lehnberg
🚀
Yeastplume
@yeastplume
And we can branch when it's built
lehnberg
@lehnberg
ah right... for >3.0.0?
Yeastplume
@yeastplume
yes
lehnberg
@lehnberg
sounds good to me
Yeastplume
@yeastplume
already need a place to throw the stuff I'm working on into post 3.0.0, sure others are the same
lehnberg
@lehnberg
do we still believe beta2 could be Thursday?
Antioch Peverell
@antiochp
only node changes for beta.2 or is there wallet changes also?
I'd like to aim for end of day today for the node changes (not necessarily to build beta.2 but just to have them merged in)
Yeastplume
@yeastplume
so aiming for Thursday okay?