Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Oct 21 10:23

    grkek on master

    Refactor redirect helper methon… Merge pull request #45 from cya… (compare)

  • Oct 21 10:23
    grkek closed #45
  • Oct 20 20:58
    cyangle opened #45
  • Oct 07 03:17

    grkek on v1.0.5

    (compare)

  • Oct 07 03:17

    grkek on master

    Update shard.yml (compare)

  • Oct 07 03:15
    grkek closed #43
  • Oct 07 03:15

    grkek on master

    Add method to read cookie Merge pull request #43 from tre… (compare)

  • Oct 07 03:15

    grkek on master

    Add redirect to context Merge pull request #44 from tre… (compare)

  • Oct 07 03:15
    grkek closed #44
  • Oct 05 20:40
    treagod opened #44
  • Oct 05 20:35
    treagod opened #43
  • Aug 31 19:14
    RonanzinDev closed #42
  • Aug 31 05:27
    grkek commented #42
  • Aug 30 19:11
    RonanzinDev opened #42
  • Aug 28 13:47

    grkek on master

    added static i forgor :skull: Update shard.yml and 6 more (compare)

  • Aug 28 13:47
    grkek closed #41
  • Aug 28 01:34
    grkek commented #41
  • Aug 28 01:33
    grkek review_requested #41
  • Aug 27 23:56
    acoolstraw commented #41
  • Aug 27 23:55
    acoolstraw commented #41
Ghost
@ghost~5a5bc22cd73408ce4f8836a6
yeah that's not good
Giorgi Kavrelishvili
@grkek
Why?
Ghost
@ghost~5a5bc22cd73408ce4f8836a6
The binary will be different, bugs could be introduced
Giorgi Kavrelishvili
@grkek
I don't want to include tons of messages in the code
What bugs?
What kind of bugs
?*
Ghost
@ghost~5a5bc22cd73408ce4f8836a6
Because of LLVM, we never know. Like with crystal --release and without
Giorgi Kavrelishvili
@grkek
Ah that is not a problem for the framework tbh
Ghost
@ghost~5a5bc22cd73408ce4f8836a6
they are bugs in release and none without
Giorgi Kavrelishvili
@grkek
I mean how can there be a bug in release if there is not one in the debug version?
Ghost
@ghost~5a5bc22cd73408ce4f8836a6
Could be, macros can produce buggy code
Giorgi Kavrelishvili
@grkek
Incorrect
that is the error of the programming language not the framework
Ghost
@ghost~5a5bc22cd73408ce4f8836a6
that's not important for the user
anyway
both debug and prod can be tested
Giorgi Kavrelishvili
@grkek
They can use Kemal
Ghost
@ghost~5a5bc22cd73408ce4f8836a6
at the end
Giorgi Kavrelishvili
@grkek
:P
Giorgi Kavrelishvili
@grkek
v1.1.2 supports multiple applications in a single codebase
and it has been released approx. 25 minutes ago.
Giorgi Kavrelishvili
@grkek
so @j8r what do you think is Grip coming into shape or nah?
Ghost
@ghost~5a5bc22cd73408ce4f8836a6
hum yeah
Giorgi Kavrelishvili
@grkek
Thank you mate ;) <3
Giorgi Kavrelishvili
@grkek
I am working on an experimental routing with the override and via keywords
class Application < Tenacious::Application
  def routes
    pipeline :api, [
      PoweredByHeader.new,
    ]

    scope "/api/v1" do
      pipe_through :api

      get "/user", HttpController
    end

    scope "/api/v2" do
      get "/resu", HttpController
    end
  end
end
The pipe_through part does the via keyword for all of the routes defined in the scope
Tenacious is just an example test suite for my new ideas since grip is a bit painful to experiment with, I plan on rebuilding it a bit later
The macros are extremely large for the size being at the moment it shouldn't be that large + I can do some refactoring
Giorgi Kavrelishvili
@grkek
class Application < Tenacious::Application
  def routes
    pipeline :api, [
      PoweredByHeader.new,
    ]

    scope "/api/v1" do
      pipe_through :api

      get "/user", HttpController, as: :index
    end

    scope "/api/v2" do
      get "/resu", HttpController
    end
  end
end
Fully cloned the Phoenix framework routing mechanism
Giorgi Kavrelishvili
@grkek
What do you think, was it a good idea to remove the Filter handler? @j8r
Ghost
@ghost~5a5bc22cd73408ce4f8836a6
I guess so
better avoiding being able to achieve the same thing in two ways
Giorgi Kavrelishvili
@grkek
Yeah, plus that it can hijack every request it wants which is something I don't like
Marwan Rabbâa
@waghanza
I see that https://github.com/grip-framework/grip/releases does not exists anymore. Is it a fresh start (I see a 1.0.0 version)
Giorgi Kavrelishvili
@grkek
Yes it is a fresh start
I wanted to squash down all of the crap that pilled up over the development time
it is quite hard to maintain all other versions so no more issue with that
plus I want to celebrate 1.0 with releasing 1.0 now instead of releasing 5.0
thank you for your attention
Marwan Rabbâa
@waghanza
:tada:
Marwan Rabbâa
@waghanza
however, is there any commit that I can use for https://github.com/the-benchmarker/web-frameworks (still with 0.36)
?
Giorgi Kavrelishvili
@grkek
Why do you want 0.36?
Why not 1.0.0
Marwan Rabbâa
@waghanza
all crystal framework are in 0.36.0
their is a PR for crystal v1, but for our sake having one version for all is better (so we have to wait for amber ...)
I can either dismiss grip (until crystal v1 is OK) or use a commit hash