Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Sep 02 01:11
    kvark commented #153
  • Sep 01 01:28

    grovesNL on master

    Create FUNDING.yml (compare)

  • Sep 01 01:21
    grovesNL commented #153
  • Sep 01 01:21
    grovesNL labeled #153
  • Sep 01 01:21
    grovesNL labeled #153
  • Aug 31 14:40
    kvark opened #153
  • Aug 31 11:30

    grovesNL on release-0.21.0

    (compare)

  • Aug 31 11:24
    bors[bot] closed #152
  • Aug 31 11:24
    bors[bot] commented #152
  • Aug 31 11:24

    bors[bot] on master

    Publish 0.21 Merge #152 152: Publish 0.21 r… (compare)

  • Aug 31 11:04

    bors[bot] on staging.tmp

    (compare)

  • Aug 31 11:04

    bors[bot] on staging

    Publish 0.21 Merge #152 152: Publish 0.21 r… (compare)

  • Aug 31 11:04

    bors[bot] on staging.tmp

    Publish 0.21 [ci skip][skip ci][skip netlify… (compare)

  • Aug 31 11:04

    bors[bot] on staging.tmp

    [ci skip][skip ci][skip netlify] (compare)

  • Aug 31 11:04
    grovesNL commented #152
  • Aug 31 11:04
    grovesNL opened #152
  • Aug 31 11:03

    grovesNL on release-0.21.0

    Publish 0.21 (compare)

  • Aug 30 15:15
    bors[bot] closed #151
  • Aug 30 15:15
    bors[bot] closed #149
  • Aug 30 15:15
    bors[bot] closed #149
Josh Groves
@grovesNL
@msiglreith hey, I created this room so we can discuss in here rather than having to message through gfx-rs
Is there anything I can help with for the hlsl changes you're working on? I don't want to accidentally overlap with your changes
msiglreith
@msiglreith
Hlsl stuff should be done for now. I only added getShaderResources. Probably relevant for the future is splitting of combined images but I havent looked into the api provided
Josh Groves
@grovesNL
alright, perfect
Josh Groves
@grovesNL
I also want to find a way to improve the error handling in the future, maybe we could have separate error enums for ReflectionError/ParseError/CompileError
msiglreith
@msiglreith
We might also want to add a few noexcept into the C++ source where possible. get_shader_resources or get_entry_points shouldn't return a Result imo.
Josh Groves
@grovesNL
yeah, unless SPIRV-Cross does something really strange we should be fine for most get*
Alexandre Bléron
@ennis
hi, is there a way to get back SPIR-V bytecode after modification through spirv::Ast?
actually I can't find a way to do that in the original SPIRV-cross
my use case is modifying vulkan SPIR-V bytecode so that it's usable with the GL flavor of SPIR-V in OpenGL 4.6
i wanted to avoid the round trip GLSL -> SPIRV -> GLSL again -> driver
Josh Groves
@grovesNL
@ennis Hey, unfortunately I don't think so. I think most of the changes for GL are emitted directly into GLSL, not SPIR-V, so it's too late at that point to get SPIR-V output again
There are some project like rspirv (https://github.com/google/rspirv) that might work better if you want to do the transformation yourself