by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Christian Strand Young
    @lizter
    I tried passing e.g "defaultCommandPatches: ['indent']" when creating the scribe instance. The patch should get rid of the inline styles on the <blockquote> when indenting two times in Chrome, but it doesn't.
    Jon Parsons
    @cutandpastey
    @lizter intersting, do you have time to setup a limited test case on jsfiddle or something?
    Christian Strand Young
    @lizter
    @cutandpastey Not today, I can try to fit in some time tomorrow and see if I can reproduce it.
    For now I used the sanitizer plugin as we can't allow style tags anyways. I haven't looked through what all the patches do, but I am guessing I want to include them for cross browser fixes?
    Christian Strand Young
    @lizter
    Jon Parsons
    @cutandpastey
    @lizter thanks, ill take a look.
    Christian Strand Young
    @lizter
    @cutandpastey Have you had the chance to review the code?
    Christian Strand Young
    @lizter
    Just disregard the "set content" stuff. I snatched an existing jsfiddle and just modified it.
    Christian Strand Young
    @lizter
    Say I want to have a lead paragraph in my text. What would be the best way to apply a class to a <p> in Scribe? I want to be able to press return and a new clean paragraph without a class should appear.
    Robert Rees
    @rrees
    I'm not sure what the best way to decide what a lead paragraph is but if you look at the code for the Blockquote plugin I think it has a similar structure to what you want to do. https://github.com/guardian/scribe-plugin-blockquote-command/blob/master/src/scribe-plugin-blockquote-command.js
    Katy Moe
    @kmoe
    Hey guys! Do you know of any forks of scribe adapted for a React/Flux architecture?
    Hugo Gibson
    @hmgibson23
    not off the top of my head
    Katy Moe
    @kmoe
    In that case, you may see one appearing in the next few weeks… :)
    Fabio Crisci
    @piuccio
    @kmoe that'll be great news!
    Katy Moe
    @kmoe
    Unfortunately, however, I failed to check before I started my POC whether scribe worked on IE - I don’t suppose you know of any forks that do? I’m not sure how quickly we can solve both issues...
    Fabio Crisci
    @piuccio
    oddly enough someone else asked that same question today in a different context
    no, it doesn't work on IE and we're not extremely interested in making it work
    PR would be great, but I haven't seen any...
    Katy Moe
    @kmoe
    Yeah, I’ve read the GitHub issues, where you guys state that you’re not interested in PRs that change the fundamental architecture in order to make it work in IE, so I was just wondering if you knew of any forks that do change the fundamental architecture to make it work with IE
    but it sounds like there aren’t any
    Fabio Crisci
    @piuccio
    nope
    Christian Strand Young
    @lizter
    It could say explicitly on the front README of github that it doesn't support IE. We wrongly assumed it did and had to scrap the whole thing.
    Katy Moe
    @kmoe
    It says in the README what browsers it’s tested on. I think with contentEditable stuff it’s dangerous to assume it will support IE.
    However, that’s what I did for a couple of hours while trying it out… :smile:
    Katy Moe
    @kmoe
    Oh, but sir trevor is based on scribe and seems to work on IE10+...
    Katy Moe
    @kmoe
    Ah, my mistake, it only worked on IE before it started using scribe
    ignore the above
    hackerman
    @aeneasr
    hey I'm really trying to get scribe work with browserify
    I added deamdify to the transform list:
        var bundler = browserify({
                entries: ['./src/app/app.js'],
                transform: ['babelify'],
                debug: true,
                cache: {},
                packageCache: {},
                paths: ['./src/'],
                fullPaths: true
            }).transform(require('browserify-css'), {
                rootDir: './src'
            }).transform('deamdify', {global: true}),
            watcher = watchify(bundler);
    and everything seems to be working except that I get: TypeError: rootDoc is undefined
    oh okay it always helps to talk about things haha, i passed querySelectorAll not knowing that scirbe accepts only one element, not an array of elements
    Fabio Crisci
    @piuccio
    :wink:
    hackerman
    @aeneasr
    when e.g. an image or a iframe (youtube) is given, it flickers everytime a new paragraph is added - is the some plugin which supports diffing so only nodes requiring updates are updated?
    Laurence Dorman
    @laurencedorman
    hello all, I just stumbled across this http://blog.procoder.io/guardians-scribe-editor-in-reactjs/ - so scribe is es6 compatible??
    This message was deleted
    veganista
    @veganista
      /**
       * Example validation functions
       */
      function linkValidator(url) {
          if(/dailymail/.test(url)) {
            return {
              valid: false,
              message: "I'm afraid I can't let you link to that Dave..."
            }
          }
    
          return {
            valid: true
          };
      }
    Ha!
    Robert Rees
    @rrees
    @ld0rman yes in the sense that it's ES5 which you can import into and ES6 environment. I guess when browser support is stronger we will have to decide when we're going to switch.
    Chris Monkman
    @SgtOddball
    So any ideas on when they'll be some more formal documentation? Especially in relation to making plug-ins (here's a template, figure it out does not a document make)
    Robert Rees
    @rrees
    @SgtOddball hey, we don't have any driver to improve the documentation at the moment. There are a bunch of real examples actually in the Scribe codebase as well as the list of separate projects. What kind of thing would you find helpful? A kind of step-by-step blog-post? What kind of change would be helpful to illustrate?
    Chris Monkman
    @SgtOddball
    @rrees A step by step would be helpful, even just a run down of the stand calls and how to apply them would be good. (if I'm brutally honest it's more because I don't have the time to figure it all out from scratch, lazy of me I know but I've got enough going on that I'd rather have something to reference to than trying to figure it out from scratch)
    Alex Tharp
    @toastercup
    Hallo, friends! Just curious if anyone is aware of any plugins or uses in the wild of Scribe as an "in-line editor" - a la CKEditor's (poor) inline functionality: http://sdk.ckeditor.com/samples/inline.html Thanks in advance!
    Obviously Scribe would be easy enough to rig up as such, just curious before I get started :)
    Chris Monkman
    @SgtOddball
    @toastercup Have you see the Sir Trevor project? Thats pretty much how they have it setup. http://madebymany.github.io/sir-trevor-js/example.html to have a nosy, there's also quite the community around adding new features, bug checking and generally making the whole thing better.
    Gregg
    @gmeluski
    QQ: any idea what's going on with the "build failing" message on the NPM repo? was eager to take it out for a test drive
    as in, is the failure a blocker to installing
    Robert Rees
    @rrees
    @gmeluski Around about Chrome 35 something has changed which means our current full test suite has become very erratic. The functionality and behaviour is the same and it all works but something in the combination of browser, SauceLabs and Selenium is now failing. I don't know how to sort it out reliably without reimplementing the tests, help would be welcome. If we can't sort out the situation soon we might have to consider skipping all non-unit tests.
    Gregg
    @gmeluski
    ah interesting, thanks for the info @rrees
    Samuel Allen
    @dehuszar
    Is Scribe still Chrome and Firefox only?
    Karthik Jayakumar
    @KarthikJay
    Any chance there's a guide around for how to get the example up and running?
    for scribe that is