Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 04:40
    blast-hardcheese opened #1386
  • Jan 25 20:22
    codecov[bot] commented #1384
  • Jan 25 20:16
    github-actions[bot] labeled #1384
  • Jan 25 20:16
    github-actions[bot] labeled #1385
  • Jan 25 20:12
    codecov[bot] commented #1385
  • Jan 25 20:12
    codecov[bot] commented #1385
  • Jan 25 20:11
    codecov[bot] commented #1385
  • Jan 25 20:11
    codecov[bot] commented #1385
  • Jan 25 20:11
    codecov[bot] commented #1385
  • Jan 25 20:10
    codecov[bot] commented #1385
  • Jan 25 20:10
    codecov[bot] commented #1385
  • Jan 25 19:54
    scala-steward opened #1385
  • Jan 25 19:54
    scala-steward opened #1384
  • Jan 25 14:29
    codecov[bot] commented #1383
  • Jan 25 14:28
    codecov[bot] commented #1383
  • Jan 25 14:28
    codecov[bot] commented #1383
  • Jan 25 14:27
    codecov[bot] commented #1383
  • Jan 25 14:12
    github-actions[bot] labeled #1383
  • Jan 25 14:10
    scala-steward closed #1382
  • Jan 25 14:10
    scala-steward commented #1382
Shanan Sussman
@myfancypants
oh yeah, we've definitely just been excluding it in other systems
<arg>-Xlint:-unused,_</arg>
blast_hardcheese
@blast_hardcheese:matrix.org
[m]
boom
The -Wconf:src=... option would be preferred, as it would only exclude unused in generated sources
what guardrail may be able to do is automatically add an explicit -Wconf:src, since we actually know exactly which directories we generated into
that would certainly improve usability
Shanan Sussman
@myfancypants
that sounds ideal, since preventing unused imports within application code is something i'd like to keep
blast_hardcheese
@blast_hardcheese:matrix.org
[m]
certainly. I can't look at this right now, as my time is allocated towards the modularization proposal, ramping up to the 1.x release, but if you want to test swapping that -Xlint:-unused,_ for -Wconf:src:..., that would be a step in the right direction
Shanan Sussman
@myfancypants
might have to come back to that, looks like it was added in 2.13, might need to just get the system to build + bake, before i take the step of upgrading scala versions. The changes are already including bumping from java 8 to 11
blast_hardcheese
@blast_hardcheese:matrix.org
[m]
oh, please disregard then, I didn't realize it was so new
it may not end up being worth it at all anyway, as a lot of warnings were removed in dotty (much to my displeasure)
it'll be interesting to see how things shake out as people start moving production systems to dotty
Shanan Sussman
@myfancypants
is dotty the same as 3.0 or a different fork of scala? I can never remember
blast_hardcheese
@blast_hardcheese:matrix.org
[m]
Yeah, dotty became 3.0
I should start just saying 3.0
Shanan Sussman
@myfancypants
:pewpew:
blast_hardcheese
@blast_hardcheese:matrix.org
[m]
There are only two other forks of Scala I know of, the typelevel fork as well as a paid super optimized one with some kind of other really cool features
the fragmentation all comes from how many different major/minor revisions people are using 😕
blast_hardcheese
@blast_hardcheese:matrix.org
[m]
kelnos: Barring any major objections to guardrail-dev/guardrail#1197 I think I'll merge as-is -- I was thinking it would make sense to also re-package definitions and modules and whatnot, but that'll be a real PITA for folks who maintain their own forks of guardrail to do all at once.
Once that's in, I'll cut some smaller PRs to move individual classes to raise visibility and make each individual changeset tractable, instead of doing 52 card pickup with the package structure.
The nice thing about wrapping this splitout up with guardrail_${scala.binary.version} artifact as root is that it's a no-op for the build tools at the moment, we can gradually implement the tooling improvements when there's time
once all the pieces are in place, I think the last big thing is to remove the tracing stuff, as akka-http, http4s, dropwizard, and spring-mvc all have a better way of doing that, either by mapRoute or by mapping over the entire server itself, and for the Java servers my understanding is there's deep introspection modules that can be registered to provide the route-level tracing required
blast_hardcheese
@blast_hardcheese:matrix.org
[m]
if I'm wrong about that I'm happy to revise, but I don't believe the tracing stuff has ever been broadly consumable other than the bespoke stuff in Twilio's scala-service overrides.
blast_hardcheese
@blast_hardcheese:matrix.org
[m]
also, hah, it has been a while since trying to use metals from vim
kelnos
@kelnos:matrix.org
[m]
blast_hardcheese: fine by me, probably won't have time to look into it in any detail all that soon
blast_hardcheese
@blast_hardcheese:matrix.org
[m]
Understood, just wanted to make sure you were broadly OK with the direction
kelnos
@kelnos:matrix.org
[m]
agree on the tracing stuff, i think it probably should have been out of scope for guardrail in the beginning, but yeah, was mostly there for the twilio bits (that we don't use anymore anyway)
might want to write up a migration guide, though, in case anyone's using it
blast_hardcheese
@blast_hardcheese:matrix.org
[m]
Yeah, as well as a class/package remapping list as things progress in that direction.
The splitout kind of lends itself towards moving stuff like ClientGenerator and ServerGenerator over in dev.guardrail.generators next to ProtocolGenerator, as well as to clean up all the cross-references between those things (like how akka-http uses the response generators from http4s)
kelnos
@kelnos:matrix.org
[m]
i think i would go for something like dev.guardrail.generators.{protocol, server, client} with perhaps also a helpers package
blast_hardcheese
@blast_hardcheese:matrix.org
[m]
What do you think about guardrail-core being reflected in dev.guardrail.core.{...}?
or would dev.guardrail.{...} be the de-facto core?
kelnos
@kelnos:matrix.org
[m]
hrm, i don't think i see the need for a core package, but i'm not really against it either
blast_hardcheese
@blast_hardcheese:matrix.org
[m]
yeah, that's where I am. We already have some dev.guardrail.core package members
so it's a weird position to be in.
I'll sort it though, no worries.
kelnos
@kelnos:matrix.org
[m]
blast_hardcheese: regarding my PR comment about the slf4j-simple good. what do you think about separating out the CLI into its own module (which can then depend on sfl4j-simple)?
s/good/goo/
blast_hardcheese
@blast_hardcheese:matrix.org
[m]
Wrestling with that now, actually, as part of the repackaging effort
kelnos
@kelnos:matrix.org
[m]
kk
blast_hardcheese
@blast_hardcheese:matrix.org
[m]
I'll keep that as an option. I like it because it means the build tools don't need to contend with the CLI at all, as far as name collisions or anything
the downside is that the gradle plugin "uses" guardrail by just constructing CLI args and running the CLI directly 🥴
kelnos
@kelnos:matrix.org
[m]
doh ☹️ i guess that should be fixed too
(or in the meantime the gradle plugin can just depend on the cli artifact)
blast_hardcheese
@blast_hardcheese:matrix.org
[m]
yeah
I really like the fact that coursier is able to just dynamically link and emit a standalone CLI artifact, btw. No need to publish the assembly like I used to do
kelnos
@kelnos:matrix.org
[m]
yeah, that's really cool
blast_hardcheese
@blast_hardcheese:matrix.org
[m]
OK, here's #2. I split out and cleaned up the backreferences between the CLI runners, so now extending CLICommon is much more clean. Previously it was a mess because parseArgs was incorrectly part of CoreTerms, so we had a circular reference thing that mucked everything up. guardrail-dev/guardrail#1213
Also waffling about whether to merge ProtocolGenerators into one big interface instead of this somewhat split out mess, especially since we have useful copy methods.