Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • May 27 08:48
    dependabot[bot] labeled #416
  • May 27 08:48
    dependabot[bot] opened #416
  • May 27 08:48

    dependabot[bot] on npm_and_yarn

    Bump dns-packet from 1.3.1 to 1… (compare)

  • May 14 12:02
    AWolf81 commented #316
  • May 11 00:19
    grimxreaper commented #386
  • May 11 00:17
    grimxreaper commented #316
  • May 10 03:31
    dependabot[bot] labeled #415
  • May 10 03:31
    dependabot[bot] opened #415
  • May 10 03:31

    dependabot[bot] on npm_and_yarn

    Bump hosted-git-info from 2.7.1… (compare)

  • May 07 12:04
    dependabot[bot] labeled #414
  • May 07 12:04
    dependabot[bot] opened #414
  • May 07 12:04

    dependabot[bot] on npm_and_yarn

    Bump url-parse from 1.4.4 to 1.… (compare)

  • May 07 10:19

    dependabot[bot] on npm_and_yarn

    (compare)

  • May 07 10:19
    dependabot[bot] closed #399
  • May 07 10:19
    dependabot[bot] commented #399
  • May 07 10:19
    dependabot[bot] labeled #413
  • May 07 10:19
    dependabot[bot] opened #413
  • May 07 10:19

    dependabot[bot] on npm_and_yarn

    Bump handlebars from 4.0.12 to … (compare)

  • May 06 22:35
    dependabot[bot] labeled #412
  • May 06 22:35
    dependabot[bot] opened #412
Aaron Ross
@superhawk610
Both use jest under the hood, so our entire test suite is being run twice on every rebuild. We should probably fix this, right? Who's in charge of CI?
Melanie Seltzer
@melanieseltzer
Huh! So it does. Josh runs the CI account but I think it could just be modified in .circleci > config.yml to remove the unnecessary step in the pipeline
Alexander Wolf
@AWolf81
Good point. I'm not in charge but I'll update the config.
Melanie Seltzer
@melanieseltzer
Should we try to finalize #326? I think it’s a good change and could probably be merged as is, maybe just adding a semantic color called highlight for purple[500] as it seems to be used quite frequently for highlights. But we could always tackle it later.
Alexander Wolf
@AWolf81
Yes, good idea to finalize this. I like the idea of adding highlight as semantic color but I'm not sure if it is purple[500] or purple[700].
What do you think can we combine some colors? As there are still many raw colors e.g. gray[400], gray[500], gray[700]. I think the difference between 400 & 500 is pretty small so maybe we can use the next closest semantic - I think that's lightText with gray[600].
Is there anything we can do with the semantic coloring so adding theming is easier later? Or would a theme feature just change how we're using the color constants e.g. passing the semantic color object into ThemeProvider and use the sematic props in styled component styles like this.props.theme.primaryColor.
Melanie Seltzer
@melanieseltzer
I’m thinking actually primary seems to be blue and secondary is a purple (looks like there’s no primary or secondary semantic name yet), but yeah we’d have to figure out the specific values. I do think we need to overhaul and combine colors because there’s some subtle variations that are getting a bit out of hand. We should probably circle back on the PR and see what @mathieudutour thinks, or if he needs us to commandeer it
Alexander Wolf
@AWolf81
For the theming: I think I'll create an issue for it because I like to have it as a feature. We can do the theming after the semantic naming PR because we're just using the constants in the theme. I played with theming in this codesandbox.
Melanie Seltzer
@melanieseltzer
Nice, I’ll take a look in a little bit. We’ll need to take over the semantic PR to continue work, how do you transfer work from a fork to a branch on Guppy? Set a new remote and then push to Guppy from there?
Alexander Wolf
@AWolf81
Yes, add a new remote with git remote add fork-username fork-url and then you can do git checkout -b fork-username/branch new-local-branch
Melanie Seltzer
@melanieseltzer

Thanks! That worked. Created #377 and fixed all the conflicts so this should be up to date.

@AWolf81 I like the theme idea :)

Aaron Ross
@superhawk610
Do we have a release pipeline setup already? I'd like to add the homebrew package update to it but I'm not sure where to start
What else is part of each release, are we currently just building the dist output and writing a release notes?
Alexander Wolf
@AWolf81
I think what you're looking for is yarn publish. It runs yarn dist and adds the binary to the latest release note on Github. You can read more about publishing with electron-builder here. Maybe a postpublish that will trigger a homebrew:update script could work.
Alexander Wolf
@AWolf81
I think the dist:all or publish:all is not working as electron-builder needs to run on each platform. Maybe we should improve the CI setup for creating the binaries with Travis & AppVeyor (issue #272).
Good post about CI setup is here - I haven't tested the setup from the post but it looks promising & just code signing could be still a problem.
Aaron Ross
@superhawk610
Thanks @AWolf81 , I'll summarize all that as an issue when I get a chance
@melanieseltzer were you able to get the <Props /> component to work at all in Docz?
It should get the prop types from flow without needing to explictly specify them with the prop-types package but I had no luck
Melanie Seltzer
@melanieseltzer
I haven’t checked, i can play around with it some more. Looks like the #3 activeClassName issue got fixed since your comment, i’ll update and see :)
Aaron Ross
@superhawk610
sweeeeet
Melanie Seltzer
@melanieseltzer
I played briefly with updating to v1.0.0-rc.8 but was getting a bunch of errors, then got busy with onboarding at my new job 😅 I do think we’ll have to wait some more for it to mature. I’m waiting on this fix pedronauck/docz#768 for one of my own projects so i’ll see if a next release fixes the issues i was having with it in Guppy
Alexander Wolf
@AWolf81
@melanieseltzer I'm working on adding i18n-menu item and I'm not sure if the location is OK. At the moment I'm having it in File\Language, is that OK (see following screenshot)?
image.png
The selected language will be in app-settings.reducer in general.language - I think that's OK.
Melanie Seltzer
@melanieseltzer
I think that’s fine for Windows, although i’m not sure of the conventions around menu prefs for that OS and where they tend to group settings. I would say for Mac maybe we should follow VS Code’s convention and group Language + current Preference item under a parent ‘Preferences’?
Screen Shot 2019-04-12 at 8.46.47 AM.png
I think it looks pretty clean, especially with the line separators… thoughts anyone?
Alexander Wolf
@AWolf81
Yes, I like the idea but I'm not sure if we should add the language submenu to a preferences submenu - feels like that is not a good UX as it's too nested. I've added a separator line between Import existing project... and Language to separate them a bit.
Adding it to App menu for Mac is a good point - I'll add that and keep it in File menu on Windows.
Should we have the language submenu and a language selection in preferences modal? Or is one location enough? I think it's OK to have it in both locations.
Alexander Wolf
@AWolf81
@melanieseltzer OK, I've added the language menu item to app menu on Mac. Could you please have a look if this is OK and working as expected?
Melanie Seltzer
@melanieseltzer
Loosk good to me! i see what you mean about the nesting, looks good as you have it
Aaron Ross
@superhawk610
docz got their official 1.0 a week or so ago, and it looks like that issue you linked @melanieseltzer is closed, I wonder if any of the fixes we were waiting on were addressed
FWIW @AWolf81 I like the placement you went with for the language item
Melanie Seltzer
@melanieseltzer
Yup the freezing fix was deployed which fixed what i was waiting on. Unfortunately i think Guppy is experiencing this issue, which is still present in 1.0.0: pedronauck/docz#790
Also getting these errors for my personal project, i think cause of the import/export patterns we’re following. None of the fixes documented anywhere in the issues were doing the trick :/
Aaron Ross
@superhawk610
womp :/
alright, well I'm OK with giving it another few weeks to let some of the kinks solve themselves, it's not really a pressing issue
Alexander Wolf
@AWolf81
@superhawk610 thanks, good to hear that the placement is OK. I think I'm doing the language selection in app settings modal later. Now I'm waiting for Zianke for a first version of i18n to review - maybe I'll support with the German translations.
Aaron Ross
@superhawk610
cool, glad to see we're making such good progress on this :)
Aaron Ross
@superhawk610
Pretty cool analog to Guppy :)
Alexander Wolf
@AWolf81
Good idea to have it run in browser but not supported on Windows :-(
image.png
Melanie Seltzer
@melanieseltzer
I love this sort of stuff :) so cool. Looks like they’re working on windows support, @AWolf81 :D alex-saunders/glicky#10
Alexander Wolf
@AWolf81
@melanieseltzer thanks for the link to the PR. Now I could test it locally. I also like the idea of running it with npx glicky but I think he's recoding lot of stuff we already have in Guppy (things missing available-port-check, queued dependency installation,...). It would be probably easier to change the execution context from Guppy to a Nodejs server.
The browser would be the frontend renderer & Nodejs would spawn processes that are triggered via Websocket or http requests. We could open an issue for this but I'm not sure if it's worth it.
Emanuel Canova
@Canopix
Hi everyone! I want to contribute to this tool, my intention is to collaborate adding the Spanish language.
Maybe this is a dumb question but ¿How can I make this? I read the Internationalization issue on GitHub but I'm not able to find any step-to-step guide to add a language
Melanie Seltzer
@melanieseltzer

Hi @Canopix! Welcome and thanks for your interest in contributing! Localization is currently still WIP with a PR out, and right now there isn’t a set guide on how to add a language. I see from #66 it’s on our to do list to add. I think once the first localization PR gets merged, we’ll have a better idea of what it takes per language and will be able to provide a guide :)

@AWolf81 is there a preliminary workflow for this yet?

Alexander Wolf
@AWolf81
There is no workflow right now. But once English locale is merged I can write a how-to guide. I'll ask @zianke if he needs support - just smaller things open in the PR. Then we're having the first components with i18n strings.
Emanuel Canova
@Canopix
@melanieseltzer Thanks for answering me. I will be waiting for that and looking if I can be useful in other parts of the project
Alexander Wolf
@AWolf81
@Canopix at another project it would be great if you could review if a Spanish translation is correct? BoostIO/Boostnote#2966 They need a second reviewer for the translation.
Emanuel Canova
@Canopix
Thanks! @AWolf81 It's done!
Alexander Wolf
@AWolf81
Thanks @Canopix, really appreciate it.