Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Nov 29 23:25
    keinhaar commented #406
  • Nov 29 22:56
    niloc132 commented #406
  • Nov 29 15:08
    keinhaar commented #406
  • Nov 18 09:08
    protoism commented #406
  • Nov 18 02:54
    protoism commented #406
  • Nov 18 02:51
    protoism commented #406
  • Nov 18 02:49
    protoism commented #406
  • Nov 16 21:22
    slavap commented #406
  • Nov 16 19:13
    keinhaar commented #406
  • Nov 16 16:48
    niloc132 commented #406
  • Nov 15 14:33
    sstamm commented #410
  • Nov 11 10:34
    keinhaar commented #406
  • Oct 21 15:02
    keinhaar synchronize #412
  • Oct 21 14:46
    keinhaar opened #413
  • Oct 21 13:33
    keinhaar opened #412
  • Oct 19 08:11
    keinhaar commented #406
  • Oct 19 01:35
    slavap commented #406
  • Oct 18 23:07
    foal commented #406
  • Oct 18 23:04
    foal commented #406
  • Oct 18 15:25
    keinhaar commented #406
Frank Hossfeld
@FrankHossfeld
Using this, there is no need for a plugin.
Colin Alworth
@niloc132
we might be able to get access to the github repo (and deployment keys? is that necessary for eclipse marketplace?), but that is only needed for syntax highlighting in JSNI and the like
foosoftsrlold
@foosoftsrlold
If guided, I could try and update the plugin. Well.. it looks like a huge amount of code, but looking just at compilation there's really just a little bit to be touched (a class StubUtility which has been moved, and a missing javax.inject.Inject. Being no Eclipse expert (I mean... not at all) I'd appreciate if @FrankHossfeld could clarify the effort needed, and if there's a show stopper I don't know of.
Colin Alworth
@niloc132
@foosoftsrl i don't think any of us are experts - frank at least isn't even an eclipse user either last i heard, much less an expert
Frank Hossfeld
@FrankHossfeld
@foosoftsrl @niloc132 is right. I stopped using Eclipse several years ago. Switch to IntelliJ. And now, using IntelliJ, I do not use a GWT plugin. Set up your project with Macen or Gradle and use browser debugging features.
Daniel Korbel
@masterdany88
I use Intelij ultimate and debugging feature works out of box
Screenshot_20220301_091008.png
foosoftsrlold
@foosoftsrlold
Hi all, I kind of suspected that everyone had gone with Intellij, either with plugins, or bare maven / gradle. I kind of managed to have something running on Eclipse 2021-12. But it is a kind of a nightmare... First I had problems with misconfigured DI which misteriously disappeared (perhaps due to wrong debugging configuration?), then with wrong module configuration (fixed using downloaded GWT sdk), then with java compiler version (fixed forcing java 9 output). Pretty sure that if I build the plugin things will break.
Frank Hossfeld
@FrankHossfeld
Are you using Maven?
foosoftsrlold
@foosoftsrlold
We tried intellij + gradle and... yes it is usable.
I understand that the value added of the plugin is small compared to the code base and to the complexity of eclipse
But... I mean... even if you say people switch to maven / gradle... leaving the plugin unmaintained is really just... sad...
foosoftsrlold
@foosoftsrlold
@FrankHossfeld In all honesty, I can't spend on this more than a couple of days, and I'm seriously considering the idea of giving up
Ahmad K. Bawaneh
@vegegoku
I cant speak of gradle but if you are using maven you dont need a plugin at all and any ide should work , all you need is a terminal to execute your commands, and IMHO killing the plugin is for better. no need for a plugin that needs to be maintained for every eclipse version
to help you better we got to know what build system you use? is this a new project or old project?
if you are using maven then what gwt maven plugin you use? if gradle what gwt gradle plugin you use
Frank Hossfeld
@FrankHossfeld
But... I mean... even if you say people switch to maven / gradle... leaving the plugin unmaintained is really just... sad...
Sometime things change. That’s normal. Don’t expect, that people who stopped using Eclipse & the plugin, will maintain it. I maintain several OS projects (as many other here do) because I use them. And some of them will not work with f.e.: j2cl. Then it is time to change and switch to newer one.
So, if you think, the plugin has value for you, feel free to maintain it. The OS community will appreciate it.
foosoftsrlold
@foosoftsrlold
@FrankHossfeld You did such a great job... I wish I'd be able to do as much. I feel like trying to get the plugin back on track. The plugin is on the first page of gwt documentation and this is, at least in my opinion, enough to justify the effort. I'll be back with more hopefully good news.
Frank Hossfeld
@FrankHossfeld
You did such a great job...
There are many more out there who even do more then I do …
Sorry, that I can not help you, but my Eclipse knowledge is very poor. May be tehre are some Eclipse-User outside who can halp.
foosoftsrlold
@foosoftsrlold
Hi all, the plugin can be patched to work with Eclipse 2021-12, so now the point is... what to do? Main developer @branflake2267 gave up after years of development (a lot of work). A six month old "request for PR" (gwt-plugins/gwt-eclipse-plugin#401 ) lies unanswered, so I assume that @branflake2267 does not believe that this plugin must die (An understandable position)
Frank Hossfeld
@FrankHossfeld
I think, @branflake2267 is no longer involved in GWT development. Maybe @niloc132 can get in contact with him.
foosoftsrlold
@foosoftsrlold
Perhaps the patches at the provided link are ok, perhaps something more is needed for Eclipse 2021-12 (did not try)
If someone can contact @branflake2267, I'd like to try at least to keep the plugin working on latest eclipse. Again, not sure it's worth it, but I feel like trying.
Colin Alworth
@niloc132
his email should be present in the git commits if you'd like to contact him directly
it looks like i am a member of that org, perhaps i can take ownership if he is interested, and i can work with you to get patches landed and a new release out? i cannot promise that i will be very helpful, but i will review code to the best of my ability
if you contact him, cc me please (colin@vertispan.com or colin@colinalworth.com) and i'll help with any transition we can make
i have now made my membership public at https://github.com/orgs/gwt-plugins/people
foosoftsrlold
@foosoftsrlold
Hi guys, time for a new plugin. I'll try and manage a V4 plugin publication. Anyone feels like helping?
Here's a open ticket on github: gwt-plugins/gwt-eclipse-plugin#406
Stanislav Spiridonov
@foal
There is a pull request and binary patch for Eclipse 2022-09: gwt-plugins/gwt-eclipse-plugin#407
Stanislav Spiridonov
@foal
I have prepared a new PR (#410). Support for Eclipse 2022-09 (should be combined with patch for #407) and Java 11. The question is - should we support the previous Eclipse versions? Starting 2022 the m2e API was changed and I do not know how to support different implementations of plugins for different target platforms (Eclipse versions).
foosoftsrlold
@foosoftsrlold

Hi all, sorry it took so much. I can manage merging the PR. Steps are:

Sounds reasonable?

Open point is hijack vs new marketplace entry. There are Eclipse API changes and m2e changes which might make it impossible to support old Eclipse versions, and so the brand new Eclipse marketplace seems more reasonable. Any opinion on this?

Colin Alworth
@niloc132
@foosoftsrl/@foal nice work, thanks! do we think we can be content with saying that "gwt plugin for eclipse v4" is compatible only with versions >X, and for old versions please use v3 with older gwt versions? my perspective is that this is a problem that will lessen in time (as users update their eclipse versions), and that we don't have the resources to solve it today - but if someone were to dedicate time to this, it is probably solvable?
Stanislav Spiridonov
@foal

Before releasing it, we need to

  • Bump the version 3.0.0-XXXX to 4.0.0-XXXX
  • Add GWT 2.10.0 bundle
  • Remove GWT 2.7?

BTW I removed dependency to SDBG bundle....

Building CI

@foosoftsrl with #410 and #409 + #404 it builds just with mvn clean install

foosoftsrlold
@foosoftsrlold
Hi all, I just sent an email to marketplace to ask for suggestions on how to handle the publication of the new plugin. It seems like everyone agrees that it's not worth thinking too much about old Eclipse version, but I'd love to have the old plugin out of the way, or at least labeled as legacy
foosoftsrlold
@foosoftsrlold
@foal, all, I see your 3 PRs which look very promising. They are all based on master branch. Is there any order in which they should be applied? Is 2022-09 the only version supported?
As for project structure, is it ok for everyone applying PRs to master branch? Or we want some fancy schemes with develop branches, release branches and so on? I'm a bit afraid that it won't be possible to seriously test each PR (considering the small number of committers wrt how huge the codebase is, I'd tend to be realistic and just trust the committers)
Stanislav Spiridonov
@foal
@foosoftsrl - The critical for 2022-09 is only gwt-plugins/gwt-eclipse-plugin#409, because M2E API was changed from 2022-09. Without this PR you can build versions for previous versions of Eclipse.
The PR gwt-plugins/gwt-eclipse-plugin#410 just
  • add new target (2022-09),
  • set this target as default for mvn install,
  • remove mylyn and
  • adopt the code to Java 11-17
Luca Piccarreta
@protoism

Here luca, same as @foosoftsrl, personal account. Eclipse people answered this:

Once you have access to the listing, you will be able to add additional Solution Versions to which you will be able to select the supported Eclipse release.
We can try and communicate with the listing authors and see if they are on board to add you as an additional author and once they are giving us the go ahead, we can manually add you to the list.

@branflake2267 I don't understand if this operation (adding additional authors) is something you can do without Eclipse interventions (I suppose not). Please do not stop this!

Does anyone feel like being the right person to be additional author? I personally like the idea, but honestly I'm afraid that I might not be the right person due to lack of time.

Anyway... a revised plan could be:

  • Build plugin with @foal contributions, and provide an ad interim version on gwt official site
  • Update gwt plugin github readme
  • Evaluate if it really makes sense making new and legacy version available at the same update site is worth it (I suspect it's kind of complicate)
  • Prepare CI
  • Publish to marketplace

Does it sound reasonable? @niloc132 I'm in "gwt plugins organization" list of members as a member (https://github.com/orgs/gwt-plugins/people). It is not enough to get write access to gwt-eclipse-plugin repo (tried to push a test branch, could not). Can you give me write access to eclipse plugin repo?

Colin Alworth
@niloc132
@protoism personal opinion, please do not push test branches, repos should be locked down to require pull requests even to owners, to avoid accidental pushes when you meant to aim at your own fork. that said, i'll check it out
Luca Piccarreta
@protoism
@niloc132 I tried a push just to be sure I had no access. Every access to the repo will be mediated by PRs, that's for sure
Fuzzo
@Fuzzo
hello
anybody can help me to install gwt plungin in a fresh eclipse installation?
please
Luca Piccarreta
@protoism
Hi @Fuzzo. You may add http://keeitsi.com/software/eclipse-plugins/ to eclipse update site list, or download https://github.com/foal/gwt-eclipse-plugin/releases/tag/3.0.0.202210140533, unzip and add a local update site pointing to the unzipped directory