gwtproject/gwt

GWT Open Source Project

Dr. Lofi Dewanto

@lofidewanto_twitter

@mP1 I'm not sure, I'm for sorting for the importance... Within the category also for the importance, JSNI at the end of the list...

Miroslav Pokorny

@mP1

alpha sorting makes for a better read and things look neater

Ahmad K. Bawaneh

@vegegoku

I would split JSNI libs from new JSinterop libs

we can make it clear that JSNI is being deprecated, and will make it easier to track when a lib migrates to a JSinterop implementation

Miroslav Pokorny

@mP1

wrap the jsni libs with strikethru

Dr. Lofi Dewanto

@lofidewanto_twitter

I think I'll make a green check symbole for the libs which the maintainer tells me that she/he supports the library in the current version... In this case we all know what libraries still supported...

Dr. Lofi Dewanto

@lofidewanto_twitter

It's something like TÜV in Germany 😉😳

Frank Hossfeld

@FrankHossfeld

@lofidewanto_twitter What about: https://github.com/tbroyer/gwt-maven-archetypes & https://github.com/NaluKit/gwt-maven-springboot-archetype.

Dr. Lofi Dewanto

@lofidewanto_twitter

@FrankHossfeld done, add to Starters...

Frank Hossfeld

@FrankHossfeld

Thanks

Dr. Lofi Dewanto

@lofidewanto_twitter

@All I added the "heart" symbol to show that the libs / frameworks still being supported... I tried to add all the hearts in which libs I know...

If you want to add the heart just follow the two ways I mentioned in the beginning...

All the supported libs / frameworks are always in the beginning of the category...
Hope to get more libs / frameworks for GWT / J2CL 😀👍

https://github.com/gwtboot/gwt-boot-awesome-lili

7 replies

dac2k9

@dac2k9_twitter

Is there anyway to prevent name-clashing when injecting another javascript into your code? Just spend several hours debugging an issue and realized both my code and the injected code was obfuscated, so clashing basically on random :|

dac2k9

@dac2k9_twitter

think I solved it, I create an iframe and use setWindow on the ScriptInjector with that iframe.

Colin Alworth

@niloc132

@dac2k9_twitter there are a few options - gwt defaults to being injected in an iframe to avoid just this, perhaps you've turned it off?

or maybe you injected your JS into the same iframe, instead of the top window ("same iframe" is the default, but ScriptInjector lets you say "inject to TOP_WINDOW" instead to protect against this)

additionally if you have jsinterop defined for your library, gwt will exclude those names

Frank Hossfeld

@FrankHossfeld

@All Just update iban4g. The library is a port of Artur Mkrtchyan's iban4j project to work with Java, GWT & J2CL (@niloc132: Thanks for helping). A library for generation and validation of the International Bank Account Numbers IBAN (ISO_13616) and Business Identifier Codes BIC (ISO_9362).

More informations can be found here: https://github.com/NaluKit/iban4g

Should land in Maven Central in a few hours.

Ahmad K. Bawaneh

@vegegoku

@FrankHossfeld this is awesome

thank you

Frank Hossfeld

@FrankHossfeld

@vegegoku Looking at the open PRs and the open issues of iban4j, I think, the lib has some problems. Not sure, if iban4j is maintained anymore .

The builder pattern looks a little bit strange:

Iban iban = new Iban.Builder()
                     .countryCode(CountryCode.AT)
                     .bankCode("19043")
                     .accountNumber("00234573201")
                     .build();

I am thinking that the build-method shoud return an instance of Iban.

@vegegoku What do you think?

Ahmad K. Bawaneh

@vegegoku

it does right?

https://github.com/NaluKit/iban4g/blob/b92c00ede2cc70da32f7d7619ff00f227ba02454/iban4g/src/main/java/com/github/nalukit/iban4g/shared/Iban.java#L395

Frank Hossfeld

@FrankHossfeld

Yes, but why are the using new then ???

Colin Alworth

@niloc132

new to create a new builder is common i think?

Ahmad K. Bawaneh

@vegegoku

a new builder

it is either a new or a static factory method

Frank Hossfeld

@FrankHossfeld

A hhh yes … Well, Builder can return a new Builder …

Colin Alworth

@niloc132

right, but it isnt doing that here, is it?

Frank Hossfeld

@FrankHossfeld

right it is not … looks so unfamiliar

Colin Alworth

@niloc132

new is used to make a Iban.Builder, then more methods are chained to specify the instance, then build() is called to return a fresh Iban instance

isn't that typical?

Frank Hossfeld

@FrankHossfeld

I am doing it in a different way to avoid the new:

ConsistenceValidator.builder()
                          .roundEnvironment(roundEnv)
                          .processingEnvironment(this.processingEnv)
                          .metaModel(this.metaModel)
                          .build()
                          .validate();

where builder() returns the instance of the builder.

Dr. Lofi Dewanto

@lofidewanto_twitter

@FrankHossfeld @vegegoku @niloc132 I could find both ways in different implementations... I'm not sure what is the correct way for Builder pattern...

Colin Alworth

@niloc132

right, i guess i'm just saying that this isn't "wrong" - not sure there needs to be a single "right" way?

Frank Hossfeld

@FrankHossfeld

I think, both are ok. I prefer the one without new … saves four characters … ;-)

Dr. Lofi Dewanto

@lofidewanto_twitter

StringBuilder uses the "new" way...

Frank Hossfeld

@FrankHossfeld

JavaPoet, Domino-UI and some other libs use the Builder-patttern without new. As @niloc132 said it is also correct and I don’t think there is prefered implementation AFAIK.

Dr. Lofi Dewanto

@lofidewanto_twitter

I found a good description https://stackoverflow.com/questions/26118790/builder-without-input-parameters-with-a-static-build-method

Dr. Lofi Dewanto

@lofidewanto_twitter

So if I don’t need any constructor params I could add a static builder factory method... like what you said @FrankHossfeld ... so it’s some kind of Factory pattern within Builder pattern... if I understand the StackOverflow content correctly 😇😜

Frank Hossfeld

@FrankHossfeld

@lofidewanto_twitter Tahnks, I changed it in that way, that now both ways to implement it are supported.

Dr. Lofi Dewanto

@lofidewanto_twitter

@FrankHossfeld do you maintain https://github.com/NaluKit/iban4g? I would add it with 💜 in the Gwit a LiLi...

Frank Hossfeld

@FrankHossfeld

Yes, I’ll do.

Dr. Lofi Dewanto

@lofidewanto_twitter

@FrankHossfeld done!

Frank Hossfeld

@FrankHossfeld

:+1:

Colin Alworth

@niloc132

more informal than usual j2cl/gwt call on thursday, dmitrii and i are going to talk about i18n and codegen, and i'm going to work on shipping xhr/geolocation/safehtml: https://meet.google.com/pza-qzmy-ops - will start about 11am my time zone (UTC-5), 6pm in UTC+2

Dr. Lofi Dewanto

@lofidewanto_twitter

👍👍👍

Colin Alworth

@niloc132

call has started, please feel free to join, but its going to be even more informal than usual

Where communities thrive

People

Repo info

Activity