I added an exception system to dgtype. It can be seen in dgtype/exception.hh
Basically you edit exception.hh and define your exception like so
DEFINE_DGTYPE_EXCEPT(Invalid_input)Then you can throw it like so
throw dgtype::Invalid_input_exception("Munchkin-rsa")When caught, if you call the function what() like so
catch (dgtype::Exception e) {
std::cerr << e.what() << std::endl;
}It will print:
Munchkin-rsa: Invalid_input_exception
You can include either
<dgtype/dgtype.hh> or <dgtype/exception.hh> to use it; preferrably the latter, but dgtype.hh should include all of our types for you
It's a macro?
i'm close to going through dgtype and adding a line
#pragma not even once
is
__DEFINING_EXCEPTIONS a gcc extension?
@Towerism
So firstly I would like to apologize to you guys for making you wait on Friday, I fell asleep and didn't mean to inconvenience you
and secondly
I'm trying to make install-ceps after pulling develop
and it says no rule to make target
*deps
help
what directory are you in
I guess asleep is better than what we thought. We thought you were getting coffee or something...I forget
But 9 days is a hell of a nap
@Towerism you get my text?
Just now, yes. Let me go look at it
yo @bluyam why are you running install-deps anyway? When did you last run it?
@Towerism if you have a sec I'm just wondering why it's a macro
and is __DEFINING_EXCEPTIONS a compiler extension or gtest or what?
Oh yea it's a macro. So that it's easy to add another exception. It allows you to include exception_util.hh
you created it?
I didn't want DEFINE_DGTYPE_EXCEPT polluting the namespace so I make sure that it gets undefined ASAP
don't have the two underscores in front
the macro __DEFINING_EXCEPTIONS..
that's for extensions and other things
oh yea just remembered that
that's why I thought it was like a gcc extension
I'll fix it
lol
Also I'm not sure why have a macro....it seems to me it's just dangerous
why not just have like a template or something
or nothing at all actually
It wasn't originally a macro
Originally it was just a base class and exception classes that extended it
did someone reccomend a macro somewhere or did you just get carried away? haha
I was making the exceptions that I wrote for BMP accessible to WAV but also more abstract so I could append WAV: or BMP: at the beginning depending on who is throwing the exception
I tried a few ways to accomplish it but ultimately the easiest way to achieve code a greater level of code reuse was to introduce the macro
just have a generic exception for both
I got carried away haha, only way to explain why I didn't do that
there is such thing as dry to a fault
think old ass leather skin people
their skin is TOO DRY
It is nice though, isn't it?
It's terrifying on many accounts haha
I'm just trying to get OpenSSL installed
I could make macros so I don't have to use semi-colons but I'm not crazy
Oh let me go to the home dir
Just leave your exceptions in my hands >:)
@bluyam just do pwd
Also sam, that is a brilliant idea. Let me create a new library called dgshortcuts
Just shoot me
Also cancel your tests in post
So instead of using semicolons you would type APPEND_SEMICOLON_TO(statement)
what do you mean?
it seems like you're getting carried away with that
I'm jk
Are you talking about travis?
or at least if you cancel something -- make sure before you're done you have a test that either passes or fails
yeah I was talking about [ci-skip]
Obviously I'm totally behind APPEND_SEMICOLON_TO(this_is_my_statement_that_is_in_need_of_semi_colons)
Oh yea there were a lot of related commits, and commit mistakes due to rushing that a lot of my pushes were unnecessary
Just let them go
alright
only cancel if it will only stop when it times out (infinite loops, things like that)
Oh okay
@blue
@bluyam you figured out where you are yet?
so I successfully installed the things
but when I compile I still get that openssl/md5.h cannot be included
but I guess as long as it works on travis that's ok
no it has to work where you work
are you on build?
ys
Travis takes a long time to build, you'd be waiting several minutes to know if your build was successful
Let me rephrase, travis takes a while before it gets to the build step
and if use it as a compiler... you'll end up hogging it
so what to does
checking if it works on my account quick
thumbs up emoji
you're stego-attack?
yes
let me push rq
works perfectly for me
you'll have to pull first
I ran
make clean-force; make all; make -k test-all
@bluyam I'm going to bed. You need tests, btw.
ty
no problem. I took a look and openssl needs to be installed explicitly with
make install-openssl
that might help
welp I broke everything
(jk)
It should be a simple fix
I don't understand why. Embeadding and extracting should be nearly 100% tested.
are there certain cli args needed?
@Towerism coverage works by running the binary, if the binary doesn't go through that path ( you can run it multiple times) it isn't covered
Though we should have decent coverage just with tests
Yea most of the args have sanity checks and certain args depend on others.
The binary doesn't do anything I dont think if no args are given
aaah...find run-debug-stego-crypt and run it enough times to cover all the different option combinations
@Towerism if that isn't reasonable, just do a reasonable set
oh and those are in the makefile
rafs and i are in lab A
So, I only included the file openssl/md5.h once, but I still get a similar error. SO seems to think I should include -lssl in the linker options, which requires that we install libssl. What do you think Bubba? If I can't fix this within the next half hour I'm just going to move on to the next card
This message was deleted
The error I'm getting:
kdw0134@build stego-attack-lib $ gcc stego-attack-lib.cc -o stego-attack-lib -lcrypt -w
/tmp/ccmMzbzc.o: In function `getMD5Hash(char*, unsigned char*, bool)':
stego-attack-lib.cc:(.text+0x15f): undefined reference to `MD5'
collect2: error: ld returned 1 exit status
it doesn't work with make?
I thought it worked.
Let me make clear and such.
The thing is, it broke when I tested, which I thought meant that the compiler was having the above issue.
The thing is, it broke when I tested, which I thought meant that the compiler was having the above issue.
No that's probably just because when you build manually you're not linking ssl. make does.
How so? Doesn't -lcrypt link ssl?
no idea
use make
Lol ok.
What is the threefold command again?
even I don't know how to manually build this thing...it's too large and complicated
I can't seem to find it on here.
I usually run:
make clean-force; make all; make -k test-all
Perf, thanks
That's my go to check
generally you can just do make all
and then make test-debug-stego-attack
Gotcha.
Here's what I get:
======================================
Starting Debug Build
======================================
-- The C compiler identification is AppleClang 6.1.0.6020049
-- The CXX compiler identification is AppleClang 6.1.0.6020049
-- Check for working C compiler: /usr/local/opt/ccache/libexec/cc
-- Check for working C compiler: /usr/local/opt/ccache/libexec/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/local/opt/ccache/libexec/c++
-- Check for working CXX compiler: /usr/local/opt/ccache/libexec/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Looking for include file pthread.h
-- Looking for include file pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - found
-- Found Threads: TRUE
-- GMP libs: /usr/local/lib/libgmp.dylib /usr/local/lib/libgmpxx.dylib
-- Found GMP: /usr/local/include
-- Found OpenSSL: /usr/lib/libssl.dylib;/usr/lib/libcrypto.dylib (found version "0.9.8}")
Found rsa-crypt-lib. Adding dependency: rsa-crypt depends on rsa-crypt-lib
Found rsa-crypt-lib. Linking rsa-crypt with rsa-crypt-lib
Found rsa-attack-lib. Adding dependency: rsa-attack depends on rsa-attack-lib
Found rsa-attack-lib. Linking rsa-attack with rsa-attack-lib
Found stego-crypt-lib. Adding dependency: stego-crypt depends on stego-crypt-lib
Found stego-crypt-lib. Linking stego-crypt with stego-crypt-lib
Found stego-attack-lib. Adding dependency: stego-attack depends on stego-attack-lib
Found stego-attack-lib. Linking stego-attack with stego-attack-lib
Coveralls: Using alternate CMake script dir: /Users/sam/Code/C++/CSCE315/Project4/DickGrayson/share/cmake
COVERALLS UPLOAD: ON
Found rsa-attack-lib. Linking rsa-attack-test with rsa-attack-lib
Found rsa-crypt-lib. Linking rsa-crypt-test with rsa-crypt-lib
Found stego-attack-lib. Linking stego-attack-test with stego-attack-lib
Found stego-crypt-lib. Linking stego-crypt-test with stego-crypt-lib
-- Configuring done
-- Generating done
-- Build files have been written to: /Users/sam/Code/C++/CSCE315/Project4/DickGrayson/debug
Scanning dependencies of target dgcrypto
Scanning dependencies of target dgtype
Scanning dependencies of target rsa-attack-lib
Scanning dependencies of target dgimg
Scanning dependencies of target dgsnd
Scanning dependencies of target rsa-crypt-lib
Scanning dependencies of target stego-attack-lib
Scanning dependencies of target stego-crypt-lib
[ 2%] Scanning dependencies of target gtest
[ 5%] [ 7%] [ 10%] [ 12%] [ 15%] [ 17%] Building CXX object lib/CMakeFiles/dgtype.dir/dgtype/dgtype.cc.o
[ 20%] Building CXX object lib/CMakeFiles/dgcrypto.dir/dgcrypto/dginteger.cc.o
[ 23%] Building CXX object lib/CMakeFiles/rsa-attack-lib.dir/rsa-attack-lib/common_modulus.cc.o
Building CXX object lib/CMakeFiles/stego-attack-lib.dir/stego-attack-lib/stego-attack-lib.cc.o
Building CXX object lib/CMakeFiles/dgsnd.dir/dgsnd/dgsnd.cc.o
Building CXX object lib/CMakeFiles/dgcrypto.dir/dgcrypto/dgrandominteger.cc.o
[ 25%] Building CXX object lib/CMakeFiles/dgsnd.dir/dgsnd/wav.cc.o
Building CXX object lib/CMakeFiles/rsa-attack-lib.dir/rsa-attack-lib/factorization_attack.cc.o
Building CXX object lib/CMakeFiles/dgcrypto.dir/dgcrypto/dgrandomprime.cc.o
[ 28%] Building CXX object lib/CMakeFiles/rsa-attack-lib.dir/rsa-attack-lib/known_totient.cc.o
[ 30%] Creating directories for 'gtest'
[ 35%] [ 35%] [ 38%] [ 41%] Building CXX object lib/CMakeFiles/rsa-crypt-lib.dir/rsa-crypt-lib/rsa-crypt-lib.cc.o
[ 43%] Building CXX object lib/CMakeFiles/stego-crypt-lib.dir/stego-crypt-lib/embedding_agent.cc.o
[ 46%] Building CXX object lib/CMakeFiles/stego-crypt-lib.dir/stego-crypt-lib/extracting_agent.cc.o
[ 48%] Building CXX object lib/CMakeFiles/dgimg.dir/dgimg/bmp_data.cc.o
Building CXX object lib/CMakeFiles/dgimg.dir/dgimg/bmp.cc.o
Building CXX object lib/CMakeFiles/dgimg.dir/dgimg/EasyBMP.cc.o
Building CXX object lib/
Oh it truncated it
Where did it truncate?
here's the errors/warnings
wait
I'm just going to put a file on here
Ok.
@Towerism do you have an example original/encrypted file set that I can run more tests on?
Oh, I accidentally added the main back in so it's flippin' shit.
oh @bluyam just checkout travis
Let me fix that.
you realize you're not breaking anyone elses stuff right? haha we have no idea if you fuck up
Yeah I understand lol. Keeping you up to date I guess...? ¯_(ツ)_/¯
haha ok just checking
at first I thought when you were merging these things into develop and I was like WHUT
Yeah but just use make. I think the problems are not linking related.
Try commenting out stuff until it works then adding back until you can isolate
Bueno.
Also @ralphie9224 please move your cards from Backlog to Sprint 3 when you can.
Linking CXX executable dgimg-test
CMakeFiles/dgsnd-test.dir/dgsnd/dgsnd-test.cc.o: In function `Wav_InvalidFormatException_Test::TestBody()':
dgsnd-test.cc:(.text+0xe6): undefined reference to `sf_close'
CMakeFiles/dgsnd-test.dir/dgsnd/dgsnd-test.cc.o: In function `Wav_InaccessibleFileException_Test::TestBody()':
dgsnd-test.cc:(.text+0x2c6): undefined reference to `sf_close'
CMakeFiles/dgsnd-test.dir/dgsnd/dgsnd-test.cc.o: In function `Wav_SampleSetMask_Test::TestBody()':
dgsnd-test.cc:(.text+0x5f2): undefined reference to `sf_close'
CMakeFiles/dgsnd-test.dir/dgsnd/dgsnd-test.cc.o: In function `Wav_SampleUnsetMask_Test::TestBody()':
dgsnd-test.cc:(.text+0xa02): undefined reference to `sf_close'
CMakeFiles/dgsnd-test.dir/dgsnd/dgsnd-test.cc.o: In function `DG::Sound::WAV::~WAV()':
dgsnd-test.cc:(.text._ZN2DG5Sound3WAVD2Ev[_ZN2DG5Sound3WAVD5Ev]+0x9): undefined reference to `sf_close'
../lib/libdgsnd.a(wav.cc.o): In function `DG::Sound::WAV::open(std::string const&)':
wav.cc:(.text+0x25): undefined reference to `sf_open'
collect2: error: ld returned 1 exit status
test/CMakeFiles/dgsnd-test.dir/build.make:94: recipe for target 'test/dgsnd-test' failed
make[3]: *** [test/dgsnd-test] Error 1
libsndfile isn't linking to dgsnd-test.cc
@gwydirsam