These are chat archives for gwydirsam/DickGrayson

28th
Apr 2015
Sam Gwydir
@gwydirsam
Apr 28 2015 00:10
on it
oh wait
this is because you never told me how to link it
hook me up brotherman @Towerism
quick fix is probably just append -lsndfile after every -pthread in CMakeLists.txt (the root one)
Martin Fracker, Jr.
@Towerism
Apr 28 2015 00:14
I was thinking of just submodule'ing it since the main author has a repo on github
Sam Gwydir
@gwydirsam
Apr 28 2015 00:15
don't play like that
it's installed
submodules are not fun
Martin Fracker, Jr.
@Towerism
Apr 28 2015 00:15
lol I had a feeling you wouldn't like that. Alright I'll append sndfile to global_libs then?
Sam Gwydir
@gwydirsam
Apr 28 2015 00:15
no
just do what I said
or write/find a FindLibSndFile.cmake that works
Martin Fracker, Jr.
@Towerism
Apr 28 2015 00:16
Still have to link it though.
Sam Gwydir
@gwydirsam
Apr 28 2015 00:17
....
or modify the FindGMP.cmake
Martin Fracker, Jr.
@Towerism
Apr 28 2015 00:18
lol that's so tacky
Sam Gwydir
@gwydirsam
Apr 28 2015 00:19
no like, create a FindSndFile.cmake based on FindGMP.cmake
In any case I'll do it tomorrow. But for now you can just -lsndfile
Martin Fracker, Jr.
@Towerism
Apr 28 2015 00:21
Oh okay, I'll just -lsndfile. It works fine for now.
Kyle Wilson
@bluyam
Apr 28 2015 00:24
@Towerism can I just use the test files that you're using
Sam Gwydir
@gwydirsam
Apr 28 2015 00:25
@bluyam stego-attack won't be linked...you'll be worse off
@bluyam why are you using printf?
also its stego-attack not stego_attack
Martin Fracker, Jr.
@Towerism
Apr 28 2015 00:30
@bluyam yea you should write your own tests. You don't need to test my code lol.
oh wait
Sam Gwydir
@gwydirsam
Apr 28 2015 00:30
@bluyam I think I misunderstood I think he means the wavs
Martin Fracker, Jr.
@Towerism
Apr 28 2015 00:30
yea
I realized that just before you said that
yea @bluyam just copy the pathing that I use in my tests and you'll be good to go
Ideally though we would have a common directory of test files. No matter.
Sam Gwydir
@gwydirsam
Apr 28 2015 00:31
@bluyam note wav stuff won't work until @Towerism pushes the linking stuff and you'll need to merge his branch into yours
probably should
@Towerism it should probably all go in share or something
Martin Fracker, Jr.
@Towerism
Apr 28 2015 00:31
ah yes
I'll do that in my branch now
Actually I do that in develop
nvm. I'll do it sometime
Sam Gwydir
@gwydirsam
Apr 28 2015 00:33
s/sometime/never
Martin Fracker, Jr.
@Towerism
Apr 28 2015 00:33
lol
Sam Gwydir
@gwydirsam
Apr 28 2015 00:33
probably better we do it in develop at somepoint when everything is merged
Martin Fracker, Jr.
@Towerism
Apr 28 2015 00:34
I agree
Btw I accidentally found projectiles's find other file function in helm.... OMG YESS!
Sam Gwydir
@gwydirsam
Apr 28 2015 00:35
yeah research the stuff you have already and I think you'll be satisfied for a long time
Kyle Wilson
@bluyam
Apr 28 2015 00:35
Oh thanks for pointing out the underscore @gwydirsam \
Sam Gwydir
@gwydirsam
Apr 28 2015 00:36
@Towerism look through info (C-h i)
Martin Fracker, Jr.
@Towerism
Apr 28 2015 00:36
Oh that reminds me, I don't know if everyone knows this already but don't use underscores in your test and testcase names. In can cause painful problems with gtest.
Kyle Wilson
@bluyam
Apr 28 2015 00:37
Also @Towerism I am referring to test.bmp and test-stego.bmp
Sam Gwydir
@gwydirsam
Apr 28 2015 00:39
I know this will fall on deaf ears but RTFM everyone.
@Towerism excluded...because he dreams about this
Kyle Wilson
@bluyam
Apr 28 2015 00:40
What manual? The instructional pdf?
Martin Fracker, Jr.
@Towerism
Apr 28 2015 00:41
lmao
Kyle Wilson
@bluyam
Apr 28 2015 00:41
Hallelujah it was the fucking underscores, all tests passed.
Good catch.
Sam Gwydir
@gwydirsam
Apr 28 2015 00:43
cool
Though I would prefer your stuff was written in C++ style not straight C
a lot of it looks like it was copy and pasted too
or at least it was written to be compiled as if it were C89
Kyle Wilson
@bluyam
Apr 28 2015 00:48
I did get a lot of it from SO, but C works better for the straight char buffers imo.
C style, at least
I will change the printfs tho
Sam Gwydir
@gwydirsam
Apr 28 2015 00:49
what I mean is more this stuff:
  int i;
  for (i = 0; i < MD5_DIGEST_LENGTH; i++) {
probably because you were compiling with bare gcc which defaults to C89
(not in the latest version so that's nice)
Kyle Wilson
@bluyam
Apr 28 2015 00:51
Yeah, that was one of the things I got from SO. If you know how to do the same thing with more C++ style be my guest, but I'ma move on for now.
Sam Gwydir
@gwydirsam
Apr 28 2015 00:51
  for (int i = 0; i < MD5_DIGEST_LENGTH; i++) {
done
you should obfuscate if you're copying from SO
and maintain a style
Martin Fracker, Jr.
@Towerism
Apr 28 2015 00:51
btw sam, this is a FindLibSndFile.cmake I found. https://github.com/stevedekorte/io/blob/master/modules/FindLibSndFile.cmake
Kyle Wilson
@bluyam
Apr 28 2015 00:52
Will do
Sam Gwydir
@gwydirsam
Apr 28 2015 00:52
use brackets for blocks...etc
Kyle Wilson
@bluyam
Apr 28 2015 00:52
Oh I thought you were referring to something else in the for loop
Obfuscation in progress
Sam Gwydir
@gwydirsam
Apr 28 2015 00:53
Yeah I just don't want to get nailed
@Towerism try it out
Martin Fracker, Jr.
@Towerism
Apr 28 2015 00:58
Is it in my branch?
Sam Gwydir
@gwydirsam
Apr 28 2015 00:58
no...like you can try it if you want
I'll work on it tomorrow
I'm checked out for today
Martin Fracker, Jr.
@Towerism
Apr 28 2015 01:06
Ah okay, I'm not worried about it right now. I'm gonna try to finish writing the interface to libsndfile. I'm just about done. Afterwards I'll start on that.
Martin Fracker, Jr.
@Towerism
Apr 28 2015 02:21
Hey so builds about to be failing because travis doesn't have libsndfile installed
I'm going to add libsndfile to make install-deps
jk It's already there.
Not sure why travis can't find -lsndfile
Martin Fracker, Jr.
@Towerism
Apr 28 2015 02:39
I'm gonna start the FindLibSndFile.cmake thing
Martin Fracker, Jr.
@Towerism
Apr 28 2015 02:55
Seems to be working good. Travis isn't complaining
Martin Fracker, Jr.
@Towerism
Apr 28 2015 03:21
Well things aren't necessarily okay. Build passes but some of the tests are failing due to cmake errors (dgsnd in particular) which is bizarre since the build passes
Martin Fracker, Jr.
@Towerism
Apr 28 2015 06:55
Considering how libsndfile is disallowed on travis... I don't know what to do.
Jk I think the problems had something to do with the update that travis-ci tried to do and then rolled back earlier.
Martin Fracker, Jr.
@Towerism
Apr 28 2015 08:28
Jk, I left you problems to fix Sam.
Also we need to test my install scripts no matter what anyway
containers have a very limited amount of things they can do
Sam Gwydir
@gwydirsam
Apr 28 2015 13:22
@bluyam please put your stuff in a namespace (follow rsa-crypt's example) or a class
Kyle Wilson
@bluyam
Apr 28 2015 16:58
I can....but would that be just for consistency? Or is that needed/beneficial for writing the interface?
Sam Gwydir
@gwydirsam
Apr 28 2015 18:37
@bluyam consistency
well I guess that and the real reason is so they aren't global
Kyle Wilson
@bluyam
Apr 28 2015 18:48
Ah gotcha
Martin Fracker, Jr.
@Towerism
Apr 28 2015 19:02
@gwydirsam I saw the whitelist shit :p
Sam Gwydir
@gwydirsam
Apr 28 2015 19:02
yeah I remember leaving it in there commented and thinking it was a bad idea after I committed haha
skype at 3 yeah?
Martin Fracker, Jr.
@Towerism
Apr 28 2015 19:06
Yes