These are chat archives for gwydirsam/DickGrayson

29th
Apr 2015
Rafael Moreno
@ralphie9224
Apr 29 2015 00:22
on this line mpz_class std::string encode(std::string message, mpz_class d, mpz_class n);
I get these errors ```
In file included from /home/ugrads/r/ralphie9/315/DickGrayson/lib/rsa-attack-lib/common_modulus.hh:4:0,
                 from /home/ugrads/r/ralphie9/315/DickGrayson/lib/rsa-attack-lib/common_modulus.cc:1:
/home/ugrads/r/ralphie9/315/DickGrayson/lib/rsa-crypt-lib/rsa-crypt-lib.hh:40:13: error: expected ‘;’ at end of member declaration
   mpz_class string encode(std::string message, mpz_class d, mpz_class n);
             ^
/home/ugrads/r/ralphie9/315/DickGrayson/lib/rsa-crypt-lib/rsa-crypt-lib.hh:40:72: error: ISO C++ forbids declaration of ‘encode’ with no type [-fpermissive]
   mpz_class string encode(std::string message, mpz_class d, mpz_class n);
                                                                        ^
In file included from /home/ugrads/r/ralphie9/315/DickGrayson/lib/rsa-crypt-lib/rsa-crypt-lib.cc:1:0:
/home/ugrads/r/ralphie9/315/DickGrayson/lib/rsa-crypt-lib/rsa-crypt-lib.hh:40:13: error: expected ‘;’ at end of member declaration
   mpz_class string encode(std::string message, mpz_class d, mpz_class n);
             ^
/home/ugrads/r/ralphie9/315/DickGrayson/lib/rsa-crypt-lib/rsa-crypt-lib.hh:40:72: error: ISO C++ forbids declaration of ‘encode’ with no type [-fpermissive]
   mpz_class string encode(std::string message, mpz_class d, mpz_class n);
blob
please help me
help me marty mr. smarty
you're my only hope
Rafael Moreno
@ralphie9224
Apr 29 2015 00:32
I figured it out
thanks marty
Martin Fracker, Jr.
@Towerism
Apr 29 2015 08:11
lol no problem rafa. Sorry I wasn't paying attention to gitter all day.
Kyle Wilson
@bluyam
Apr 29 2015 13:55
Skype or irl today?
Sam Gwydir
@gwydirsam
Apr 29 2015 13:57
I think we only IRL mondays and fridays now
Christopher Findeisen
@Atrus7
Apr 29 2015 19:45
@ralphie9224 Can you make your base_64 decoding and encoding not class specific? I don't know why the functions are class members of RsaKeys. At the least, make them static please.
Sam Gwydir
@gwydirsam
Apr 29 2015 19:53
@Atrus7 there has got to be a way of deciding how all that needs to organized..
or is it just because we're all using our own combination of stuff?
Christopher Findeisen
@Atrus7
Apr 29 2015 19:53
I don't have anything against a class function that is using class variables. But for this, you don't use any, and you return a value. I've already spoken to him about it. Idk why it's done that way.
Sam Gwydir
@gwydirsam
Apr 29 2015 19:54
I just mean in general
Christopher Findeisen
@Atrus7
Apr 29 2015 19:54
IMO, base64 encoding/decoding is not class-specific.
unless that class is a file or string manipulation class of course.
Sam Gwydir
@gwydirsam
Apr 29 2015 19:54
I don't have enough info to have an opinoin
Christopher Findeisen
@Atrus7
Apr 29 2015 19:55
I'll talk to Rafa about it today.
Sam Gwydir
@gwydirsam
Apr 29 2015 19:55
I just mean in general we seem to be running into the issue of whether something should be in a namespace, class, global or what
Kyle Wilson
@bluyam
Apr 29 2015 20:02
rafs and martin are you getting the invitation to the call?
Rafael Moreno
@ralphie9224
Apr 29 2015 20:02
no. trying from phone
Sam Gwydir
@gwydirsam
Apr 29 2015 20:07
for @ralphie9224 http://www.cppsamples.com/common-tasks/non-member-interfaces.html but @/all should look at it
Rafael Moreno
@ralphie9224
Apr 29 2015 20:51
-----BEGIN FOO BAR KEY-----
MIIBgjAcBgoqhkiG9w0BDAEDMA4ECKZesfWLQOiDAgID6ASCAWBu7izm8N4V
2puRO/Mdt+Y8ceywxiC0cE57nrbmvaTSvBwTg9b/xyd8YC6QK7lrhC9Njgp/
...
-----END FOO BAR KEY-----
@Atrus7 that format probably
Christopher Findeisen
@Atrus7
Apr 29 2015 21:02
gotcha! ty.
Martin Fracker, Jr.
@Towerism
Apr 29 2015 22:07
Hey bluyam I'm done refactoring, have you used the either of the functions which_embedding_agent or which_extracting_agent yet?
@bluyam
If not I would like to merge develop into your branch if you don't mind
Rafael Moreno
@ralphie9224
Apr 29 2015 22:30
@Atrus7 encryption works
Martin Fracker, Jr.
@Towerism
Apr 29 2015 22:31
@gwydirsam Found a bug in Makefile, I made a pull request with my fix
Rafael Moreno
@ralphie9224
Apr 29 2015 22:36
also @Atrus7 making the functions static breaks everything
Martin Fracker, Jr.
@Towerism
Apr 29 2015 22:36
probably because you try to use member variables in them
you can't do that in static functions since static functions aren't allowed to reference any instance of the class itself
more specifically there is no 'this' in static functions
static member functions i mean
Christopher Findeisen
@Atrus7
Apr 29 2015 22:41
Noice, and not noice. Call me if you need help
Rafael Moreno
@ralphie9224
Apr 29 2015 22:41
it had mostly to co with the const declarations at the end of the functions
Martin Fracker, Jr.
@Towerism
Apr 29 2015 22:44
Ah I see yea const can sometimes be a bitch when you're dealing with libraries that may or may not use it when it should
Christopher Findeisen
@Atrus7
Apr 29 2015 22:47
ah, so it's fixed? Noice.
Rafael Moreno
@ralphie9224
Apr 29 2015 22:47
not yet
but i don't think it's as hard as i thought it'd be
Sam Gwydir
@gwydirsam
Apr 29 2015 23:04
@Towerism nooooooooooooooooooooooooooooooooooooooo
don't merge that please!
it messes up travis
also just throws a ton of warnings if you have two installs of openssl
ok my urgency was misplaced -- it wasn't merged
Martin Fracker, Jr.
@Towerism
Apr 29 2015 23:40
lol well it's kind of an issue since you have to run make install-deps and make install-openssl on build which goes against my own intuition
I understand you do things for a reason, which is why I created a pull request :P
I've learned from past mistakes lol
Sam Gwydir
@gwydirsam
Apr 29 2015 23:41
yeah you did the right thing
I jumped to the conclusion that it was arleady in develop
once it's in the travis cache it's a pain
generally one does not want to use an untrusted script to install openssl
so I think in general this is how it should be
Martin Fracker, Jr.
@Towerism
Apr 29 2015 23:42
Ok
Sam Gwydir
@gwydirsam
Apr 29 2015 23:42
otherwise you're kind of hijacking their security
tamu's servers are kind of rediculous in that they don't have a working install...
Martin Fracker, Jr.
@Towerism
Apr 29 2015 23:43
I see, well shouldn't make install-deps install openssl at least on build
Sam Gwydir
@gwydirsam
Apr 29 2015 23:43
hmmm
Martin Fracker, Jr.
@Towerism
Apr 29 2015 23:43
That's the only reason the pull request was a thing to begin with
Sam Gwydir
@gwydirsam
Apr 29 2015 23:43
we could
though I think actually I need to change the way we get openssl anyway
Martin Fracker, Jr.
@Towerism
Apr 29 2015 23:44
btw travis built the pull request fine
Sam Gwydir
@gwydirsam
Apr 29 2015 23:46
besides a bunch of annoying warnings it screws up curl
and therefore coverage
Martin Fracker, Jr.
@Towerism
Apr 29 2015 23:47
Ah okay
Sam Gwydir
@gwydirsam
Apr 29 2015 23:47
  branches...: 31.5% (965 of 3062 branches)
/home/travis/.rvm/rubies/ruby-1.9.3-p551/lib/ruby/1.9.1/net/http.rb:800:in `connect': SSL_connect returned=1 errno=0 state=SSLv3 read server certificate B: certificate verify failed (OpenSSL::SSL::SSLError)
    from /home/travis/.rvm/rubies/ruby-1.9.3-p551/lib/ruby/1.9.1/net/http.rb:800:in `block in connect'
    from /home/travis/.rvm/rubies/ruby-1.9.3-p551/lib/ruby/1.9.1/timeout.rb:55:in `timeout'
    from /home/travis/.rvm/rubies/ruby-1.9.3-p551/lib/ruby/1.9.1/timeout.rb:100:in `timeout'
    from /home/travis/.rvm/rubies/ruby-1.9.3-p551/lib/ruby/1.9.1/net/http.rb:800:in `connect'
    from /home/travis/.rvm/rubies/ruby-1.9.3-p551/lib/ruby/1.9.1/net/http.rb:756:in `do_start'
    from /home/travis/.rvm/rubies/ruby-1.9.3-p551/lib/ruby/1.9.1/net/http.rb:745:in `start'
    from /home/travis/.rvm/gems/ruby-1.9.3-p551/gems/coveralls-lcov-1.1.2/lib/coveralls/lcov/runner.rb:79:in `post'
    from /home/travis/.rvm/gems/ruby-1.9.3-p551/gems/coveralls-lcov-1.1.2/lib/coveralls/lcov/runner.rb:65:in `block in run'
    from /home/travis/.rvm/gems/ruby-1.9.3-p551/gems/coveralls-lcov-1.1.2/lib/coveralls/lcov/runner.rb:64:in `times'
    from /home/travis/.rvm/gems/ruby-1.9.3-p551/gems/coveralls-lcov-1.1.2/lib/coveralls/lcov/runner.rb:64:in `run'
    from /home/travis/.rvm/gems/ruby-1.9.3-p551/gems/coveralls-lcov-1.1.2/bin/coveralls-lcov:5:in `<top (required)>'
    from /home/travis/.rvm/gems/ruby-1.9.3-p551/bin/coveralls-lcov:23:in `load'
    from /home/travis/.rvm/gems/ruby-1.9.3-p551/bin/coveralls-lcov:23:in `<main>'
    from /home/travis/.rvm/gems/ruby-1.9.3-p551/bin/ruby_executable_hooks:15:in `eval'
    from /home/travis/.rvm/gems/ruby-1.9.3-p551/bin/ruby_executable_hooks:15:in `<main>'
make: [upload-coverage] Error 1 (ignored)
make[1]: Entering directory `/home/travis/build/gwydirsam/DickGrayson/debug'
make[2]: Entering directory `/home/travis/build/gwydirsam/DickGrayson/debug'
make[3]: Entering directory `/home/travis/build/gwydirsam/DickGrayson/debug'
make[4]: Entering directory `/home/travis/build/gwydirsam/DickGrayson/debug'
Scanning dependencies of target coveralls_generate
make[4]: Leaving directory `/home/travis/build/gwydirsam/DickGrayson/debug'
make[4]: Entering directory `/home/travis/build/gwydirsam/DickGrayson/debug'
[ 50%] Generating coveralls output...
that doesn't fail the build though
but yeah this was part of the coverage and openssl saga haha
Martin Fracker, Jr.
@Towerism
Apr 29 2015 23:48
Pretty dumb that tamu servers don't have openssl installed indeed
lol
Sam Gwydir
@gwydirsam
Apr 29 2015 23:48
they do...just doesn't work for some reason
Martin Fracker, Jr.
@Towerism
Apr 29 2015 23:48
oh
Sam Gwydir
@gwydirsam
Apr 29 2015 23:48
I have no idea why their servers are so weird
Martin Fracker, Jr.
@Towerism
Apr 29 2015 23:48
hmm
Sam Gwydir
@gwydirsam
Apr 29 2015 23:49
They should just give us VMs
I would be so happy
Martin Fracker, Jr.
@Towerism
Apr 29 2015 23:49
that would be pretty incredible. Btw do you know why coverage isn't checking stego crypt for coverage?
stego crypt lib actually
Sam Gwydir
@gwydirsam
Apr 29 2015 23:51
let me look into it
link me to a build that shows it
(the issue)