These are chat archives for halide/Halide

29th
Nov 2017
Steven Johnson
@steven-johnson
Nov 29 2017 00:06
turns out that its ‘test_generators’ in Make but ‘test_generator’ in CMake, because the latter is based on dir names. I’ll regularlize it later.
Steven Johnson
@steven-johnson
Nov 29 2017 17:23
did buildbot not run overnight? several pulls I fired off last night are now showing only 2 successful checks this morning (travis)
Shoaib Kamil
@shoaibkamil
Nov 29 2017 18:22
@steven-johnson My CMake-foo is weak, so I wasn't able to figure out how to get #2572 to run the added AOT test with CMake. It needs to use the same generator as acquire_release and, in addition, if on a macOS platform, link in libobjc. Is there a way to do this given the current CMake helpers?
Steven Johnson
@steven-johnson
Nov 29 2017 18:23
I’ll take a look.
Shoaib Kamil
@shoaibkamil
Nov 29 2017 18:24
Thanks! I'm sure it's just a matter of getting the right combination of parameters/helpers, but my initial tries failed miserably
Steven Johnson
@steven-johnson
Nov 29 2017 18:56
Heh: CMake doesn’t define TEST_METAL (or TEST_OPENCL etc), ever. I’ll fix that.
Shoaib Kamil
@shoaibkamil
Nov 29 2017 20:06
Ah, I suspected that might be the case, so I was setting it in my CMake command line
Andrew Adams
@abadams
Nov 29 2017 20:34
Autoscheduler is busted
Looks like it routinely accesses func.schedule().dims() to get dimensions
but that no longer exists for extern definitions
That list is the loop nest, not the dimensions
I think it used to be an empty vector for extern definitions, but am not 100% sure of that
@psuriana PTAL? I got confused about while trying to fix it, and am not confident I'm doing the right thing.
The broken test is auto_schedule_extern
Andrew Adams
@abadams
Nov 29 2017 22:02
Running a repo history cleaner tool on a fresh Halide checkout reduces size from 300M to 100M
by deleting large old blobs
Pushing this change rewrites all commits though. So everyone would have to do a force pull, or a fresh checkout, and rebase anything not-yet-pushed to github onto the new branches
Worth it?
Steven Johnson
@steven-johnson
Nov 29 2017 22:28
200M isn’t much these days
Steven Johnson
@steven-johnson
Nov 29 2017 22:34
@shoaibkamil I have a fix for you, I’ll push it somewhere shortly
Shoaib Kamil
@shoaibkamil
Nov 29 2017 22:46
Thanks!
Steven Johnson
@steven-johnson
Nov 29 2017 22:51
@shoaibkamil the changes are in halide/Halide@7181ff5 (cloned branch)
Shoaib Kamil
@shoaibkamil
Nov 29 2017 22:57
Thanks Steven, really appreciate it. Merged in with my PR, so hopefully the buildbots will be happy now
Steven Johnson
@steven-johnson
Nov 29 2017 22:59
I renamed it because while Make relies on HL_TARGET, CMake does not
Steven Johnson
@steven-johnson
Nov 29 2017 23:59
Is there a trick to get test/opengl to run properly on OSX? All of them fail for me with "Encountered invalid NULL dev pointer”. Missing an install? Botched OSX build instructions? Just doesn’t work?