Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 00:03
    steven-johnson opened #4400
  • Nov 12 23:49

    steven-johnson on srj-llvm-git

    Update Makefile (compare)

  • Nov 12 23:35
    steven-johnson review_requested #4393
  • Nov 12 23:34

    steven-johnson on master

    Fix set_host_alignment() in sim… Update simd_op_check_hvx.cpp Update simd_op_check.h and 1 more (compare)

  • Nov 12 23:34

    steven-johnson on srj-simd

    (compare)

  • Nov 12 23:34
    steven-johnson closed #4398
  • Nov 12 23:08

    steven-johnson on srj-wasm2

    Update Makefile (compare)

  • Nov 12 22:57

    steven-johnson on srj-wasm2

    WIP (compare)

  • Nov 12 22:06
    BachiLi commented #4399
  • Nov 12 22:06

    BachiLi on tzumao-gradient-autoscheduler-bug

    add test (compare)

  • Nov 12 22:01

    steven-johnson on srj-range

    Use Halide::Range instead of st… (compare)

  • Nov 12 21:44
    BachiLi edited #4399
  • Nov 12 21:42
    BachiLi synchronize #4399
  • Nov 12 21:42

    BachiLi on tzumao-gradient-autoscheduler-bug

    undo some changes (compare)

  • Nov 12 21:41
    BachiLi review_requested #4399
  • Nov 12 21:41
    BachiLi opened #4399
  • Nov 12 21:40

    BachiLi on tzumao-gradient-autoscheduler-bug

    Fix gradient autoscheduler's us… (compare)

  • Nov 12 20:46

    aekul on standalone_autoscheduler_gpu

    Revert changes to harris manual… (compare)

  • Nov 12 20:19

    aekul on standalone_autoscheduler_gpu

    Update apps to use gradient_aut… (compare)

  • Nov 12 19:32
    steven-johnson commented #4398
Dillon Sharlet
@dsharletg
how about overlapping copies to device with computation on host?
overlapping copies between device <-> host and computation on host I think covers the DMA use case
Andrew Adams
@abadams
Let me try that.
Andrew Adams
@abadams
deadlock, cool
Steven Johnson
@steven-johnson
clearly you have a different definition of “cool” in mind
Dillon Sharlet
@dsharletg
Is there a way to trigger the build bots for halide/Halide#2554 ? looks like it didn't happen automatically
other than just pushing a commit to it of course
Andrew Adams
@abadams
Turns out never releasing semaphores is a leading cause of deadlock
Steven Johnson
@steven-johnson
"neither train shall move until the other one has passed"
Zalman Stern
@zvookin
The DMA device doesn't ever compute in a strict sense
The current design has the copies always be synchronous
In fact copies are always that way right? When the copy returns it is done.
When we extend lowering of async to something other than semaphores and threads, we will likely need to expose asynchronous copies, and perhaps an entire event model in general.
Andrew Adams
@abadams
Yeah, but even if I make them async and ignore the problems that introduces, we're on a single stream
Zalman Stern
@zvookin
Well that's sort of true for Hexagon DMA if there's one engine.
I.e. yes for a device, but since the device is modeling a piece of hardware that has that restriction anyway, probably....
Andrew Adams
@abadams
I was initially trying to overlap device compute with device<->host copies. In the cuda backend this needs a lot more work for anything like that to happen.
Zalman Stern
@zvookin
In order to have DMA going both directions one needs two devices and those will not be a single stream.
Andrew Adams
@abadams
That's all I meant
Zalman Stern
@zvookin
So I think we need to keep the current model, but we should consider introducing a new one that allows much more asynchrony.
Whether that is just async versions of the copy routines or a full event model I'm not sure
I'm not sure it makes much sense to consider until we are looking at a different way of lowering async
I.e. in the current model, synchronous copy is probably required anyway. The thread doing it would just wait immediately if it wasn't synchronous.
"Event model" likely amounts to exposing the semaphore abstraction and arranging for it to be signaled by the device support code somehow
Andrew Adams
@abadams
Overlapping CPU computation with device stuff works fine. All use of the device_api occurs on a single thread. All the CPU compute occurs on another thread.
That's what I'm targeting for now
Zalman Stern
@zvookin
"CPU" is not necessarily correct there. It can be a different device too.
That is the common case for Hexagon right?
Andrew Adams
@abadams
For the hexagon DMA work so far, "CPU" is hexagon, and "device" is the dma engine
Zalman Stern
@zvookin
Ok, but the Hexagon may be invoked via offload.
Andrew Adams
@abadams
But yeah, I think it would work to have cross-device stuff going on in parallel
All use of each device interface would be on a single distinct thread
Zalman Stern
@zvookin
yes
Andrew Adams
@abadams
and there's no cross-device-interface serialization I think
so it would just work
Zalman Stern
@zvookin
That is what I was highlighting.
The only issue I see with this design is that the overhead of the thread may be too high to use for very lightweight hardware synchronization mechanisms. Other than that, I don't see a lot of reason to do the customized lowering.
I need to make a couple more changes to the hexagon DMA
Will try to do so today.
The test only calls buffer_copy, which is mostly as it should be.
Dillon Sharlet
@dsharletg
So BTW regarding hexagon offloading, I've been thinking we simply punt on that for now
and only target standalone
anything that we get working on standalone can be made to work with offloading without solving any "hard" problems like async + storage folding, it just might involve a lot of plumbing and infrastructure
Steven Johnson
@steven-johnson
re: the windows buildbots, proposed fix is out there.
Zalman Stern
@zvookin
I'll have to consider the implications, but I think the current stuff just works if the DMA things are scheduled inside an offloaded thing.
Dillon Sharlet
@dsharletg
I think there might be some hiccups with the device interface
that will need to get plumbed over via offloading
and I don't think that will happen transparently right now
it might be easy to make it work though
Zalman Stern
@zvookin
yeah, that's small boogs territory.