hanami/chat

Hello again!

This time around, I'm trying to implement a plain old file upload to import CSV files. In the action, the file upload's key appears as a string, in all cases I have tried.

I believed that calling #to_h or #validate and using #output from the result would return symbolized keys, but alas, that wasn't so:

(byebug) params.to_h
{:_csrf_token=>"c21e7616006db2729c88938a7108e621d9f94d1be071f55b4253c7910bf1b2a0", :import=>{"file"=>{:filename=>"a.csv", :type=>"text/csv", :name=>"import[file]", :tempfile=>#<Tempfile:/var/folders/1s/2rf_zh1970sdvk9w6yg2cyqm0000gn/T/RackMultipart20200813-85842-hj5evv.csv>, :head=>"Content-Disposition: form-data; name=\"import[file]\"; filename=\"a.csv\"\r\nContent-Type: text/csv\r\n"}}}
(byebug) params.validate
#<Dry::Validation::Result output={:_csrf_token=>"c21e7616006db2729c88938a7108e621d9f94d1be071f55b4253c7910bf1b2a0", :import=>{"file"=>{:filename=>"a.csv", :type=>"text/csv", :name=>"import[file]", :tempfile=>#<Tempfile:/var/folders/1s/2rf_zh1970sdvk9w6yg2cyqm0000gn/T/RackMultipart20200813-85842-hj5evv.csv>, :head=>"Content-Disposition: form-data; name=\"import[file]\"; filename=\"a.csv\"\r\nContent-Type: text/csv\r\n"}}} errors={}>
(byebug) params.validate.output
{:_csrf_token=>"c21e7616006db2729c88938a7108e621d9f94d1be071f55b4253c7910bf1b2a0", :import=>{"file"=>{:filename=>"a.csv", :type=>"text/csv", :name=>"import[file]", :tempfile=>#<Tempfile:/var/folders/1s/2rf_zh1970sdvk9w6yg2cyqm0000gn/T/RackMultipart20200813-85842-hj5evv.csv>, :head=>"Content-Disposition: form-data; name=\"import[file]\"; filename=\"a.csv\"\r\nContent-Type: text/csv\r\n"}}}

The form is declared with the minimal amount of fuss:

form_for :import, routes.import_people_path, enctype: "multipart/form-data" do
  file_field :file, required: true
end

The params declarations are done in-line, in the action:

params do
  required(:import).filled.schema do
    required(:file).filled.schema do
      required(:filename).filled(:str?)
      required(:tempfile).filled(size?: 1 .. 1_048_576)
      required(:type).filled(:str?, included_in?: %w(text/csv))
    end
  end
end

And the action's implementation is a simple:

def call(params)
  if params.valid?
    upload = @transaction_manager.transaction do
      # Hmmm, things that make you go "hmmm"...
      # Notice that we don't have a
      @upload_repository.create_upload_for_people_import(
        data: params[:import]["file"][:tempfile].read,
        name: params[:import]["file"][:filename],
        size: params[:import]["file"][:tempfile].size,
        type: params[:import]["file"][:type],
      )
  else
    self.status = 422
  end
end

The Hanami Guide is silent on the issue of file uploads. The only mention of the word "upload" is on the validations page, and then it is only a passing reference. Otherwise, "multipart" is mentionned in the mailer section, which isn't what I'm looking for.

I'm not interested in pre-packaged solutions for now, as I'm learning Hanami and how things are built on the inside. This is a learning opportunity, not a production implementation.

Thanks a bunch!