Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Feb 14 14:25
    Travis hawaiifw/hawaii-framework (feature/sql) broken (444)
  • Feb 14 14:21

    RutgerLubbers on sql

    Some fixes. (compare)

  • Feb 14 11:36

    RutgerLubbers on sql

    Do not always add sql statement… (compare)

  • Feb 12 13:13

    RutgerLubbers on sql

    Bumped version. (compare)

  • Feb 12 12:50

    RutgerLubbers on sql

    Fixed some warnings. (compare)

  • Feb 11 09:20

    RutgerLubbers on sql

    Added tags from start of span t… Merge branch 'feature/open-trac… (compare)

  • Feb 11 09:20

    RutgerLubbers on open-trace

    Added tags from start of span t… (compare)

  • Feb 07 15:20
    Travis hawaiifw/hawaii-framework@3bc9eb5 (feature/sql) passed (438)
  • Feb 07 15:09

    RutgerLubbers on sql

    Split query execution listener … (compare)

  • Feb 07 09:54

    RutgerLubbers on open-trace

    Updated. (compare)

  • Feb 06 11:25

    RutgerLubbers on open-trace

    Added some documentation for op… (compare)

  • Feb 05 16:14
    Travis hawaiifw/hawaii-framework (feature/open-trace) fixed (435)
  • Feb 05 16:08

    RutgerLubbers on open-trace

    Fixed test. (compare)

  • Feb 05 16:07
    Travis hawaiifw/hawaii-framework (feature/open-trace) broken (434)
  • Feb 05 16:03

    RutgerLubbers on open-trace

    Added default 'hawaii.logging.o… Removed default file logging. (compare)

  • Feb 05 15:57

    RutgerLubbers on open-trace

    Added opentracing logging, this… (compare)

  • Feb 05 14:57
    Travis hawaiifw/hawaii-framework (feature/open-trace) passed (432)
  • Feb 05 14:51

    RutgerLubbers on open-trace

    Does not work... Finish span. Added headers. and 1 more (compare)

  • Jan 31 10:04

    RutgerLubbers on gh-pages

    Bumped version of 3.0.0 to M10 (compare)

  • Jan 29 11:31

    paulklos on gh-pages

    Travis build 431 pushed docs to… (compare)

Marcel Overdijk
@marceloverdijk
Welcome to the Hawaii Framework room!
Marcel Overdijk
@marceloverdijk
Marcel Overdijk
@marceloverdijk
Pushed some basic website @ http://www.hawaiiframework.org/
Marcel Overdijk
@marceloverdijk
I think we should make a choice on a formatting style...
Instead of inventing our own style I think we should adopt one widely used.
The Spring Framework style is based on the Google Java Style. The Google Java Style is available at: https://github.com/google/styleguide
It already contains style formatters for both Eclipse and IDEA.
There is also already a checkstyle configuration available at https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/google_checks.xml
I will give them a try shortly, but if there is any objection, shout :-D
Wouter Eerdekens
@retuow
I had a quick read of the style guide, looks good to me...
Jonathan1
@Jonathan1
Yep i agree, seems fine
Richard.den.Adel
@Drahcir
If I want to add the decisions that we took yesterday, which ascii doc file would be the one ? development-guide
Marcel Overdijk
@marceloverdijk
@Drahcir I'm working on a contributing readme which contains information like code style, pull request workflow etc. I think we can capture the development guidelines there as well. Probably have it ready tomorrow so you can add it then. Ok?
Marcel Overdijk
@marceloverdijk
I've added a CONTRIBUTING readme referenced from the GitHub project page: https://github.com/hawaiifw/hawaii-framework/blob/master/CONTRIBUTING.md
It contains information regarding code style, github workflow etc.
@Drahcir There is also a Development Guidelines section with a TODO ;-)
I've also implemented the Hawaii Framework Java Style today which i currently a plain copy of the Google Java Style
Marcel Overdijk
@marceloverdijk
Both IDEA and Eclipse code formatters are added to the project as also documented on the https://github.com/hawaiifw/hawaii-framework/blob/master/CONTRIBUTING.md page
And to make it complete also checkstyle is added to the Gradle build to verify our code style
In theory this should be done and dusted..... but...
After I got - and still have - a lot of checkstyle warning I found out that the IDEA Google Java Style formatter has not been updated in ages :-( (note that this file is coming from an official Google Code Style repo)
I will tweak the code formatter tomorrow or later this week.... so please be a little patient with importing the code formatters for a bit!
Wouter Eerdekens
@retuow
Since 4.3, Spring offers annotations like @PostMapping, GetMapping that are equivalent to the @Post, @Get annotations in Hawaii Framework (eg. an alias for @RequestMapping(method = POST), ...)
While I do prefer the name @Post to @PostMapping it doesn't make sense to keep holding on to them, since they do not provide any added functionality compared to the annotations introduced in Spring 4.3
thoughts?
paulklos
@paulklos
Agreed, I'd say let's deprecate our annotations and move to the Spring ones
Marcel Overdijk
@marceloverdijk
Yes we can use the Spring ones now, there were some subtile differences in the past (as I remember correctly) as the Spring ones changed a bit in their process incubating them in the Spring Framework from https://jira.spring.io/browse/SPR-13992
Note that we also have @Head, @Options and @Trace in HF (although we don't use them yet) which are not available in Spring
Anyway good to remove in the next milestone I would say :-)
Wouter Eerdekens
@retuow
perhaps it's a good way, as @paulklos suggested to just deprecate our annotations in favour of those in Spring
Marcel Overdijk
@marceloverdijk
don't see the advantage of deprecating, as we have no GA release anyway; and during milestone releases we can change.
I think we should delete them at least before a RC one day :-)
Wouter Eerdekens
@retuow
ok