Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Sep 22 07:31

    paulklos on gh-pages

    Travis build 473 pushed docs to… (compare)

  • Sep 22 07:22

    retuow on master

    Also log request if there is no… Merge pull request #56 from ret… (compare)

  • Sep 22 07:22
    retuow closed #56
  • Sep 22 07:08
    retuow closed #48
  • Sep 22 07:08
    retuow commented #48
  • Sep 21 14:25
    retuow review_requested #56
  • Sep 21 14:25
    retuow review_requested #56
  • Sep 21 14:25
    retuow opened #56
  • Apr 21 07:07

    paulklos on gh-pages

    Travis build 471 pushed docs to… (compare)

  • Apr 21 06:59

    RutgerLubbers on Logging

    (compare)

  • Apr 21 06:59

    RutgerLubbers on master

    Needs to be implementation Consolidated http logging of re… Instantiate default logger bean… and 6 more (compare)

  • Apr 21 06:59
    RutgerLubbers closed #55
  • Apr 16 10:05
    mgeuns review_requested #55
  • Apr 16 06:59

    paulklos on gh-pages

    Travis build 470 pushed docs to… (compare)

  • Apr 16 06:51
    mgeuns synchronize #55
  • Apr 16 06:51

    mgeuns on Logging

    Make logContent private Removed separation of setting l… (compare)

  • Apr 15 09:23
    paulklos review_requested #55
  • Apr 15 07:15
    mgeuns review_requested #55
  • Apr 15 07:15
    mgeuns review_requested #55
  • Apr 15 07:15
    mgeuns review_requested #55
Marcel Overdijk
@marceloverdijk
I will give them a try shortly, but if there is any objection, shout :-D
Wouter Eerdekens
@retuow
I had a quick read of the style guide, looks good to me...
Jonathan1
@Jonathan1
Yep i agree, seems fine
Richard.den.Adel
@Drahcir
If I want to add the decisions that we took yesterday, which ascii doc file would be the one ? development-guide
Marcel Overdijk
@marceloverdijk
@Drahcir I'm working on a contributing readme which contains information like code style, pull request workflow etc. I think we can capture the development guidelines there as well. Probably have it ready tomorrow so you can add it then. Ok?
Marcel Overdijk
@marceloverdijk
I've added a CONTRIBUTING readme referenced from the GitHub project page: https://github.com/hawaiifw/hawaii-framework/blob/master/CONTRIBUTING.md
It contains information regarding code style, github workflow etc.
@Drahcir There is also a Development Guidelines section with a TODO ;-)
I've also implemented the Hawaii Framework Java Style today which i currently a plain copy of the Google Java Style
Marcel Overdijk
@marceloverdijk
Both IDEA and Eclipse code formatters are added to the project as also documented on the https://github.com/hawaiifw/hawaii-framework/blob/master/CONTRIBUTING.md page
And to make it complete also checkstyle is added to the Gradle build to verify our code style
In theory this should be done and dusted..... but...
After I got - and still have - a lot of checkstyle warning I found out that the IDEA Google Java Style formatter has not been updated in ages :-( (note that this file is coming from an official Google Code Style repo)
I will tweak the code formatter tomorrow or later this week.... so please be a little patient with importing the code formatters for a bit!
Wouter Eerdekens
@retuow
Since 4.3, Spring offers annotations like @PostMapping, GetMapping that are equivalent to the @Post, @Get annotations in Hawaii Framework (eg. an alias for @RequestMapping(method = POST), ...)
While I do prefer the name @Post to @PostMapping it doesn't make sense to keep holding on to them, since they do not provide any added functionality compared to the annotations introduced in Spring 4.3
thoughts?
paulklos
@paulklos
Agreed, I'd say let's deprecate our annotations and move to the Spring ones
Marcel Overdijk
@marceloverdijk
Yes we can use the Spring ones now, there were some subtile differences in the past (as I remember correctly) as the Spring ones changed a bit in their process incubating them in the Spring Framework from https://jira.spring.io/browse/SPR-13992
Note that we also have @Head, @Options and @Trace in HF (although we don't use them yet) which are not available in Spring
Anyway good to remove in the next milestone I would say :-)
Wouter Eerdekens
@retuow
perhaps it's a good way, as @paulklos suggested to just deprecate our annotations in favour of those in Spring
Marcel Overdijk
@marceloverdijk
don't see the advantage of deprecating, as we have no GA release anyway; and during milestone releases we can change.
I think we should delete them at least before a RC one day :-)
Wouter Eerdekens
@retuow
ok