And what will happen if i will do Bundle.load for two different classes with same custom name? Based on generated code and dependencies it looks ok, but is it supported functionality?) @elsassph
Cause in this case it start looks very similar with Bundle.loadLib
Er 2 bundles with the same custom name will break - it will be your fault :D
I thought you just wanted to rename the bundle file.
Because right now for you it's working because it's using under the hood the
loadLib feature, which means it has the lib limitation of having to be loaded from the main bundle.
I'm fixing it by having a different mechanism to alias a bundle
But i'm trying also to solve another logic which i want to have. And it's mostly related to how we do on-demand features
after tweaking my webpack config loading any bundles fails with:
ReferenceError: "HxOverrides is not defined"
./node_modules/haxe-loader/index.js?build/view_DashBoard!.//< https://domain.de/js/view_DashBoard.js:1268
./node_modules/haxe-loader/index.js?build/view_DashBoard!./ https://domain.de/js/view_DashBoard.js:1342
__webpack_require__ https://domain.de/js/app.js:791
fn https://domain.de/js/app.js:151
t https://domain.de/js/app.js:195
app.js:13340:21
loadBundle https://domain.de/js/app.js:13340
What version of Haxe do you use?
@elsassph First of all I'd like to say thanks for you effort for making this project.
We have adopted haxe-modular more than a year ago for splitting our js code.
And it has worked perfectly until we updated to Haxe 4.1.3 from Haxe 4.0.5.
Now we are getting Uncaught ReferenceError: HxOverrides is not defined in the app.
Disabling of splitting with -D modular_stub is a working workaround.
haxe-modular version is 0.12.0
We have adopted haxe-modular more than a year ago for splitting our js code.
And it has worked perfectly until we updated to Haxe 4.1.3 from Haxe 4.0.5.
Now we are getting Uncaught ReferenceError: HxOverrides is not defined in the app.
Disabling of splitting with -D modular_stub is a working workaround.
haxe-modular version is 0.12.0
@Maksim-Zhuravlev @axelhuizinga can you try my upgrade branch: jasononeil/webpack-haxe-loader#69 which points to
haxe-modular 0.12.0 which was actually released a little while ago.
Oh
No yeah thats the haxe-modular npm module you need to update as well to 0.12. Is that what you have already?
Updated to 0.12.0
The error is still there
including
HxOverrides.now = function() {
return Date.now();
};
HxOverrides.now = function() {
return Date.now();
};
The extracted bundle contains
if(typeof(performance) != "undefined" ? typeof(performance.now) == "function" : false) {
HxOverrides.now = performance.now.bind(performance);
}
if(typeof(performance) != "undefined" ? typeof(performance.now) == "function" : false) {
HxOverrides.now = performance.now.bind(performance);
}
And deletion of this piece makes it work
@Maksim-Zhuravlev can you please try this modular PR? You need to install haxe-modular npm from this git branch: elsassph/haxe-modular#106
Works fine!
@axelhuizinga FYI
This should fix Haxe 4.1.3 support
gives me:
WARNING in ./build.hxml
Invalid dependencies have been reported by plugins or loaders for this module. All reported dependencies need to be absolute paths.
Invalid dependencies may lead to broken watching and caching.
As best effort we try to convert all invalid values to absolute paths and converting globs into context dependencies, but this is deprecated behavior.
Loaders: Pass absolute paths to this.addDependency (existing files), this.addMissingDependency (not existing files), and this.addContextDependency (directories).
Plugins: Pass absolute paths to fileDependencies (existing files), missingDependencies (not existing files), and contextDependencies (directories).
Globs: They are not supported. Pass absolute path to the directory as context dependencies.
The following invalid values have been reported:
WARNING in ./build.hxml
Invalid dependencies have been reported by plugins or loaders for this module. All reported dependencies need to be absolute paths.
Invalid dependencies may lead to broken watching and caching.
As best effort we try to convert all invalid values to absolute paths and converting globs into context dependencies, but this is deprecated behavior.
Loaders: Pass absolute paths to this.addDependency (existing files), this.addMissingDependency (not existing files), and this.addContextDependency (directories).
Plugins: Pass absolute paths to fileDependencies (existing files), missingDependencies (not existing files), and contextDependencies (directories).
Globs: They are not supported. Pass absolute path to the directory as context dependencies.
The following invalid values have been reported:
* "."
16 replies