These are chat archives for highfidelity/hifi

10th
Mar 2014
Dimitar Dobrev
@ddobrev
Mar 10 2014 14:59
Hi all.
Can someone tell me if I have permission to push?
Leonardo Murillo
@murillodigital
Mar 10 2014 15:01
@ddobrev the process we follow is, you work off your fork of the repo, you push to your fork, and when you consider your code to be “production ready” you need to open up a pull requet
request
Dimitar Dobrev
@ddobrev
Mar 10 2014 15:01
@murillodigital - right, thanks.
Leonardo Murillo
@murillodigital
Mar 10 2014 15:01
that request will be reviewed, and once the reviewer together with yourself have worked out any issues, the reviewer (who does have merge privileges to master repo) will push to master
np ;)
Dimitar Dobrev
@ddobrev
Mar 10 2014 15:44
@murillodigital - I mentioned in a comment that I still have two features to add.
But now that I've pushed, I assume it would be better to apply the necessary changes, if any, after reviewing, first.
What do you think?
Stephen Birarda
@birarda
Mar 10 2014 15:52
@ddobrev is it currently in a functional state?
Dimitar Dobrev
@ddobrev
Mar 10 2014 15:53
@birarda - yes, it is.
Stephen Birarda
@birarda
Mar 10 2014 15:54
awesome
typically for worklist jobs we would merge once all pieces are done
but it’s going to be great to have chat support added
have you made any changes to qxmpp?
Dimitar Dobrev
@ddobrev
Mar 10 2014 15:55
@birarda - none at all.
Stephen Birarda
@birarda
Mar 10 2014 15:55
we’re going to want it not in the repository but as an external lib
Dimitar Dobrev
@ddobrev
Mar 10 2014 15:56
@birarda - I see, I'll change it then.
Stephen Birarda
@birarda
Mar 10 2014 15:56
well, up to you
that’s outside the scope of your jobn
job*
so somebody can do the removal of the library as a separate job
or you can take care of it - ideally people will build qxmpp from source
Dimitar Dobrev
@ddobrev
Mar 10 2014 15:58
@birarda - let me check with @problem about the two missing pieces. If they are not that important at the moment, I'll separate the lib first.
Stephen Birarda
@birarda
Mar 10 2014 15:58
okay - you’ll have to write a find module that finds qxmpp in whatever place depending on the platform
a CMake findmodule
again, the separation of the lib is outside the scope of this job - so if you’d rather just have this merged in once reviewed then somebody can go in and do the removal work
Dimitar Dobrev
@ddobrev
Mar 10 2014 15:59
@birarda - I'm not that deeply familiar with CMake but I guess I can copy the pieces for, say, GLM, and adjust.
Stephen Birarda
@birarda
Mar 10 2014 16:00
let’s leave the library separation for now - it will be easier for me to work with @murillodigital and figure out where we want qxmpp on the various platforms
Dimitar Dobrev
@ddobrev
Mar 10 2014 16:00
@birarda - OK. Feel free to tell me as soon as you need it separated.
Stephen Birarda
@birarda
Mar 10 2014 16:01
what platform are you on?
Dimitar Dobrev
@ddobrev
Mar 10 2014 16:01
@birarda - OS X.
Stephen Birarda
@birarda
Mar 10 2014 16:01
awesome
why don’t you build and install qxmpp on your machine (I’m doing the same now)
Dimitar Dobrev
@ddobrev
Mar 10 2014 16:03
@birarda - to check if the project build with no source dependencies?
Stephen Birarda
@birarda
Mar 10 2014 16:03
just a sec, sorry
just trying to figure out the best way to separate the library out
how simple would it be to conditionally define out the chat code depending on the presence of qxmpp
something like what we do for sixense or the oculus
okay - forget I said anything
let’s work together to make it an external lib in your pull request
can you go ahead and build from source so it’s in /usr/local?
Dimitar Dobrev
@ddobrev
Mar 10 2014 16:07
@birarda - OK.
Stephen Birarda
@birarda
Mar 10 2014 16:08
I am doing the same
we should be able to write a find module that applies to both linux and OS X (since they’re both dropping into /usr/local)
windows will be a bit trickier
Dimitar Dobrev
@ddobrev
Mar 10 2014 16:10
@birarda - wouldn't it be better to use the oculus/GLM approach - just point a CMake variable to the source path?
Stephen Birarda
@birarda
Mar 10 2014 16:10
that’s passing that variable to a find module
so we still need a find module
I’m writing up a quick one now to get us started
Stephen Birarda
@birarda
Mar 10 2014 16:17
@mr
@murillodigital can you get qxmpp on the unix and windows box?
Leonardo Murillo
@murillodigital
Mar 10 2014 16:17
yah
Stephen Birarda
@birarda
Mar 10 2014 16:17
@ddobrev here’s a find module you can put in cmake/modules/FindQxmpp.cmake
ugh
let me gist it
assuming a qxmpp install to default prefix path that should find it on mac and linux
so in cmakelists you need to do the following
find_package(qxmpp REQUIRED)
then you should have
QXMPP_INCLUDE_DIR and QXMPP_LIBRARY variables
include_directories(SYSTEM QXMPP_INCLUDE_DIR)
whoops
Dimitar Dobrev
@ddobrev
Mar 10 2014 16:20
@birarda - so like LibOVR.
Stephen Birarda
@birarda
Mar 10 2014 16:20
yep
exactly
except that LibOVR is not required
this will be
Dimitar Dobrev
@ddobrev
Mar 10 2014 16:21
@birarda - would the updated script compile and install qxmpp if the developer does not have it yet?
Stephen Birarda
@birarda
Mar 10 2014 16:21
it won’t - that’s dev’s responsibility
Dimitar Dobrev
@ddobrev
Mar 10 2014 16:21
@birarda - I see.
Stephen Birarda
@birarda
Mar 10 2014 16:21
once your work is merged I’ll go ahead and update the build guide
Dimitar Dobrev
@ddobrev
Mar 10 2014 16:21
We should update Build.md then.
Stephen Birarda
@birarda
Mar 10 2014 16:22
exactly
so qxmpp ~> 0.7.6 is a dep
with a link
Dimitar Dobrev
@ddobrev
Mar 10 2014 16:22
OK, I am a bit busy, so I can start in about 10 to 15 minutes.
Stephen Birarda
@birarda
Mar 10 2014 16:22
not a problem
we also need to add a definition for QXMPP_STATIC
so call
add_definitions(-DQXMPP_STATIC) after the find_package
Dimitar Dobrev
@ddobrev
Mar 10 2014 17:14
@birarda - the headers must now be included with qxmpp/ - #include <qxmpp/QXmppClient.h>. Is it possible to change QXMPP_INCLUDE_DIR so that they can be included the old way?
Stephen Birarda
@birarda
Mar 10 2014 17:15
yep
that’s weird - I thought that QXMPP_INCLUDE_DIR gave
/usr/local/include/qxmpp?
not /usr/local/include
Dimitar Dobrev
@ddobrev
Mar 10 2014 17:15
It does, I checked in my CMakeCache.
But it wouldn't work nevertheless.
I can see it there: QXMPP_INCLUDE_DIR:PATH=/usr/local/include/qxmpp
Stephen Birarda
@birarda
Mar 10 2014 17:16
that’s weird
Dimitar Dobrev
@ddobrev
Mar 10 2014 17:17
I'll try deleting the whole build dir and regenerate. More often than it should this 'fixes' CMake.
Stephen Birarda
@birarda
Mar 10 2014 17:18
have you set
include_directories(${QXMPP_INCLUDE_DIR})
because /usr/local/include is probably already being included
which is why qxmpp/HEADER works
but we’ll need to include the other specifically
Dimitar Dobrev
@ddobrev
Mar 10 2014 17:20
@birarda - my mistake, I had include_directories(QXMPP_INCLUDE_DIR) instead.
Stephen Birarda
@birarda
Mar 10 2014 17:20
ahh
also make that
include_directories(SYSTEM ${QXMPP_INCLUDE_DIR})
so that if qxmpp is generating warnings we don’t get em
there was an issue before with Xcode not listening to the system flag
which is why in some places there’s also a CMAKE_CXX_FLAGS
SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -isystem ${SIXENSE_INCLUDE_DIRS}”)
Dimitar Dobrev
@ddobrev
Mar 10 2014 17:24
@birarda - I see.
Stephen Birarda
@birarda
Mar 10 2014 17:24
but you can assume you don’t need that - if it’s still showing warnings then we can add that as weell
well*
make sure that find_package(qxmpp REQUIRED) has that required flag
Dimitar Dobrev
@ddobrev
Mar 10 2014 17:30
I get a linking error, missing symbols. Is it possible that's because my qxmpp is build in Debug mode?
is built*
Stephen Birarda
@birarda
Mar 10 2014 17:30
hmm
you have a command target_link_libraries(${TARGET_NAME} ${QXMPP_LIBRARY})
right?
Dimitar Dobrev
@ddobrev
Mar 10 2014 17:31
Yes.
I didn't have that and it gave a different error: -lqxmpp missing.
Let me check the bitness.
Stephen Birarda
@birarda
Mar 10 2014 17:31
the missing symbols are qxmpp symbols?
Dimitar Dobrev
@ddobrev
Mar 10 2014 17:32
Yes.
Stephen Birarda
@birarda
Mar 10 2014 17:32
and are there and shared libraries linking qxmpp (I’d imagine not)
Dimitar Dobrev
@ddobrev
Mar 10 2014 17:33
I have shared ones too. Let me try deleting them.
Stephen Birarda
@birarda
Mar 10 2014 17:33
maybe I was unclear
I mean
are there any hifi libraries that need wxmpp
qxmpp*
Dimitar Dobrev
@ddobrev
Mar 10 2014 17:34
Yes, interface, but it fails on animation-server which doesn't use qxmpp at all.
Let me try something, I think I know what the problem is.
Stephen Birarda
@birarda
Mar 10 2014 17:35
yeah - that seems incorrect if animation-server is complaining
Dimitar Dobrev
@ddobrev
Mar 10 2014 17:37
It's fine.
I just had to include Qt5Xml, I remembered qxmpp required it.
Dimitar Dobrev
@ddobrev
Mar 10 2014 17:55
OK, done. I'll try amending the build integration commit and if that works well, I'll close the pull and open a new one.
Stephen Birarda
@birarda
Mar 10 2014 17:55
sounds good!
@murillodigital will need to have put qxmpp on the build machines for the build to pass
Leonardo Murillo
@murillodigital
Mar 10 2014 17:56
2 out of 3 have it
about to finish up windows
mac & ubuntu been set for a few minutes already
windows just finished
@birarda ^
Stephen Birarda
@birarda
Mar 10 2014 17:57
gracias
Leonardo Murillo
@murillodigital
Mar 10 2014 17:57
con gusto
Dimitar Dobrev
@ddobrev
Mar 10 2014 18:06
Well, I had some rebasing fun, let's see if it works now.
Stephen Birarda
@birarda
Mar 10 2014 18:07
in the future feel free to just add multiple commits
you can certainly have more than one commit per pull request
rebasing can be fun
but also a really good way to completely shoot yourself in the foot
Dimitar Dobrev
@ddobrev
Mar 10 2014 18:08
I think it was worth it because one of the commits would add tonnes of files that the other would delete.
So if it worked, it would be better.
Stephen Birarda
@birarda
Mar 10 2014 18:12
well, that’s a good point
Dimitar Dobrev
@ddobrev
Mar 10 2014 18:13
@murillodigital - about Linux, I guess you've seen the build failed there. I think sth is wrong with CMake's automoc.
It said ui_chatWindow.h was missing - that's a generated from a *.ui file code.
Leonardo Murillo
@murillodigital
Mar 10 2014 18:15
@ddobrev have not checked, what build # is it?
Leonardo Murillo
@murillodigital
Mar 10 2014 18:17
huh maybe we need to clean up that build/ dir for the new .ui to be turned into its respective .h
by cmake
Leonardo Murillo
@murillodigital
Mar 10 2014 18:35
@ddobrev same fail in ubuntu — clean workspace, definitely something in code/cmake code needs to be reviewed
Stephen Birarda
@birarda
Mar 10 2014 18:35
@ddobrev are you wrapping that ui file with
qt5_wrap_ui
Dimitar Dobrev
@ddobrev
Mar 10 2014 18:36
@birarda - I don't. It works fine here on OS X so I assumed CMake's automoc or similar does the job.
Stephen Birarda
@birarda
Mar 10 2014 18:36
check line 71 of interface CmakeLists
Dimitar Dobrev
@ddobrev
Mar 10 2014 18:36
I believe I've seen some script that collects all *.ui-s and handles them.
Stephen Birarda
@birarda
Mar 10 2014 18:37
make sure your ui is grabbed by line 69
is it matched by ui/*.ui
in interface?
Dimitar Dobrev
@ddobrev
Mar 10 2014 18:39
@birarda - it is. I've added a single *.ui and it's in the ui dir, next to updateDialog.
But I can see even the OS X build fails now, it cannot find qxmpp.
Stephen Birarda
@birarda
Mar 10 2014 18:40
where’s qxmpp on that box @murillodigital ?
the shared lib dir?
Leonardo Murillo
@murillodigital
Mar 10 2014 18:41
yeah, which is the new standard
HIFI_LIB_DIR/qxmpp/
Stephen Birarda
@birarda
Mar 10 2014 18:42
question @ddobrev - why is qxmpp linked in shared?
ahh - because it’s in the account manager
I don’t think we want to do that
we should instead use the signals from the account manager to only have it connect and disconnect in interface
we also don’t need want the find_package in the root cmakelists
just in interface
Dimitar Dobrev
@ddobrev
Mar 10 2014 18:44
@birarda - OK, starting.
Stephen Birarda
@birarda
Mar 10 2014 18:44
sorry about that
Dimitar Dobrev
@ddobrev
Mar 10 2014 18:44
@birarda - no problem, I take it as a part of the review.
@birarda - now that I'm going to refactor, I think it's best we discussed the final solution.
Stephen Birarda
@birarda
Mar 10 2014 18:49
you’re talking about the two other parts or something else?
Dimitar Dobrev
@ddobrev
Mar 10 2014 18:50
About where the XMPP code would reside.
I would suggest a new class, in shared, to contain it.
We could call it XmppChat or XmppServer or sth.
Stephen Birarda
@birarda
Mar 10 2014 18:50
you mean for the purposes of connecting and disconnecting?
Dimitar Dobrev
@ddobrev
Mar 10 2014 18:50
Yes.
Stephen Birarda
@birarda
Mar 10 2014 18:50
for now we don’t need the chat anywhere but in interface
so it would be best to add that class to interface/src
otherwise it gets included in domain-server and assignment-client unecessarily
Dimitar Dobrev
@ddobrev
Mar 10 2014 18:51
@birarda - OK.
Stephen Birarda
@birarda
Mar 10 2014 18:52
I imagine it is possible we may eventually want bots to chat
but that’s far off for now
or to be able to have a domain server handle commands in the chat or something like that
but for now just in interface will be great
Dimitar Dobrev
@ddobrev
Mar 10 2014 19:56
@birarda - the build works fine here but seems unable to find qxmpp on the server - https://jenkins.below92.com/job/hifi-pull-request-mac/421/console .
Have you reached an agreement with @murillodigital ? Perhaps the finding script should be updated?
Stephen Birarda
@birarda
Mar 10 2014 19:57
can you fix something in the FindQxmpp script
I screwed something up
line 40
line 36 and line 40
should be
endif ()
that will fix the complaint about mismatching arguments
Dimitar Dobrev
@ddobrev
Mar 10 2014 20:00
@birarda - OK.
Stephen Birarda
@birarda
Mar 10 2014 20:00
not that it will solve both but let’s start with that
Dimitar Dobrev
@ddobrev
Mar 10 2014 20:01
Done.
Stephen Birarda
@birarda
Mar 10 2014 20:01
alright let’s let that test run and then take a look
Dimitar Dobrev
@ddobrev
Mar 10 2014 20:03
@birarda - the same error, cannot find qxmpp.
Stephen Birarda
@birarda
Mar 10 2014 20:03
okay @murillodigital confirm the folder structure on that box?
Leonardo Murillo
@murillodigital
Mar 10 2014 20:05
/usr/share/hifi/libs/qxmpp$ ll
total 20
drwxr-xr-x 5 root root 4096 Mar 10 17:25 ./
drwxr-xr-x 6 root root 4096 Mar 10 17:25 ../
drwxr-xr-x 3 root root 4096 Mar 10 17:25 include/
drwxr-xr-x 3 root root 4096 Mar 10 17:25 lib/
drwxr-xr-x 3 root root 4096 Mar 10 17:25 share/
@birarda what’s the structure you expect under include?
Stephen Birarda
@birarda
Mar 10 2014 20:07
include/qxmpp/QXmppClient.h
Leonardo Murillo
@murillodigital
Mar 10 2014 20:08
yes that is correct
Stephen Birarda
@birarda
Mar 10 2014 20:08
odd
let me install to that dir on my machine and try the find module that way
oh wait
@ddobrev
change find_library in 25 and 27 to
change the whole module to the updated gist
Stephen Birarda
@birarda
Mar 10 2014 20:13
the find_library line wasn’t looking in lib
which worked when it’s in your path
but not for ENV{HIFI_LIB_DIR}
Dimitar Dobrev
@ddobrev
Mar 10 2014 20:26
@birarda - the OS X build is fine, Linux failed again.
Cannot find the lib.
Stephen Birarda
@birarda
Mar 10 2014 20:31
@murillodigital linux setup is what
Leonardo Murillo
@murillodigital
Mar 10 2014 20:31
?
Stephen Birarda
@birarda
Mar 10 2014 20:31
ahh @ddobrev
it didn’t fail to find lib it failed to find find moudle
module
it’s looking for
Findqxmpp
so when you call find_package
do
find_package(Qxmpp REQUIRED)
not find_package(qxmpp REQUIRED))
Andrew Meadows
@AndrewMeadows
Mar 10 2014 20:58
I'm going to try to switch our system to use radians everywhere instead of degrees.
The time has come.
Stephen Birarda
@birarda
Mar 10 2014 20:59
yay
Dimitar Dobrev
@ddobrev
Mar 10 2014 21:22
@birarda - the Linux build is fine too. Only the Windows one reamins.
remains*
It cannot find the lib there.
Stephen Birarda
@birarda
Mar 10 2014 21:24
looking
@murillodigital on win build what is name of lib?
Leonardo Murillo
@murillodigital
Mar 10 2014 21:25
C:\dev\libs\qxmpp\include\qxmpp
Stephen Birarda
@birarda
Mar 10 2014 21:25
the lib
itself
\lib\what
Leonardo Murillo
@murillodigital
Mar 10 2014 21:25
qxmpp0.dll
Stephen Birarda
@birarda
Mar 10 2014 21:25
did you build a static lib
Leonardo Murillo
@murillodigital
Mar 10 2014 21:26
and .lib
Stephen Birarda
@birarda
Mar 10 2014 21:26
QXMPP_LIBRARY_TYPE=staticlib
we don’t want that dll
Leonardo Murillo
@murillodigital
Mar 10 2014 21:26
I built same as I built on the other 2 boxes
and that is not staticlib
Stephen Birarda
@birarda
Mar 10 2014 21:26
with QXMPP_LIBRARY_TYPE=staticlib
okay so you need to do that
otherwise we will crash on run
Leonardo Murillo
@murillodigital
Mar 10 2014 21:26
on all? or just windows?
Stephen Birarda
@birarda
Mar 10 2014 21:26
all
Leonardo Murillo
@murillodigital
Mar 10 2014 21:27
k
Stephen Birarda
@birarda
Mar 10 2014 21:27
@ddobrev here is gist updated to find lib on windows
my bad @murillodigital didn’t mention
Leonardo Murillo
@murillodigital
Mar 10 2014 21:27
no worries
give me a few minutes though
Dimitar Dobrev
@ddobrev
Mar 10 2014 21:29
@murillodigital - please let me know when done so that I can push.
Leonardo Murillo
@murillodigital
Mar 10 2014 21:30
I think you can push already, it should find and build (albeit not run) but if cmake finds it alright then we can merge once I’m done, correct @birarda ?
in other words, PR build should succeed regardless of static lib or not, I should have built statically prior to merging
@birarda ^
Dimitar Dobrev
@ddobrev
Mar 10 2014 21:32
@murillodigital - it's no problem, I can wait. I'd rather try with the static lib, Lord knows what else might happen otherwise.
Leonardo Murillo
@murillodigital
Mar 10 2014 21:33
cool
Dimitar Dobrev
@ddobrev
Mar 10 2014 22:40
@murillodigital - are the static libs ready?
Leonardo Murillo
@murillodigital
Mar 10 2014 22:43
@ddobrev on one out of 3 boxes
and I need to run out
I’ll let you all know when ready later today
Dimitar Dobrev
@ddobrev
Mar 10 2014 22:44
@murillodigital - thanks.
@murillodigital - which box is that, the Windows one?
Leonardo Murillo
@murillodigital
Mar 10 2014 22:48
nope ubuntu
err
mac
Dimitar Dobrev
@ddobrev
Mar 10 2014 23:14
@birarda - the build is fine.
Stephen Birarda
@birarda
Mar 10 2014 23:14
awesome!
sorry about all that hassle
Leonardo Murillo
@murillodigital
Mar 10 2014 23:14
@birarda @ddobrev do not merge until i’m done, which will be in a little when im done parenting
i’ll advise
Dimitar Dobrev
@ddobrev
Mar 10 2014 23:16
@birarda - you could check if the structure is OK now. There's a new class in interface, XmppClient.
Stephen Birarda
@birarda
Mar 10 2014 23:20
@ddobrev what’s the deal with qtimespan.cpp
according to the doc "This file is part of the QtCore module of the Qt Toolkit."
Dimitar Dobrev
@ddobrev
Mar 10 2014 23:21
@birarda - it's a class that hasn't been accepted yet in Qt.
Stephen Birarda
@birarda
Mar 10 2014 23:21
hmm - okay
we will likely want to fork qxmpp and add qtimespan to qxmpp
is the same true for FlowLayout?
Dimitar Dobrev
@ddobrev
Mar 10 2014 23:22
No. It's a Qt example.
About adding qtimespan to qxmpp - they have nothing to do with each other.
Stephen Birarda
@birarda
Mar 10 2014 23:23
XmppClient looks good - just have to think about how we want to handle those pseudo external classes
yes I understand that
I suppose those are alright to include in source
Dimitar Dobrev
@ddobrev
Mar 10 2014 23:25
I think so too, they aren't separate projects, just classes. Besides, I had to modify QTimeSpan a little.
Stephen Birarda
@birarda
Mar 10 2014 23:25
the thing that’s unfortunate is that they won’t match the coding standard
Dimitar Dobrev
@ddobrev
Mar 10 2014 23:25
@birarda - I understand but I didn't want to change them any more than necessary.
Stephen Birarda
@birarda
Mar 10 2014 23:25
so we should probably have a folder where we have included classes or something - so the distinction is clearer
yeah - not saying you would have to change them to make them coding standard compliant
for now I won’t worry about that - I may move them into a folder named externals inside of src or something
I’m going to checkout your fork now so I can test chat while we wait for leo
can you hop in too?
Dimitar Dobrev
@ddobrev
Mar 10 2014 23:26
Yes, no problem.
Stephen Birarda
@birarda
Mar 10 2014 23:27
cool - building
Dimitar Dobrev
@ddobrev
Mar 10 2014 23:28
How can I turn the voices in my head off?
Stephen Birarda
@birarda
Mar 10 2014 23:28
the echo?
Dimitar Dobrev
@ddobrev
Mar 10 2014 23:28
Yes, I guess.
Stephen Birarda
@birarda
Mar 10 2014 23:29
check debugging->audio
ohh
those are bots
Dimitar Dobrev
@ddobrev
Mar 10 2014 23:30
Perhaps I could comment out some line in the code?
Stephen Birarda
@birarda
Mar 10 2014 23:30
that’s sort of our testing playground right now
why don’t you go to
b
that’s me - am in a different domain
Dimitar Dobrev
@ddobrev
Mar 10 2014 23:31
Yep, the voices are gone. :)
@birarda - by the way, I wanted to tell you about another point of interest.
I enabled translations.
Stephen Birarda
@birarda
Mar 10 2014 23:36
I saw that
Dimitar Dobrev
@ddobrev
Mar 10 2014 23:36
And added an English one.
I think it would be useful to you too.
Stephen Birarda
@birarda
Mar 10 2014 23:36
yeah - let me talk to @problem / @RyanDowne in the office here
I’m not sure we’re ready to go down that road yet
and since we will need to do it in a ton of places, I might want you to just remove that so we can do that when we’re ready
by the way - here’s a bug leo experienced
Dimitar Dobrev
@ddobrev
Mar 10 2014 23:37
I did it because I actually needed it.
Stephen Birarda
@birarda
Mar 10 2014 23:37
what do you mean?
Dimitar Dobrev
@ddobrev
Mar 10 2014 23:38
In the chat I have to add time stamps after a certain amount of time.
And a certain number of messages.
Which says, that last message was from 10 hours ago.
So, I needed to display 1 hour, 2 hourS.
And I said to myself, why write ugly if (n == 1) else, when I can exploit Qt's translation system?
Stephen Birarda
@birarda
Mar 10 2014 23:40
well
that sounds pretty good to me
I will put translation onto our roadmap - we will likely have to get some devs to move the strings in the cpp files out into the ts files
can you hop back into chat?
I’m in the public room in a separate client and I want to see if I have the same experience as leo
Dimitar Dobrev
@ddobrev
Mar 10 2014 23:44
I've written a little in the chat. What can I do to help you check?
Stephen Birarda
@birarda
Mar 10 2014 23:48
interesting - the 1-1 chat window is public@public-chat.highfidelity.io/ddobrev
so it’s the room but messages from you
let me see if I can configure client to put them in the same space
did you get this
"do you see the message I am writing from my public room?"
Dimitar Dobrev
@ddobrev
Mar 10 2014 23:50
Yes.
I replied in the chat too.
Stephen Birarda
@birarda
Mar 10 2014 23:51
yeah it comes in my other window
looking into it
Dimitar Dobrev
@ddobrev
Mar 10 2014 23:52
I can see you've added some remarks on the conventions, want me to fix them now?
Stephen Birarda
@birarda
Mar 10 2014 23:52
yes - still haven’t gone through all of it but almost done
got sidetracked by this bug
you may want to call sendPacket instead of sendMessage with a QXmppMessage so that you can explicitly set the Type of the message to Groupchat
Dimitar Dobrev
@ddobrev
Mar 10 2014 23:53
OK, I think it would be best to put those in a separate commit.
Stephen Birarda
@birarda
Mar 10 2014 23:53
you can wait until I let you know that I’ve completed the reivew if you like
Dimitar Dobrev
@ddobrev
Mar 10 2014 23:53
OK, that would be better.
Stephen Birarda
@birarda
Mar 10 2014 23:54
so something like this should send to the room
QXmppMessage msg;
msg.setTo(d->jid);
msg.setType(QXmppMessage::GroupChat);
msg.setBody(text);
return d->client->sendPacket(msg);
where d->jid is the room jid
Dimitar Dobrev
@ddobrev
Mar 10 2014 23:54
Thanks.
Stephen Birarda
@birarda
Mar 10 2014 23:55
can you put that in your client now and see if I get it in the right window?