These are chat archives for highfidelity/hifi

12th
Mar 2014
Jonathan "Geenz" Goodman
@Geenz
Mar 12 2014 00:02
kinda wondering if it's something left over from my previous port installation
Clément Brisset
@Atlante45
Mar 12 2014 00:05
Where are you from @ddobrev ?
Jonathan "Geenz" Goodman
@Geenz
Mar 12 2014 00:06
and now to try installing qt5 again, now that I've found the "kill it with fire" script for Qt
Stephen Birarda
@birarda
Mar 12 2014 00:06
… you shouldn’t have had to reinstall qt5?
brew can do a good job of linking qt5 for you
brew link qt5 —force
you’ll have to do that anyways even if you reinstall to get qmake into your path
Dimitar Dobrev
@ddobrev
Mar 12 2014 00:07
@Atlante45 - I am from Burgas, Bulgaria.
Thanks for asking.
Stephen Birarda
@birarda
Mar 12 2014 00:07
@ddobrev chat has been merged!
Dimitar Dobrev
@ddobrev
Mar 12 2014 00:07
@birarda - thanks.
Grayson Stebbins
@problem
Mar 12 2014 00:08
wohoo! nice work @birarda @ddobrev
Dimitar Dobrev
@ddobrev
Mar 12 2014 00:08
@problem - thanks. I cannot see you online, though. Perhaps we are in different domains.
I am in b.
Stephen Birarda
@birarda
Mar 12 2014 00:09
oh @ddobrev I meant go to ‘b'
not domain b
you’re actually nowhere right now
so if you hit
‘@'
and then b
you’ll be right in front of me
Clément Brisset
@Atlante45
Mar 12 2014 00:11
@ddobrev nice, good work on chat.
Dimitar Dobrev
@ddobrev
Mar 12 2014 00:11
@Atlante45 Thanks. Where are you from yourself? The US?
Jonathan "Geenz" Goodman
@Geenz
Mar 12 2014 00:12
I assume that interface has a built-in means to limit bandwidth for streaming?
Stephen Birarda
@birarda
Mar 12 2014 00:13
@Geenz I believe most of that limiting is on the server side
Clément Brisset
@Atlante45
Mar 12 2014 00:13
@ddobrev nope, I’m a proud French.
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 00:13
there is a preference to limit number of incoming packets per second for octree elements (voxels, particles)...
@Geenz ^
Clément Brisset
@Atlante45
Mar 12 2014 00:16
Just logged out and back in. Can’t launch the chat.
Stephen Birarda
@birarda
Mar 12 2014 00:16
do you have qxmpp on your machine
did you clean build @Atlante45
Clément Brisset
@Atlante45
Mar 12 2014 00:16
yep
oh no
Stephen Birarda
@birarda
Mar 12 2014 00:17
did it say QXMPP_FOUND
make sure it shows you it found it
Clément Brisset
@Atlante45
Mar 12 2014 00:17
yep
Jonathan "Geenz" Goodman
@Geenz
Mar 12 2014 00:18
@ZappoMan I assume that the variable in particular I want in Application is _packetsPerSecond?
Dimitar Dobrev
@ddobrev
Mar 12 2014 00:18
@Atlante45 So a fellow European. How many Europeans do we have in here?
Stephen Birarda
@birarda
Mar 12 2014 00:18
@ddobrev can you remind me again what was the other thing not yet done for chat?
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 00:18
@Geenz - just use the Preferences Dialog box.
Jonathan "Geenz" Goodman
@Geenz
Mar 12 2014 00:18
@ZappoMan kind of trying to catch up on all of the changes to Application after so many months
@ZappoMan this is in reference to #19514 on Worklist, rendering's the easy part; trying to find a good way to handle the streaming half of it
Dimitar Dobrev
@ddobrev
Mar 12 2014 00:19
@birarda When online users are more than 3 rows, dispay a button of the type 'show all' and display a full list on clicking.
That is, when online users 'take' more than 3 rows.
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 00:20
hmmm
Stephen Birarda
@birarda
Mar 12 2014 00:20
alright - so you have something to work on if we’re not around until tomorrow morning PST (and you have time / want to keep working) @ddobrev
Jonathan "Geenz" Goodman
@Geenz
Mar 12 2014 00:20
@ZappoMan ah, I see why I shouldn't touch that one directly
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 00:20
well - @Geenz - that's interesting… let me read the item
Jonathan "Geenz" Goodman
@Geenz
Mar 12 2014 00:20
I will be back in a little bit however, as I need food
Dimitar Dobrev
@ddobrev
Mar 12 2014 00:21
@birarda - I'll throw it in, I've promised to. :)
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 00:21
you can turn off voxels completely…
Stephen Birarda
@birarda
Mar 12 2014 00:21
@Atlante45 did you figure out chat?
Clément Brisset
@Atlante45
Mar 12 2014 00:21
building ...
Jonathan "Geenz" Goodman
@Geenz
Mar 12 2014 00:21
@ZappoMan still have my email? Or I can do Skype
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 00:21
@Geenz we can also 1:1 chat here.
Clément Brisset
@Atlante45
Mar 12 2014 00:21
@ddobrev I’m the only one I think.
Stephen Birarda
@birarda
Mar 12 2014 00:22
where’s @kordero from?
Grayson Stebbins
@problem
Mar 12 2014 00:22
Argentina @birarda
Stephen Birarda
@birarda
Mar 12 2014 00:22
oh github says argentina
so he’s in leo’s camp
Dimitar Dobrev
@ddobrev
Mar 12 2014 00:22
@problem It is very late here, so may I'd like to ask you to mail me your remarks when you've tried the char.
@problem Is that OK?
Grayson Stebbins
@problem
Mar 12 2014 00:22
Sure, sounds great
Dimitar Dobrev
@ddobrev
Mar 12 2014 00:22
Thank you.
Grayson Stebbins
@problem
Mar 12 2014 00:22
@ddobrev
sure
Stephen Birarda
@birarda
Mar 12 2014 00:23
good stuff @ddobrev
Dimitar Dobrev
@ddobrev
Mar 12 2014 00:23
@birarda Thanks again. @Atlante45 Do you need any assistance about the chat?
Clément Brisset
@Atlante45
Mar 12 2014 00:23
I’ll figure it out ;)
Thanks though
Dimitar Dobrev
@ddobrev
Mar 12 2014 00:24
@Atlante45 No problem.
I'm calling it a night then.
Have a nice day/evening/night, everyone.
Clément Brisset
@Atlante45
Mar 12 2014 00:25
You too
Lucas Crisman
@kordero
Mar 12 2014 00:26
sorry, just read you @birarda, I use to have big latency issues with your servers so I mostly work on a local server with hifi
Stephen Birarda
@birarda
Mar 12 2014 00:26
no problem - didn’t mean to mention you to force you to come in I figured that @problem would know the answer
Clément Brisset
@Atlante45
Mar 12 2014 00:26
@birarda rebuild entire project, still nothing.
'-- Found QXMPP: /usr/local/include/qxmpp
-- Found qxmpp: /usr/local/lib/libqxmpp.dylib
'
Lucas Crisman
@kordero
Mar 12 2014 00:26
btw, good work you are doing every day neuromancers :)
Stephen Birarda
@birarda
Mar 12 2014 00:27
when you say log out and log back in @Atlante45 did you logout from the menu
not close the client
it needs to delete your access token and ask for a new one
Clément Brisset
@Atlante45
Mar 12 2014 00:27
yep logout in the menu
Stephen Birarda
@birarda
Mar 12 2014 00:27
try that again
Clément Brisset
@Atlante45
Mar 12 2014 00:28
Do I need to close the client after I loved out ?
Stephen Birarda
@birarda
Mar 12 2014 00:28
no
Clément Brisset
@Atlante45
Mar 12 2014 00:28
logged*
doesn’t work
Stephen Birarda
@birarda
Mar 12 2014 00:30
balls
theoretically that means your client doesn’t have an xmpp password to use
Andrew Meadows
@AndrewMeadows
Mar 12 2014 01:11
the radians work is done
we now use radians nearly everywhere
some of the few exceptions are: glRotate*() calls and Head, Body, Eye pitch, yaw, and roll
Chris Mitchell
@Chris7
Mar 12 2014 04:31
Hi, just saw some of your work requests on elance, anyone around to discuss details?
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 04:33
hey - Chris, I might be able to help.
Chris Mitchell
@Chris7
Mar 12 2014 04:33
Cool, first is I imagine you prefer if I went through worklist.net
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 04:33
I'm not sure what task/job was posted on elance (@grayson was driving that)… but if you give me some context I'm sure I can elaborate.
yeah - that's easier for me. ;)
Chris Mitchell
@Chris7
Mar 12 2014 04:34
I saw a few, one was the script view & the other was stopping the rendering when the window is obscured
The rendering one seems to be an open issue, ie you guys don't know if you exactly want it yet
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 04:34
someone else is working on the window obscured task right now...
Chris Mitchell
@Chris7
Mar 12 2014 04:35
The first one, I saw the mockup and had some questions
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 04:35
Chris Mitchell
@Chris7
Mar 12 2014 04:35
Is the script engine built?
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 04:35
yes
Chris Mitchell
@Chris7
Mar 12 2014 04:35
yes, that one
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 04:36
yes. the Script engine is built
actually, today we have most of this functionality… but it's on a meny
*menu
Chris Mitchell
@Chris7
Mar 12 2014 04:36
So it is completely decentralized from the widget
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 04:36
and Grayson is asking to move it to more of a dialog/window UI
yeah, here, let me give you a screen shot of what we have today… hold on sec
Chris Mitchell
@Chris7
Mar 12 2014 04:37
Ok, I just need to know how it works. If I can just operate on signal/queries
I can see that from the code-base obviously, but that might take some time to find ;0
:) rather, typing on an ipad is hard sometimes
Chris Mitchell
@Chris7
Mar 12 2014 04:39
OK, so you need a splitter widget essentially
throw the main part on the right, scripts on the left (if any are running) with some controls to operate them
What is the price range for this project?
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 04:40
Currently the application and the script engine talk to each other enough for the script engine to say "here's a new script I'm running"… and the application handles it from there… putting it on the menu, etc.
Chris Mitchell
@Chris7
Mar 12 2014 04:40
I work on a project, Mudlet, that has some similar routines
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 04:40
and the splitter widget basically just replaces the menus we have now...
Chris Mitchell
@Chris7
Mar 12 2014 04:41
The splitter is just the first Qt based widget that came to mind
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 04:41
as for price, you should bid what you think is fair… estimate your time to the best of your ability, and make a bid.
I will leave it to you to propose the best tools for the task.
Checkout hifi/interface/src/Application.cpp to get some context for how the hooks are handled today...
Chris Mitchell
@Chris7
Mar 12 2014 04:43
Sounds good
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 04:43
I've never played around with adding a splitter to a main window, and this would be the first implementation of that in the code base. I know Grayson is looking to have more ui like that added.
hifi/libraries/script-engine/src/ScriptEngine.cpp/h are the actual script instances…
Chris Mitchell
@Chris7
Mar 12 2014 04:44
I've played around with most of QT's widgets. I can poke around tomorrow when I'm on my linux machine and gauge how difficult this should be
I'll be in touch though, thanks for your time
If you want to look at my past Qt work, you can obviously checkout them under this github name :)
github based chat is quite cool, never knew this existed
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 04:46
yeah - we just started using it in the last week or so.
definitely a great way to collaborate with other contributors to the project.
ok - ttyl.
Jonathan "Geenz" Goodman
@Geenz
Mar 12 2014 06:09
yay, got a build environment
Jonathan "Geenz" Goodman
@Geenz
Mar 12 2014 06:14
huh, well this is different
running into some weird issues that I think is related to glow
...ooor not
it looks like that avatars are being rendered with impostors, and occasionally if you look at a large enough crowd of them things start glitching in weird ways
Dimitar Dobrev
@ddobrev
Mar 12 2014 14:53
@murillodigital - got a minute?
Leonardo Murillo
@murillodigital
Mar 12 2014 14:53
yeah
Dimitar Dobrev
@ddobrev
Mar 12 2014 14:54
I understand there's a bug with upper-cased users.
Are they unable to log in?
Leonardo Murillo
@murillodigital
Mar 12 2014 14:54
not anymore
I fixed our auth script last night
treating username without case sensitivity now
Dimitar Dobrev
@ddobrev
Mar 12 2014 14:54
Oh, I thought it was on my side.
All right then.
Leonardo Murillo
@murillodigital
Mar 12 2014 14:54
nope, the XMPP server uses a script to auth against our database
and I had originally wrote it all case sensitive
Dimitar Dobrev
@ddobrev
Mar 12 2014 14:56
I see. OK, I'm glad it's fine now.
Dimitar Dobrev
@ddobrev
Mar 12 2014 15:49
@murillodigital - the build passed. Can you please merge it?
Stephen Birarda
@birarda
Mar 12 2014 16:33
@ddobrev morning
Dimitar Dobrev
@ddobrev
Mar 12 2014 16:33
@birarda evening. :)
Stephen Birarda
@birarda
Mar 12 2014 16:33
if we were to remove the ts file from our repo would it get generated the same way everytime by the create command
so for a new developer without the file in their checkout it would simply be generated?
Dimitar Dobrev
@ddobrev
Mar 12 2014 16:34
Any translations will be lost to him..
Stephen Birarda
@birarda
Mar 12 2014 16:35
well - the issue is that if you make a change to a file that has translations the line numbers change in the translations file
Dimitar Dobrev
@ddobrev
Mar 12 2014 16:35
I know. Not too pleasant but I don't have any better ideas.
Even if there was some param to pass to lupdate that prevents writing line numbers, this would mean Linguist won't be able to give correct hints.
Stephen Birarda
@birarda
Mar 12 2014 16:37
I’ll do some reserach this morning
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 16:37
does the tool find all instances of the string automatically?
Dimitar Dobrev
@ddobrev
Mar 12 2014 16:37
Let me search around for a little info. In the mean time do you mind merging https://github.com/highfidelity/hifi/pull/2273 ?
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 16:38
so if for example I add a new use of the string to a new file, does the build tool automatically find it?
Stephen Birarda
@birarda
Mar 12 2014 16:38
yes
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 16:38
ok
Stephen Birarda
@birarda
Mar 12 2014 16:38
I believe so
Dimitar Dobrev
@ddobrev
Mar 12 2014 16:38
@ZappoMan it finds all tr()/QApllication::translate usages.
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 16:38
here's a suggestion.. if that works...
Stephen Birarda
@birarda
Mar 12 2014 16:38
so that it can handle that translation
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 16:38
make the file we check in to the repo be a different file...
like .ts.source
remove the \<location\>
tags from that file
in the build process rename it and run the translate tools to locate the strings
Stephen Birarda
@birarda
Mar 12 2014 16:39
it’s auto generated - it’ll be a pain in the ass to have a file that doesn’t have some of the information qt wants for translation
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 16:39
my suggestion solves that
the code we checkin is everything that the tool needs… it's the original strings and the translations...
Dimitar Dobrev
@ddobrev
Mar 12 2014 16:40
@ZappoMan how would you get new translations to that source file?
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 16:40
that code will only change when we actually add a translation.
Stephen Birarda
@birarda
Mar 12 2014 16:40
I’m pretty sure that it won’t be able to find the correct tranlsation in a file in the case of duplicates
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 16:40
You have to actually translate the strings right? it doesn't auto-translate?
Dimitar Dobrev
@ddobrev
Mar 12 2014 16:40
@ZappoMan yes.
Stephen Birarda
@birarda
Mar 12 2014 16:41
if there are two source strings in the file that are the same how will it know which to use
assuming we rely on qt5_create_translation to add the locations at build time
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 16:41
```
Dimitar Dobrev
@ddobrev
Mar 12 2014 16:41
@birarda - there are context/disambiguation parameters to pass to tr.
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 16:41

    <message>
        <location filename="ui/chatWindow.ui" line="60"/>
        <location filename="../build/interface/ui_chatWindow.h" line="113"/>
        <source> online now:</source>
        <translation type="unfinished"></translation>
    </message>
that's how the same string is used in multiple places, right?
Stephen Birarda
@birarda
Mar 12 2014 16:42
well that assumes the translation is exactly the same
but context provides for the alternate case
so that sounds find
fine*
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 16:42
oh - so that's the other answer, use the disabiguation feature
Dimitar Dobrev
@ddobrev
Mar 12 2014 16:43
@ZappoMan Right. Such hints appear in Linguis afterwards.
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 16:43
so, I'm suggesting we still use the same "ts" format… but the file we keep in the repo is the one without line numbers….
in the build pass, we run the linguis tools to find all string occurances, and do the standard compile/link/packaging process.
the result of that process is included in build but not in the repo
so… as a dev… we know where we add translations, and all the actual "source" for translations.
but the line numbers don't get rewritten in the repo every build.
Stephen Birarda
@birarda
Mar 12 2014 16:45
the only shitty part is that we want people to just add a new tr(“SOMETHING”) in the file
and have cmake / qt add that to the ts file
which it will do
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 16:45
that still works
Stephen Birarda
@birarda
Mar 12 2014 16:45
but then we have to get it backwards into the .ts.source file
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 16:45
no you don't
only if you have a translation.
in the case you describe, you don't actually have a translation yet… so it doesn't matter if it's in .ts.source
Stephen Birarda
@birarda
Mar 12 2014 16:46
I’m saying it’s not going to add to automatically to the in-repo file as it does now
where-as now it adds most of the xml to the file
and you can go in and just add the translation
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 16:46
I understand… but I'm saying that's just part of the process for when you have a translation.
if you look at our ts file now… we don't have translations for almost every case.
Dimitar Dobrev
@ddobrev
Mar 12 2014 16:47
@ZappoMan I believe all of that would give us more trouble than it would solve. First, we need the line numbers after all, for hinting. Second, I still don't get now new translations, added with Linguist, would go to the ts.source.
I would suggest making some research first.
This is a problem as old as Qt itself.
Stephen Birarda
@birarda
Mar 12 2014 16:47
well @ddobrev we’d have to change the .ts.source after the qt5_create_translations call
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 16:48
one more question. qt5_create_translations… this doesn't actully translate, correct?
Stephen Birarda
@birarda
Mar 12 2014 16:48
it creates or updates the ts file
from the source
and creates an associated qm file, I believe
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 16:48
but with placeholders… no real translations.
Dimitar Dobrev
@ddobrev
Mar 12 2014 16:48
@birarda Right.
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 16:49
        <translation type="unfinished"></translation>
Stephen Birarda
@birarda
Mar 12 2014 16:49
well - it doesn’t remove translations that you already have in your ts file
Dimitar Dobrev
@ddobrev
Mar 12 2014 16:49
@ZappoMan There's no way it can generate translations, that would mean an AI. :)
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 16:49
exactly
Stephen Birarda
@birarda
Mar 12 2014 16:49
so it adds unfinished when you’re not actually translating
but I think we want that block there
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 16:49
so… my point is, what we REALLY care about in the repo, is the ACTAUL translation.
Dimitar Dobrev
@ddobrev
Mar 12 2014 16:49
@birarda Correct.
Stephen Birarda
@birarda
Mar 12 2014 16:49
because then you can just hand off the ts file to the translator
Dimitar Dobrev
@ddobrev
Mar 12 2014 16:49
Right.
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 16:49
but that doesn't happen every build
instead, you do that "hand off to translator" step after the dust has settled on your application.
otherwise your churning your translation process over and over.
Stephen Birarda
@birarda
Mar 12 2014 16:50
so what we probably need to do is the following
ignore *.ts
during build
copy .ts.nolocations to .ts
call qt5_create_translations
use the generated ts and qm for the build
then pass the generated ts to some macro to completely replace the old *.ts.nolocations with the generated output MINUS any location tags
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 16:52
I like this plan… but note: you could even leave the locations in… they won't hurt.
they won't get changed automatically, because it will not be the .ts file, so the repo doesn't churn.
Stephen Birarda
@birarda
Mar 12 2014 16:53
well point being that we’d replace *.ts.nolocaiton with whatever the new ts file
is
which could have new locations
so we’d have to strip them
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 16:53
right
Stephen Birarda
@birarda
Mar 12 2014 16:53
we have to do that to include new translation candidates
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 16:53
if you want to recommit every time..
fair enough.
ok - I agree… strip locations.
so - that process above would be nice/better...
it would only cause a diff to .ts.nolocations when a new string is added...
and it would still be automated. So it's a pretty clean solution.
Stephen Birarda
@birarda
Mar 12 2014 16:54
assuming qt5_create_translations doesn’t arbitrarily re-order thigns
things*
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 16:55
From what I can see this morning. it doesn't
it orders things in the order that it processes them.
It might reorder if you added a new file, with strings in it…
Dimitar Dobrev
@ddobrev
Mar 12 2014 16:55
@birarda @ZappoMan In my personal opinion all of this work is hardly worth it. But whatever you decide, I have to let you know I won't be able to take this task.
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 16:56
but that would be a change you want to capture anyway… just might see some extra line+/- that are just moves.
Stephen Birarda
@birarda
Mar 12 2014 16:56
that’s fine @ddobrev this shouldn’t be your responsibility
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 16:56
totally… this is more of an issue for those of us who have to do code reviews...
Stephen Birarda
@birarda
Mar 12 2014 16:56
I think the biggest issue here is that we have more beginner level git users who would have difficulty with the ts file merge
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 16:56
we don't want people checking in changes to a .ts file every build, when no change actually happened.
exactly
@ddobrev - thanks for adding translations… this is a great improvement in the code… we're just trying to make sure it doesn't significantly complicate our standard dev process.
Dimitar Dobrev
@ddobrev
Mar 12 2014 17:01
@ZappoMan You're welcome. No problem to me at all, I just think it's a little over the top given that line numbers are useful after all.
@ZappoMan A different opinion, that's all.
@birarda @ZappoMan I've found that at least one Qt project contains its ts files in the repo - https://qt.gitorious.org/installer-framework/installer-framework/source/f8cf479851a7c2465644eb43e92a9b98eb27297f:src/sdk/translations
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 17:06
Clearly once it has translations in it, we need to store it in the repo… and I agree with Stephen that having it automatically make the "targets for translation" as part of the repo is also good.
Dimitar Dobrev
@ddobrev
Mar 12 2014 17:11
@ZappoMan Do you mean 'automatically' as in when a new translation is needed?
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 17:12
yes
Dimitar Dobrev
@ddobrev
Mar 12 2014 17:16
@birarda I have some work to do on the design. Could you please merge https://github.com/highfidelity/hifi/pull/2273 ?
It's two lines.
Stephen Birarda
@birarda
Mar 12 2014 17:16
done
Dimitar Dobrev
@ddobrev
Mar 12 2014 17:16
Thanks.
Stephen Birarda
@birarda
Mar 12 2014 17:16
sorry - got sidetracked with our discussion
Dimitar Dobrev
@ddobrev
Mar 12 2014 17:17
No problem. I was part of it so I couldn't have worked anyway. :)
Dimitar Dobrev
@ddobrev
Mar 12 2014 17:23
@birarda I was told by @problem some time ago that ChatEntry is not used. Should I delete it?
Stephen Birarda
@birarda
Mar 12 2014 17:24
yes
I believe he wants enter to open the chat window now
Dimitar Dobrev
@ddobrev
Mar 12 2014 17:25
Yes, I asked in connection to that.
All right then, deleting.
Grayson Stebbins
@problem
Mar 12 2014 17:37
Sweet @ddobrev
Stephen Birarda
@birarda
Mar 12 2014 18:01
@ddobrev we have a bug where if I send somebody 1:1 chat it comes up in the group window
so we need to make sure incoming chats come from the room jid
until we add 1:1 chat
Dimitar Dobrev
@ddobrev
Mar 12 2014 18:01
@birarda OK.
@birarda You mean that I got your messages and I shouldn't have? ;)
Dimitar Dobrev
@ddobrev
Mar 12 2014 18:18
@birarda Mind merging https://github.com/highfidelity/hifi/pull/2279 ? I'm going to fix the group chat afterwards.
Stephen Birarda
@birarda
Mar 12 2014 18:19
looking
done
Dimitar Dobrev
@ddobrev
Mar 12 2014 18:19
Thanks.
Stephen Birarda
@birarda
Mar 12 2014 18:23
@ddobrev is there a situation in which we would also want to use qt5_add_translation?
I’m tweaking FindQt5LinguistToolsMacros to handle looking for *.ts.nolocations
oh - I guess create is calling add
Dimitar Dobrev
@ddobrev
Mar 12 2014 18:23
@birarda Yes.
I don't think we need it directly.
Stephen Birarda
@birarda
Mar 12 2014 18:24
cool, nvm
thanks
Dimitar Dobrev
@ddobrev
Mar 12 2014 18:36
@birarda Mind sending a private message to see if I get it?
Stephen Birarda
@birarda
Mar 12 2014 18:37
sure one sec
sent
Dimitar Dobrev
@ddobrev
Mar 12 2014 18:37
I didn't get anything. May I now have a public one?
Never mind, I can check public ones myself.
Dimitar Dobrev
@ddobrev
Mar 12 2014 18:44
@birarda Please send me another private one, I think this will be the last time.
Jonathan "Geenz" Goodman
@Geenz
Mar 12 2014 18:59
hello!
Jonathan "Geenz" Goodman
@Geenz
Mar 12 2014 19:09
gotta love how long some of the options for some of Apple's C APIs get such as: kCGWindowListOptionOnScreenAboveWindow
Dimitar Dobrev
@ddobrev
Mar 12 2014 19:12
@birarda @murillodigital @RyanDowne anybody mind sending a private XMPP message?
Jonathan "Geenz" Goodman
@Geenz
Mar 12 2014 19:14
does anyone know how to get a native window ID out of Qt?
Dimitar Dobrev
@ddobrev
Mar 12 2014 19:16
@Geenz QWidget::winId()
Jonathan "Geenz" Goodman
@Geenz
Mar 12 2014 19:17
thanks
hm, looks good for Windows and Linux, but not for OS X where the "right" API for grabbing all windows is the CGWindow API which I'm having trouble finding a good way to get a CGWindowID out of
Stephen Birarda
@birarda
Mar 12 2014 19:20
@ddobrev still need that 1:1 message?
Dimitar Dobrev
@ddobrev
Mar 12 2014 19:21
@birarda Yes, please. Thanks.
Leonardo Murillo
@murillodigital
Mar 12 2014 19:21
@ddobrev did you get mine>
?
I sent it a few minutes back
Dimitar Dobrev
@ddobrev
Mar 12 2014 19:21
@murillodigital No.
So it should be OK now.
Jonathan "Geenz" Goodman
@Geenz
Mar 12 2014 19:21
or rather, I'm having trouble finding a good way of getting a CGWindowID out of an NSWindow, and winId() seems to return a pointer to an NSView
Stephen Birarda
@birarda
Mar 12 2014 19:21
I’m sending you some now @ddobrev
ddobrev
uigh
sorry
Dimitar Dobrev
@ddobrev
Mar 12 2014 19:22
That's OK. Didn't get any.
OK, I'm preparing a pull.
Dimitar Dobrev
@ddobrev
Mar 12 2014 20:10
@murillodigital My build (https://github.com/highfidelity/hifi/pull/2283) seems stuck. No jobs running but no report for completion.
Is everything OK?
Leonardo Murillo
@murillodigital
Mar 12 2014 20:10
@ddobrev thansk for heads up, had a piled up queue of PRs
need to move jenkisn to a more powerful box
Dimitar Dobrev
@ddobrev
Mar 12 2014 20:11
@murillodigital Thanks for helping. How can I restart the build now?
Leonardo Murillo
@murillodigital
Mar 12 2014 20:11
comment: test this please
Stephen Birarda
@birarda
Mar 12 2014 20:12
it won’t work if he says it @murillodigital
Leonardo Murillo
@murillodigital
Mar 12 2014 20:12
ahh right
not an admin
sorry
u in there @birarda ?
can you nicely ask?
Stephen Birarda
@birarda
Mar 12 2014 20:13
gustavo abides
Dimitar Dobrev
@ddobrev
Mar 12 2014 20:48
Jonathan "Geenz" Goodman
@Geenz
Mar 12 2014 21:05
using glm-0.9.5.2, I'm getting build errors such as:
/Users/geenz/Devel/hifi/interface/src/renderer/FBXReader.cpp:1049:23: No matching function for call to 'translate'
Stephen Birarda
@birarda
Mar 12 2014 21:05
did you get them before?
Jonathan "Geenz" Goodman
@Geenz
Mar 12 2014 21:05
nope
Stephen Birarda
@birarda
Mar 12 2014 21:05
this came after a merge?
Jonathan "Geenz" Goodman
@Geenz
Mar 12 2014 21:05
yep
Stephen Birarda
@birarda
Mar 12 2014 21:06
it’s possible you need to clean build - @AndrewMeadows has been working on moving to radians
Jonathan "Geenz" Goodman
@Geenz
Mar 12 2014 21:06
did that
Stephen Birarda
@birarda
Mar 12 2014 21:06
hmm
Jonathan "Geenz" Goodman
@Geenz
Mar 12 2014 21:06
it looks like it's the constructors for some of the functions here
constructors? parameters even
Stephen Birarda
@birarda
Mar 12 2014 21:07
I’m not sure
Jonathan "Geenz" Goodman
@Geenz
Mar 12 2014 21:07
for example, I see things like (referencing the line mentioned in that error):
glm::translate(mapping.value("tx").toFloat(), mapping.value("ty").toFloat(), mapping.value("tz").toFloat())
from what I remember, translate doesn't accept raw floats but it will accept vecs
Stephen Birarda
@birarda
Mar 12 2014 21:07
let me check if I get same errors
it’s possible somebody with an older version of glm merged that in
Jonathan "Geenz" Goodman
@Geenz
Mar 12 2014 21:09
another example:
glm::angleAxis(90.0f, 0.0f, sign, 0.0f) should be glm::angleAxis(90.0f, glm::vec3(0.0f, sign, 0.0f))
Stephen Birarda
@birarda
Mar 12 2014 21:09
yeah I remember having to change a couple of those when I updated our glm dependency
Jonathan "Geenz" Goodman
@Geenz
Mar 12 2014 21:10
ah! okay, I think I know the problem, one sec
Stephen Birarda
@birarda
Mar 12 2014 21:10
I am up to date
and not experiencing the issue
Jonathan "Geenz" Goodman
@Geenz
Mar 12 2014 21:12
yeah, I think I see the issue now; the github client wasn't showing me the branch that worklist created for me, so I assumed that the branch labeled "stable" was correct; seems like that branch is actually behind
Stephen Birarda
@birarda
Mar 12 2014 21:12
yeah sorry
wayyy behind
I’ll remove it while we’re not actually using it
Jonathan "Geenz" Goodman
@Geenz
Mar 12 2014 21:13
aaaaaand just like that, it works
excellent, now I can get back to it
Stephen Birarda
@birarda
Mar 12 2014 21:14
stable branch is gone
thanks
Dimitar Dobrev
@ddobrev
Mar 12 2014 22:06
Dimitar Dobrev
@ddobrev
Mar 12 2014 23:03
Stephen Birarda
@birarda
Mar 12 2014 23:03
one sec
Dimitar Dobrev
@ddobrev
Mar 12 2014 23:04
I have to rebase.
Stephen Birarda
@birarda
Mar 12 2014 23:04
?
Dimitar Dobrev
@ddobrev
Mar 12 2014 23:05
I can see more merges before mine.
Stephen Birarda
@birarda
Mar 12 2014 23:06
let me know when you’re ready
Dimitar Dobrev
@ddobrev
Mar 12 2014 23:07
Done, waiting for the build.
Jonathan "Geenz" Goodman
@Geenz
Mar 12 2014 23:15
anyone mind building and testing my branch here? https://github.com/Geenz/hifi/tree/19514
the testing part won't take any more than a few minutes, I promise!
Brad Hefta-Gaub
@ZappoMan
Mar 12 2014 23:24
@Geenz - make sure to check the coding standard/style guide before you submit your PR for that… I see at least bracket placement is inconsistent with the style guide.
Jonathan "Geenz" Goodman
@Geenz
Mar 12 2014 23:25
not submitting it yet, just need someone to verify results for the render throttle I threw in there
also, speaking of coding standard, I assume that hasn't changed much over the past eight months?
Dimitar Dobrev
@ddobrev
Mar 12 2014 23:27
@birarda - Build's done.
Jonathan "Geenz" Goodman
@Geenz
Mar 12 2014 23:30
@ZappoMan hooray for vaguely remembering coding standards! I'll clean things up sometime before submission of the final functionality