These are chat archives for highfidelity/hifi

13th
Mar 2014
Dimitar Dobrev
@ddobrev
Mar 13 2014 02:14
@birarda Could you please review https://github.com/highfidelity/hifi/pull/2293 ?
Stephen Birarda
@birarda
Mar 13 2014 16:26
@ddobrev just getting in this morning
will take a look
ahh brad already got it
alright
Dimitar Dobrev
@ddobrev
Mar 13 2014 16:32
@birarda Thanks.
Dimitar Dobrev
@ddobrev
Mar 13 2014 16:39
@birarda I have one more, though, much smaller - https://github.com/highfidelity/hifi/pull/2297 .
Jonathan "Geenz" Goodman
@Geenz
Mar 13 2014 18:41
what's the preferred means of adding UI elements to Interface? Is using Qt Quick fine?
Grayson Stebbins
@problem
Mar 13 2014 18:43
@Geenz UI files if possible
unless it doesn’t make sense
Jonathan "Geenz" Goodman
@Geenz
Mar 13 2014 18:46
just looking at #19519, looks like Qt Quick + QML would be "nice" since it has a pretty easy to grasp interface for fancy transitions and such
but I can look at using UI files instead
Grayson Stebbins
@problem
Mar 13 2014 18:47
cool, i mean, i think we should use the best tool for the job
and as far as I know we haven’t explored QML much, so maybe it’s worth giving a shot
Jonathan "Geenz" Goodman
@Geenz
Mar 13 2014 18:49
yeah, I'm liking what I see in the presentation video that's in #19519's description so far, and I've found a way to use it from C++ without significant modifications
Grayson Stebbins
@problem
Mar 13 2014 18:50
mkay, well, run it by @birarda or @ZappoMan; i don’t think I have much to say on this given that I never touch code
Dimitar Dobrev
@ddobrev
Mar 13 2014 18:53
QML is really nice but they still lack a few basic components, such as a tree.
Some of the existing ones fdon't have all abilities of their widget counterparts yet.
The QML designer needs some work too but it's pretty easy to write it by hand.
Grayson Stebbins
@problem
Mar 13 2014 18:55
Thanks for the thoughts @ddobrev
Off for lunch, back in a bit
Dimitar Dobrev
@ddobrev
Mar 13 2014 21:11
@birarda Got a minute?
Stephen Birarda
@birarda
Mar 13 2014 21:13
yep
Dimitar Dobrev
@ddobrev
Mar 13 2014 21:16
The chat window needs to be located inside the main one. So that they can be moved/resized/etc together.
I'm thinkin about setting a horizontal layout to the main window. And place the chat panel there.
OK?
thinking*
Stephen Birarda
@birarda
Mar 13 2014 21:19
maybe @problem is a better person to ask
or @ZappoMan
we want the ui of the main window to be pretty scriptable
Brad Hefta-Gaub
@ZappoMan
Mar 13 2014 21:19
Here's my quick take on this...
Stephen Birarda
@birarda
Mar 13 2014 21:19
so if the very abstract ui file for the main window is just to place it with the menubar and whatever
Dimitar Dobrev
@ddobrev
Mar 13 2014 21:19
@problem wants it not to be a separate window. What I'd like to discuss is how to do it.
Stephen Birarda
@birarda
Mar 13 2014 21:19
that’s probably cool
Brad Hefta-Gaub
@ZappoMan
Mar 13 2014 21:20
it seems like from many of @problem 's latest designs, he is thinking along the lines of what @ddobrev is suggesting
from a tech perspective, if you can do the implementaiton in such a way that makes it easy to add additional panes… then that is good.
Dimitar Dobrev
@ddobrev
Mar 13 2014 21:21
@ZappoMan Right, my suggestion was based on @problem's design.
Brad Hefta-Gaub
@ZappoMan
Mar 13 2014 21:21
I am no Qt expert, but it seems like some QtWidgetLayout class would be the easiest way to do this...
Grayson Stebbins
@problem
Mar 13 2014 21:21
:)
Brad Hefta-Gaub
@ZappoMan
Mar 13 2014 21:21
or something like that.
Dimitar Dobrev
@ddobrev
Mar 13 2014 21:22
Well, as far as changes outside the chat are concerned, I'm thinking about setting a layout to the main window.
And then various menus can say, get that layout and add components.
Brad Hefta-Gaub
@ZappoMan
Mar 13 2014 21:22
sounds like a good plan to me.
Dimitar Dobrev
@ddobrev
Mar 13 2014 21:23
All right then.
Grayson Stebbins
@problem
Mar 13 2014 21:54
@ZappoMan @kordero do we use hex values for colors anywhere in our hifi code? Think there is value in having parity accross all development project? RGBA everywhere …? (i’m writing a spec for the alpha forum)
Lucas Crisman
@kordero
Mar 13 2014 21:56
gotcha @problem, what do you think would be better? will make sure of that
Lucas Crisman
@kordero
Mar 13 2014 22:04
drawText -a function that we're calling for UI stats- is receiving a float vector array, we represent normal text this way:
const float WHITE_TEXT[] = { 0.93, 0.93, 0.93 };
though I think we should use QColor instead
Brad Hefta-Gaub
@ZappoMan
Mar 13 2014 22:06
@problem we use floats some places and bytes other places… hex would be byte based items… so to answer your quesiton. NO, we don't have consistency
Grayson Stebbins
@problem
Mar 13 2014 22:06
cool, maybe it doesn’t matter @ZappoMan @kordero, just curious
Brad Hefta-Gaub
@ZappoMan
Mar 13 2014 22:07
@problem you're thinking like a designer! ;) @kordero is thinking like a developer.
I think what you're really asking is… do we have a standard COLOR style guide that we use in our code when we need various colors.
@kordero is saying… maybe the data structures we use to represent those colors should be standardized across the code.
Lucas Crisman
@kordero
Mar 13 2014 22:08
thanks Brad :)
Brad Hefta-Gaub
@ZappoMan
Mar 13 2014 22:08
I think you've both on to good ideas, but they're slightly different, solving different problems.
that said, here's my take… on each issue.
1) I like the idea of having color standards… it would make it easy for developers to know what colors to use.
Grayson Stebbins
@problem
Mar 13 2014 22:10
my main point was: what kind of color values should I expect to give a developer, and for now the answer is “it depends"
Brad Hefta-Gaub
@ZappoMan
Mar 13 2014 22:10
2) as for standardizing our color data structures - we should use something that is portable across C++/JS boundary.
Grayson Stebbins
@problem
Mar 13 2014 22:10
WRT 1) sweet, I’ll make one
Brad Hefta-Gaub
@ZappoMan
Mar 13 2014 22:11
@problem if you have a specific color in mind, you should give it to the developer in the method that makes it easy for you to describe the color. so hex codes is fine if that works for you.
imo, ymmv
Grayson Stebbins
@problem
Mar 13 2014 22:11
ok cool :)
Lucas Crisman
@kordero
Mar 13 2014 22:12
@ZappoMan, do you think that by using QStylesheets we'll be able someway to make javascript code to 'class' objects and we could style them from a css file?
I mean 'class' from a web developing point of view (the same way we class DOM nodes)
Brad Hefta-Gaub
@ZappoMan
Mar 13 2014 22:14
I'm not sure, haven't thought of it… but I'm not really talking about JS for web pages… I'm talking about JS for scripting the interface and/or domain…
I guess stylesheet like features would be useful for scripting interface, overlays, mainly… but we're not currently supporting HTML or things like that...
the places that colors show up in JS are really things like voxel and particle attributes… and/or overlays.
Grayson Stebbins
@problem
Mar 13 2014 22:15
I think @kordero is suggesting a way for us to style things within Interface/Hifi via CSS, which would be super cool
Brad Hefta-Gaub
@ZappoMan
Mar 13 2014 22:16
You mean for built in UI/UX?
Grayson Stebbins
@problem
Mar 13 2014 22:16
(borders, border radii, colors, fonts, etc)
yeah
Lucas Crisman
@kordero
Mar 13 2014 22:16
yeah I understand that it's not over the browser framework, I'm based on the way that way we're using those qss files on resources/styles
I think stojce worked on that
Brad Hefta-Gaub
@ZappoMan
Mar 13 2014 22:17
sure, but honestly, I am hoping that we're going to be reducing the amount of UI/UX we have in interface… and where ever possible do it with scripting.
but sure for built in UI/UX like preferences, go to…, open file… etc...
Grayson Stebbins
@problem
Mar 13 2014 22:17
that’s what I’m suggesting, we’d basically have a set of widgets built in Qt that we’d style and layout via JS and CSS.
Brad Hefta-Gaub
@ZappoMan
Mar 13 2014 22:18
sure it's great to use css/qss/etc.
Lucas Crisman
@kordero
Mar 13 2014 22:18
btw, I've moved most of the UI code to a new class, will hopefully get merged on my next PR
this time I'm talking about an object class
Clément Brisset
@Atlante45
Mar 13 2014 22:29
We could even let people make there own qss styles.
Lucas Crisman
@kordero
Mar 13 2014 22:32
@Atlante45 that would be supported through QStylesheets, so you'd only need to touch those files and test without rebuilding
Dimitar Dobrev
@ddobrev
Mar 13 2014 22:37
@kordero @ZappoMan QSS can be put in Qt resources (*.qrc) and then accessed both in code and in Qt Designer.
Lucas Crisman
@kordero
Mar 13 2014 22:40
cool @ddobrev, the only thing left is to know whether web-based 'classes' are supported in QSS and if we could apply (add/remove) them from js
though there shouldn't be a problem on applying them from js
and not just classes, but also ids and/or some other property accessible from js that allows us to identify those objects from QSS
Dimitar Dobrev
@ddobrev
Mar 13 2014 23:28
@birarda Could you please merge https://github.com/highfidelity/hifi/pull/2303 ?
Stephen Birarda
@birarda
Mar 13 2014 23:30
looking
looks good, merged
Dimitar Dobrev
@ddobrev
Mar 13 2014 23:31
Thanks.
Letting you all know I found a bug while developing this one. highfidelity/hifi#2304 .
The chat can be used to trigger it but it does not cause it.