These are chat archives for highfidelity/hifi

22nd
Jun 2016
Mohammed Nafees
@mnafees
Jun 22 2016 07:19
Hey, I am trying to add a new external library in cmake/externals but it doesn’t seem to recognise the newly added library or its CMakeLists.txt file that should be used for downloading the library and building it
Andrew Meadows
@AndrewMeadows
Jun 22 2016 15:07
@binaryking, that is not enough info to allow us to help you. Maybe you have a github repo with your work? Or a diff patch with all of your changes? Or a link to the changes you've tried to make? Or maybe name the lib you're trying to add?
Mohammed Nafees
@mnafees
Jun 22 2016 15:40
@AndrewMeadows I’m working on https://worklist.net/20924 which requires Google OAuth requests so I was trying to integrate https://github.com/pipacs/o2 into interface
I fixed stuff and it works but I am now wondering if integrating that library is the best approach for this
Suggestions?
Andrew Meadows
@AndrewMeadows
Jun 22 2016 16:39
@binaryking, pipacs/o2 looks fine to me (it uses Qt and has a compatible license) but I'm not an OAuth expert. Maybe @birarda or @clement have opinions.
Mohammed Nafees
@mnafees
Jun 22 2016 18:02
@birarda @Atlante45 @clement Suggestions/opinions please
Clément Brisset
@Atlante45
Jun 22 2016 18:05
Looks good to me too.
Reading the history - Did you figure out how to add it as an external?
@binaryking ^
If not, here is a recent PR I made that does just that: https://github.com/highfidelity/hifi/pull/8059/files
Ignore all the C++ code, and you can just take example on the cmake code.
Mohammed Nafees
@mnafees
Jun 22 2016 18:09
@Atlante45 Amazing, I shall look into that PR. Thanks!
Clément Brisset
@Atlante45
Jun 22 2016 18:10
Let me know if you run into an issue.