These are chat archives for highfidelity/hifi

31st
Aug 2017
Melissa Brown
@themelissabrown
Aug 31 2017 17:53
@here Our process for Javascript jobs and content management is going to be getting easier. This will ensure we'll be reviewing PRs faster and that Marketplace content will be easier to update or add additional features to. Once I have all of the details, I'll point you to a forum post, but I'm really excited about what this means for external developers so I had to share. :D
Matti Lahtinen
@Menithal
Aug 31 2017 20:21
Ugh, I am having a bit of an headache with #21484 regarding persistence of an added property AllowTranslation into animationProperties. I got the flag to work on the animation side, but this is the only thing left. Simply put, It simply doesnt update the value on the entity. Anyone have any pointers on this?
Matti Lahtinen
@Menithal
Aug 31 2017 20:32
cc-> @themelissabrown if you could forward that to anyone who would know about the PROP_ flags, probably to do with networking, scripting.
Matti Lahtinen
@Menithal
Aug 31 2017 21:01
Oh. Nevermind. I figured it out.
was overriding the value elsewhere causing the value to always be false. urgh
Melissa Brown
@themelissabrown
Aug 31 2017 21:25
I love when it solves itself :D
Matti Lahtinen
@Menithal
Aug 31 2017 21:26
Doing final tests and then submitting a PR with test plan
Melissa Brown
@themelissabrown
Aug 31 2017 21:32
great! thanks!
Matti Lahtinen
@Menithal
Aug 31 2017 21:40
Oh no. was there a big change to the way how animations are done?
because this will cause me alot more work
Melissa Brown
@themelissabrown
Aug 31 2017 21:41
not that I know of? What's going on?
Matti Lahtinen
@Menithal
Aug 31 2017 21:41
merge conflict
Melissa Brown
@themelissabrown
Aug 31 2017 21:41
can you rebase from master and see if that fixes it?
Matti Lahtinen
@Menithal
Aug 31 2017 21:41
will submit without my merge for checkup
Melissa Brown
@themelissabrown
Aug 31 2017 21:43
k
Matti Lahtinen
@Menithal
Aug 31 2017 21:43
Argh
there is a massive change
specifically needsUpdateModelBounds got completely refactored, which is exactly what I was changing too
Can I add a fee for this extra work?
Melissa Brown
@themelissabrown
Aug 31 2017 21:46
yeah, we can add a fee. Can I first put you in touch with the developer who did the refactor to see if he/she can give you any pointers that will save you time?
Matti Lahtinen
@Menithal
Aug 31 2017 21:47
Let me get the blame
Melissa Brown
@themelissabrown
Aug 31 2017 21:48
blame?
Matti Lahtinen
@Menithal
Aug 31 2017 21:48
that would be @jherico
Melissa Brown
@themelissabrown
Aug 31 2017 21:48
Its certainly not your fault we refactored without telling you
Matti Lahtinen
@Menithal
Aug 31 2017 21:48
Git Blame, aka who did the change
Melissa Brown
@themelissabrown
Aug 31 2017 21:48
hahahahaha
Someday I'll learn all of the terms
Clément Brisset
@Atlante45
Aug 31 2017 21:49
Yes, we just had a massive refactor to improve the threading of the rendering.
Matti Lahtinen
@Menithal
Aug 31 2017 21:50
Uff.
Ok, I guess Ill have to throw away that part and reimplement it into the refactored code
Melissa Brown
@themelissabrown
Aug 31 2017 21:51
let's have you chat with Jericho quickly and see if there's any work-around
Matti Lahtinen
@Menithal
Aug 31 2017 21:52
Basically, what I did to save translation position was load the original FBX Geometry joints and store them and reapply them, Will need to spend another weekend finding it again
finding a spot* that is,
Melissa Brown
@themelissabrown
Aug 31 2017 21:53
@Atlante45 any thoughts on a quicker solution for him?
Matti Lahtinen
@Menithal
Aug 31 2017 21:55
OH
wait I think I found a new spot to do it
Melissa Brown
@themelissabrown
Aug 31 2017 21:58
fingers crossed!
Clément Brisset
@Atlante45
Aug 31 2017 21:58
@jherico ^
Matti Lahtinen
@Menithal
Aug 31 2017 21:58
basically I think the git merge didnt succeed because there was so much more code added than what it could handle
I think the spot moved about 600 lines or so
Bradley Austin Davis
@jherico
Aug 31 2017 22:00
@Menithal check your PR. I merged from master and resolved the conflicts manually.
Matti Lahtinen
@Menithal
Aug 31 2017 22:01
Thanks!
Yeah I got really confused where it was trying to merge my code at, it looked completely different
Bradley Austin Davis
@jherico
Aug 31 2017 22:02
I may have screwed it up... the code you modified in RenderableModelEntityItem::getAnimationFrame now belongs in ModelEntityRenderer::animate
Matti Lahtinen
@Menithal
Aug 31 2017 22:03
yeah
i noticed that a bit further
ok, gonna test this, hopefully it works
... as soon as I get to build that is, apparently getting a whole bunch of IntelliSense errors
MAybe hudson is faster than me
Matti Lahtinen
@Menithal
Aug 31 2017 22:09
Going to look into the it tommorrow, now off to bed, hopefully the builds succeed!
Thanks for the quick fix on the merge @jherico
Bradley Austin Davis
@jherico
Aug 31 2017 22:10
I broke it, I bought it
elderorb
@ElderOrb
Aug 31 2017 22:10
Hi

have anybody confronted the following error with the latest builds?

[1:03]
Program: G:\hifi-elderorb-vs3\build\interface\Debug\Qt5Cored.dll
Module: 5.9.1
File: global\qglobal.cpp
Line: 3057

ASSERT failure in QCoreApplication::sendEvent: "Cannot send events to objects owned by a different thread. Current thread 0x0x1c36c9ac100. Receiver '' (of type 'QMenu') was created in thread 0x0x1c31c1b0d50", file kernel\qcoreapplication.cpp, line 563

[1:04]
asking to understand whether I should create a ticket or this is my environment

[1:04]
... or everybody using 'release' build configuration?

[1:06]
just in case here is the full stack trace:

Qt5Cored.dll!00000000695b45db()    Unknown    No symbols loaded.
 Qt5Cored.dll!00000000695b2e02()    Unknown    No symbols loaded.
 Qt5Cored.dll!00000000695a4ad1()    Unknown    No symbols loaded.
 Qt5Cored.dll!000000006999a25f()    Unknown    No symbols loaded.
 Qt5Widgetsd.dll!000000006a1b5e94()    Unknown    No symbols loaded.
 Qt5Cored.dll!00000000699987f6()    Unknown    No symbols loaded.
 Qt5Cored.dll!00000000699a3792()    Unknown    No symbols loaded.
 Qt5Widgetsd.dll!000000006a21b403()    Unknown    No symbols loaded.
 Qt5Widgetsd.dll!000000006a21b19f()    Unknown    No symbols loaded.
 Qt5Widgetsd.dll!000000006a474b1a()    Unknown    No symbols loaded.

openvr.dll!MenuWrapper::addAction(const QString & menuName) Line 598 C++ Symbols loaded.
openvr.dll!ui::Menu::addActionToQMenuAndActionHash(MenuWrapper destinationMenu, const QString & actionName, const QKeySequence & shortcut, const QObject receiver, const char member, QAction::MenuRole role, int menuItemLocation, const QString & grouping) Line 139 C++ Symbols loaded.
openvr.dll!PluginContainer::addMenuItem(PluginType type, const QString & path, const QString & name, std::function<void __cdecl(bool)> onClicked, bool checkable, bool checked, const QString & groupName) Line 49 C++ Symbols loaded.
openvr.dll!HmdDisplayPlugin::beginFrameRender(unsigned int frameIndex) Line 67 C++ Symbols loaded.
openvr.dll!OpenVrDisplayPlugin::beginFrameRender(unsigned int frameIndex) Line 599 C++ Symbols loaded.
interface.exe!Application::paintGL() Line 2400 C++ Symbols loaded.
interface.exe!RenderEventHandler::render() Line 261 C++ Symbols loaded.
interface.exe!RenderEventHandler::event(QEvent
event) Line 269 C++ Symbols loaded.

oops, bad formatting.. .
I beg pardon for this
Christoph Haag
@ChristophHaag
Aug 31 2017 22:15
threading in qt should likely be a bug in hifi
does anyone have an idea what could be causing this? possible driver bug? i think it happens with all dynamic lights/reflections in all environments: https://www.youtube.com/watch?v=GFv7PjH4dD0
elderorb
@ElderOrb
Aug 31 2017 22:17
threading in qt should likely be a bug in hifi
Absolutely! What is weird is that it appear at the beginning of this week and still not noticed by anyone
So I'm wondering if there is something wrong about my environment, or no one is using 'debug' build configuration
Clément Brisset
@Atlante45
Aug 31 2017 22:25
@samcake @jherico ^
Bradley Austin Davis
@jherico
Aug 31 2017 22:25
@ElderOrb try this PR: highfidelity/hifi#11293
no one really builds in debug mode here, but this has also been reported as a crash point even in release builds.
Clément Brisset
@Atlante45
Aug 31 2017 22:28
I build in debug pretty often. Especially when I work on server stuff.
I'm currently a couple weeks behind master, but my debug build renders correctly.
Christoph Haag
@ChristophHaag
Aug 31 2017 22:29
hm, menu stuff. should that fix the cause for which I had to use this? ChristophHaag/hifi@3da7637
Bradley Austin Davis
@jherico
Aug 31 2017 22:33
maybe
elderorb
@ElderOrb
Aug 31 2017 22:34
updating
elderorb
@ElderOrb
Aug 31 2017 23:02
@jherico On windows I'm getting this: 'Error C2665 'QTimer::defaultTypeFor': none of the 2 overloads could convert all the argument types display-plugins d:\qt\5.9.1\msvc2017_64\include\qtcore\qtimer.h 125 '
ChristophHaag @ChristophHaag will test this later
Bradley Austin Davis
@jherico
Aug 31 2017 23:28
i inverted the arguments... fixed
elderorb
@ElderOrb
Aug 31 2017 23:30
me too, but rebuild is so slow... :)
elderorb
@ElderOrb
Aug 31 2017 23:49
@jherico yes, your changes seems to resolve that particular issue
elderorb
@ElderOrb
Aug 31 2017 23:56
another observation: some changesets are not compilable in 'debug' (most likely due to not being build by 'gustavo'). is it possible to enable gustavo for 'debug' as well?
for example changeset '0ae8f4526e8074d6d952e20b7a830472e60e9482'