These are chat archives for highfidelity/hifi

1st
Feb 2018
Melissa Brown
@themelissabrown
Feb 01 2018 00:35
@ChristophHaag We're looking at your PRs from August and Sam tells me we just changed the gl system going away from glew to glad
So we don't know if you still need those changes.
Christoph Haag
@ChristophHaag
Feb 01 2018 00:36
cool, everything but glew 1.x
Melissa Brown
@themelissabrown
Feb 01 2018 00:36
We have some time to address them now if you do.
k, let me set you up to talk to Sam. Sorry this has taken so long
Christoph Haag
@ChristophHaag
Feb 01 2018 00:38
the main reason is that glew 1.x just doesn't work properly with an OpenGL Core context, so you set glewExperimental=GL_TRUE; which kinda makes it work but is not the proper way
with another gl extension loader that won't be a problem
Melissa Brown
@themelissabrown
Feb 01 2018 00:39
email me: melissa@highfidelity.com and I'll invite you to our slack and set up convo with Sam
Christoph Haag
@ChristophHaag
Feb 01 2018 00:42
thanks for the offer but tbh I don't think it's necessary, I'll just rebase it and it will most likely just work
Melissa Brown
@themelissabrown
Feb 01 2018 00:43
we just need to be sure we review and get it merged if we need to
otherwise the PRs will get closed because they
they're so old
Melissa Brown
@themelissabrown
Feb 01 2018 00:46
we have moved away from glew entirely
so understanding what you need is definitely something Sam will want to figure out
Christoph Haag
@ChristophHaag
Feb 01 2018 00:49
that commit should probably a separate pull request. I believe gl drivers are not required to make glCompressedTextureSubImage2DEXT available in an opengl core context and I believe mesa doesn't and I believe it worked with glew 1.x's weird glewExperimental enabled, but not with a proper core context
or something like that
Melissa Brown
@themelissabrown
Feb 01 2018 00:52
:) I'll connect you to Sam to sort it out