Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 22 2019 23:01
    benhanna starred hrj/abandon
  • Dec 05 2018 07:38
    sanketvega starred hrj/abandon
  • Dec 05 2018 02:29

    hrj on master

    fix version for scala xml (compare)

  • Dec 04 2018 19:43

    hrj on master

    bump dependencies (compare)

  • Oct 30 2018 17:16
    cflavio starred hrj/abandon
  • Oct 02 2018 05:03
    nerdy-sam starred hrj/abandon
  • Sep 08 2018 20:18
    jethrovt starred hrj/abandon
  • Aug 18 2018 13:37
    hrj opened #154
  • Jun 12 2018 14:41

    hrj on master

    bumped version of scala parser … (compare)

  • Jun 08 2018 20:59
    musha68k starred hrj/abandon
  • Jun 05 2018 02:11
    maoabc2015 starred hrj/abandon
  • Jun 02 2018 19:09

    hrj on master

    Updated plugin buildinfo Signe… (compare)

  • Jun 02 2018 19:02

    hrj on master

    bumped scala and sbt versions (compare)

  • May 26 2018 04:19
    joyoyoyoyoyo starred hrj/abandon
  • May 17 2018 15:52
    evenhumble starred hrj/abandon
  • May 16 2018 14:56
    janez89 starred hrj/abandon
  • May 02 2018 17:28
    Samehadar starred hrj/abandon
  • Mar 20 2018 00:11
    MyNameIsCosmo starred hrj/abandon
  • Mar 13 2018 13:09
    vlamacko starred hrj/abandon
  • Mar 09 2018 07:17

    hrj on master

    bump the buildinfo plugin versi… (compare)

Chidu
@chidu8
it compiled successfully but did not generate a JAR in the target folder. Is this expected?
Oops
java.lang.UnsupportedClassVersionError: com/typesafe/config/ConfigException : Unsupported major.minor version 52.0
when i ran the cli
hrj
@hrj
oh. Looks like one of the libraries is depending on Java 8
so, you need java 8 :eyes:
Chidu
@chidu8
i will install :)
Chidu
@chidu8
it worked, awesome!
compiled and ran the example
i see .class files under target folder, but i don't see a JAR
that's fine, maybe sbt package builds the jar
Chidu
@chidu8
I'm sorry for bugging you :)
hrj
@hrj
the packaging is done with the assembly command. But you needn't worry about that during development.
Chidu
@chidu8
But could you also tell me if my thought process w.r.t SingleTransactions is correct, as commented here:
hrj/abandon#64
hrj
@hrj
good to hear that you have it working! Hopefully you have enough material to look at. Will answer your questions on github shortly.
Chidu
@chidu8
cool
hrj
@hrj
btw, another sbt command that you may find useful: eclipse
it generates the eclipse project files
Chidu
@chidu8
yes i did that already, and i'm viewing the project on eclipse!
hrj
@hrj
aweseome :+1:
Chidu
@chidu8
I have to carefully identify variable names which have to be changed. I will do that tomorrow. I am going to sleep now. Ttyl
Chidu
@chidu8
@hrj Does a sequence of detailedPosts ( Seq[DetailedPost]) automatically become a Transaction, or do they have to be balanced to be called one?
hrj
@hrj
Great question! I think we should only call a balanced group of posts a transaction.
Or put another way, a transaction is not just any group of posts, but is 1. a set of related posts 2. the related posts are balanced
Chidu
@chidu8
I have sent a PR of the changes done so far (which were low hanging). Other renames require a more thorough understanding (...for example what a group is)
@hrj
hrj
@hrj
cool, thanks! will have a look at it soon.
Chidu
@chidu8
You have CI- thats cool.
But the CI build failed
hrj
@hrj
the failure is due to a limitation in travis-ci
Chidu
@chidu8
oh okay
Chidu
@chidu8
This is the first time i'm using CI.
Pretty cool
hrj
@hrj
:) there's even integrated coverage tool
Chidu
@chidu8
i dont even know what that is :P
hrj
@hrj
but the pipeline is clogged due to the travis issue.
Oh, it indicates how much of the code has been covered by the tests.
Had a quick look at the PR and it looks fine
You can continue along the same path, and update the PR by pushing commits to the same branch.
Chidu
@chidu8
Thanks.
I would need some help in understanding the code, particularly Process.scala
..rather the design
hrj
@hrj
Hmm.. I don't know how much detail is required. I suggest you ask me questions and I will try to answer them.
or, for now, let's get the PR completed as much as possible and then tackle the unknown parts.
Chidu
@chidu8
okay
Chidu
@chidu8
Variable Refactoring (renaming) is not working in Scala IDE. Have you tried it?
Which IDE do you use?
hrj
@hrj
I use Eclipse Mars. Yeah, the refactoring doesn't always work well in Scala.
though it is much better than it used to be 6 years ago :smile:
hrj
@hrj
@chidu8 Is the PR ready to be merged? There are couple of renames pending, but I can do them myself after merging if you are not working on it.