however I can't implement that with current EntityEncoder trait
new EntityEncoder[F, RestResource[R]] {
override def toEntity(resource: RestResource[R]): Entity[F] = EE.toEntity(resource.body)
override def headers: Headers = Location(resource.uri)
}
you can see the last line... I don't have
resource available
I only can create a myme type header... which also would be static
and in my case I have a wrapper so I need also to generate the mime type on runtime
so I expect to have something like this on the headers function
override def headers(resource: RestResource[R]): Headers = Headers.of(Location(resource.uri), `Content-Type`(resource.mediaType))
so I create this RestResource wrapper which has the resource body, uri, links etc
@carlos-verdes This is actually the oldest open issue we have, and I recently revived it: http4s/http4s#146
I'm just coaching 11-year-olds now. :laughing:
I topped out at about U8, but my kids wanted to play. I volunteered to stripe the fields, ended up being handed a clipboard, and have been coaching for a decade. I just have to learn at least as fast as she grows up!
It's a great game, and I now regret not playing more before decrepitude set in.
I see you cover some of my concerns
you cover the 2 scenarios I would like to cover
1 - be able to generalize over Content-Type --> For example I want to create my custom vnd type
Content-type: application/vnd+company.category+json
trait HeaderGenerator[R] {
def headers[R]: Headers
}
new EntityEncoder[F, R] {
override def headers(implicit hd: HeaderGenerator[R]): Headers = hd.headers[R]
the other scenario needs access to the body:
2 - be able to generate a Header like Location --> if we don't want to apply this header on EntityEncoder at least provide another Type Class
... forget about last point
I'm just realising this should not be part of a generic encoder
Location is only present on 201 CREATED but it's not necessary on a 200 OK
also the resource could be part of a search result so it has no sense to have this header
Location Header should be applied only when creating our routing logic...
test example
case request @ POST -> Root / "mocks" =>
for {
mockRequest <- parseRequest[IO, Mock](request)
savedMock <- store[Mock](request.uri, mockRequest)
fetchedMock <- fetch[Mock](savedMock.uri)
} yield Created(fetchedMock.body, Location(fetchedMock.uri))
with uri + links + body I have almost all I need for REST API´s
I don't know if you thought to add this as part of HTTP4S
another element really useful in the ETags
I'm creating something like this as part of my business model
case class RestResource[R](uri: Uri, body: R, link: Link)
this can be an extension of Entity, something like:
case cass EntityResource(
uri: Uri,
body: EntityBody[F],
length: Option[Long],
links: Link)
The classic example of having a runtime encoder is multipart: we need access to the runtime value to be able to put the boundary parameter on the Content-Type.
Another one is files: runtime value of the file gets you the name gets you the Content-Disposition.
These are things we can't do with the current encoders. There's a special function somewhere to set a multipart entity, because the content-type isn't right without that second step.
