http4s/http4s

We're on discord at http://sca.la/typeleveldiscord (Please do not use threads)

Ross A. Baker

@rossabaker

Keeping it lazy in Http1Support is still important though.

We couldn't just strictly run that effect in Http1Support, or we'd break people who can't get an SSLContext and don't want one.

Christopher Davenport

@ChristopherDavenport

Really, how do you opt out?

As that seems like a value that could be evaluated and not properly seperated if we are concerned about that.

Ross A. Baker

@rossabaker

After the bug fix, you opt out today by not making https calls or by creating one that works.

Christopher Davenport

@ChristopherDavenport

Right, seems like we really could split that, rather than having a val that could blow up at any moment in a server that doesn’t intend to support http4s

Not really relevant to this iteration, but long term. Why have both in the same thing rather than a coproduct.

Ross A. Baker

@rossabaker

I'm hazy on what we're splitting.

Christopher Davenport

@ChristopherDavenport

SSL capable servers.

Or clients.

Fabio Labella

@SystemFw

I really want (implicit XYZ)(argumentList)

What's the implicit there? (quickly scrolling)

Ross A. Baker

@rossabaker

Oh... well... hmm.

Christopher Davenport

@ChristopherDavenport

But basically the lazy val is what protects us from blowing up.

Ross A. Baker

@rossabaker

We don't have secure and unsecure requests at the type level.

Christopher Davenport

@ChristopherDavenport

@SystemFw (implicit F: Sync[F])(foo : F[XYZ] = F.delay(xyz))

Fabio Labella

@SystemFw

any other arguments before F?

Christopher Davenport

@ChristopherDavenport

No, I want implicit list first.

Fabio Labella

@SystemFw

why?

(not arguing, just need a quick summary)

Christopher Davenport

@ChristopherDavenport

For defaults, I can do it with a partially applied trick. But its dirty. We do this with things like Logger where we take a Option[String => F[Unit]], and if not supplied one we get the default using the sync instance internally.

Fabio Labella

@SystemFw

because at some point I did various tricks, whose implementations are awful, but managed to encode a lot of these weird requirements, so I'd like to play with that

Christopher Davenport

@ChristopherDavenport

But that’s just a workaround for implicit position.

Ross A. Baker

@rossabaker

Add an argument to BlazeClientBuilder in F that defaults to F.delay(...) and you'll get a taste of the problem being discussed. Though that can minimize to other toy examples quite readily.

Every time I've wanted to do that I've later refactored away from it. Maybe it's good that we can't.

Fabio Labella

@SystemFw

I think that's enough

def foo[F[_]: Sync](log: String => F[Unit] = (x: String) => F.delay(println(x)): Thing

that's the problem right?

Ross A. Baker

@rossabaker

I wish we had a failsafe way to create an SSLContext, although the only way to do so would be if we could create one that was guaranteed to fail, in which case it's not too different from an Option... or a lazily guarded one. It's all in the message.

Yeah, that's another variant.

Fabio Labella

@SystemFw

you also want named arguments, or is withLog enough?

Ross A. Baker

@rossabaker

Because the Sync[F] is really in a parameter list after the log.

Uh... withLog would be sufficient for this use case.

Christopher Davenport

@ChristopherDavenport

def logMe[F[_]: Sync](s: String, logAction: Option[String => F[Unit]]): F[Unit] = {
    val log = logAction.getOrElse({s => Sync[F].delay(println(s))})
    log(s)
  }

Option variant

Ross A. Baker

@rossabaker

All of our other configs are inspectable before they're built, so I don't really like the laziness/optionality of it.

Fabio Labella

@SystemFw

you could build a bunch of different apis.

thing.withFoo(...).withBar(...)
thing { builder => builder(foo = myFoo, bar) }

Christopher Davenport

@ChristopherDavenport

def logMe[F[_]: Sync] = new logMePartiallyApplied[F]
private class logMePartiallyApplied[F[_]: Sync]{
    def apply(s: String, logAction: String => F[Unit] = {s => Sync[F].delay(println(s))}) = 
      logAction(s)
  }

Partially applied approach.

Ross A. Baker

@rossabaker

I'd like to be able to have a default argument that might fall through to an implementation of last resort, but Java doesn't let us define that for this type.

Fabio Labella

@SystemFw

right, ok

Christopher Davenport

@ChristopherDavenport

The intriguing part to me, is that due to the implicit nature, that partially applied variant is always equivalent.

Fabio Labella

@SystemFw

@ChristopherDavenport I'm not sure the partially applied works, you need a different name

as it stands, logMe[IO]("hello") will think that "hello" is Sync[F]

iirc I did make something similar work at some point, with apply, but it's more horrendous in implementation

like you need a magnet and so on

Christopher Davenport

@ChristopherDavenport

:scream: It gets worse.

Fabio Labella

@SystemFw

 found   : String("hello")
[error]  required: cats.effect.Sync[cats.effect.IO]
[error]   logMe[IO]("hello")

yep

Gavin Bisesi

@Daenyth

needs moar scala3 :p

Fabio Labella

@SystemFw

well, an easy fix for your code is renaming apply to of or build

(fun fact, when I originally suggested HttpRoutes.of I got the name while hacking on this exact problem)

(I mean the name HttpRoutes.of, not the idea, ofc)

Christopher Davenport

@ChristopherDavenport

Right, but what I really want is a rather simple syntactic change, and should be able to be automated somehow.

Fabio Labella

@SystemFw

heh, I'm not sure it's that simple, all things considered

Where communities thrive

People

Repo info

Activity